From: Mario Limonciello <mario.limonciello@amd.com>
To: "Borislav Petkov" <bp@alien8.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: <x86@kernel.org>, "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>
Subject: [PATCH v2 07/13] platform/x86: hfi: init per-cpu scores for each class
Date: Thu, 10 Oct 2024 14:36:59 -0500 [thread overview]
Message-ID: <20241010193705.10362-8-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241010193705.10362-1-mario.limonciello@amd.com>
From: Perry Yuan <Perry.Yuan@amd.com>
Initialize per cpu score `amd_hfi_ipcc_scores` which store energy score
and performance score data for each class.
`Classic core` and `Dense core` are ranked according to those values as
energy efficiency capability or performance capability.
OS scheduler will pick cores from the ranking list on each class ID for
the thread which provide the class id got from hardware feedback
interface.
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
Co-developed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2:
* Rework
---
drivers/platform/x86/amd/hfi/hfi.c | 32 ++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
index 10651399cf75..c0065ba0ed18 100644
--- a/drivers/platform/x86/amd/hfi/hfi.c
+++ b/drivers/platform/x86/amd/hfi/hfi.c
@@ -119,6 +119,8 @@ struct amd_hfi_cpuinfo {
static DEFINE_PER_CPU(struct amd_hfi_cpuinfo, amd_hfi_cpuinfo) = {.class_index = -1};
+static DEFINE_MUTEX(hfi_cpuinfo_lock);
+
static int find_cpu_index_by_apicid(unsigned int target_apicid)
{
int cpu_index;
@@ -233,6 +235,31 @@ static void amd_hfi_remove(struct platform_device *pdev)
mutex_destroy(&dev->lock);
}
+static int amd_set_hfi_ipcc_score(struct amd_hfi_cpuinfo *hfi_cpuinfo, int cpu)
+{
+ for (int i = 0; i < hfi_cpuinfo->nr_class; i++)
+ WRITE_ONCE(hfi_cpuinfo->ipcc_scores[i],
+ hfi_cpuinfo->amd_hfi_classes[i].perf);
+
+ return 0;
+}
+
+static int update_hfi_ipcc_scores(struct amd_hfi_data *amd_hfi_data)
+{
+ int cpu;
+ int ret;
+
+ for_each_online_cpu(cpu) {
+ struct amd_hfi_cpuinfo *hfi_cpuinfo = per_cpu_ptr(&amd_hfi_cpuinfo, cpu);
+
+ ret = amd_set_hfi_ipcc_score(hfi_cpuinfo, cpu);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
static int amd_hfi_metadata_parser(struct platform_device *pdev,
struct amd_hfi_data *amd_hfi_data)
{
@@ -330,6 +357,11 @@ static int amd_hfi_probe(struct platform_device *pdev)
if (ret)
goto out;
+ /* set up IPCC scores */
+ ret = update_hfi_ipcc_scores(amd_hfi_data);
+ if (ret)
+ goto out;
+
out:
return ret;
}
--
2.43.0
next prev parent reply other threads:[~2024-10-10 19:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 19:36 [PATCH v2 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2024-10-10 19:36 ` [PATCH v2 01/13] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2024-10-12 3:53 ` Bagas Sanjaya
2024-10-10 19:36 ` [PATCH v2 02/13] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2024-10-10 19:36 ` [PATCH v2 03/13] x86/cpufeatures: add X86_FEATURE_WORKLOAD_CLASS feature bit Mario Limonciello
2024-10-10 19:36 ` [PATCH v2 04/13] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2024-10-10 19:36 ` [PATCH v2 05/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2024-10-14 9:10 ` Ilpo Järvinen
2024-10-14 19:46 ` Mario Limonciello
2024-10-14 9:20 ` Ilpo Järvinen
2024-10-15 3:52 ` Ricardo Neri
2024-10-15 18:09 ` Mario Limonciello
2024-10-17 23:33 ` Ricardo Neri
2024-10-18 13:46 ` Mario Limonciello
2024-10-16 9:36 ` Uwe Kleine-König
2024-10-16 9:59 ` Hans de Goede
2024-10-16 16:06 ` Mario Limonciello
2024-10-10 19:36 ` [PATCH v2 06/13] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2024-10-14 10:14 ` Ilpo Järvinen
2024-10-14 20:09 ` Mario Limonciello
2024-10-10 19:36 ` Mario Limonciello [this message]
2024-10-14 10:15 ` [PATCH v2 07/13] platform/x86: hfi: init per-cpu scores for each class Ilpo Järvinen
2024-10-10 19:37 ` [PATCH v2 08/13] platform/x86: hfi: add online and offline callback support Mario Limonciello
2024-10-14 10:27 ` Ilpo Järvinen
2024-10-10 19:37 ` [PATCH v2 09/13] platform/x86: hfi: add power management callback Mario Limonciello
2024-10-14 10:29 ` Ilpo Järvinen
2024-10-10 19:37 ` [PATCH v2 10/13] x86/cpu: Enable SD_ASYM_PACKING for DIE Domain on AMD Processors Mario Limonciello
2024-10-10 19:37 ` [PATCH v2 11/13] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2024-10-10 19:37 ` [PATCH v2 12/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2024-10-10 19:37 ` [PATCH v2 13/13] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2024-10-11 0:54 ` [PATCH v2 00/13] Add support for AMD hardware feedback interface Bagas Sanjaya
2024-10-11 1:29 ` Mario Limonciello
2024-10-12 2:21 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010193705.10362-8-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bp@alien8.de \
--cc=gautham.shenoy@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox