The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] [v2] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER
@ 2024-10-15 15:34 Arnd Bergmann
  2024-10-15 16:49 ` Jessica Zhang
  2024-10-16  8:21 ` Neil Armstrong
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-10-15 15:34 UTC (permalink / raw)
  To: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, Dzmitry Sankouski
  Cc: Arnd Bergmann, Jessica Zhang, Dmitry Baryshkov,
	Geert Uytterhoeven, Cong Yang, Michael Trimarchi, Randy Dunlap,
	dri-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The new driver needs the dsc helper code to be available:

x86_64-linux-ld: vmlinux.o: in function `s6e3ha8_amb577px01_wqhd_prepare':
panel-samsung-s6e3ha8.c:(.text+0x16b1e65): undefined reference to `drm_dsc_pps_payload_pack'

Select it from Kconfig as we do for other similar drivers.

Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: add dependency to the correct driver
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index ddfaa99ea9dd..128c12e8b84f 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -703,6 +703,7 @@ config DRM_PANEL_SAMSUNG_S6E3HA8
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DSC_HELPER
 	select VIDEOMODE_HELPERS
 
 config DRM_PANEL_SAMSUNG_S6E63J0X03
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER
  2024-10-15 15:34 [PATCH] [v2] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER Arnd Bergmann
@ 2024-10-15 16:49 ` Jessica Zhang
  2024-10-16  8:21 ` Neil Armstrong
  1 sibling, 0 replies; 3+ messages in thread
From: Jessica Zhang @ 2024-10-15 16:49 UTC (permalink / raw)
  To: Arnd Bergmann, Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, Dzmitry Sankouski
  Cc: Arnd Bergmann, Dmitry Baryshkov, Geert Uytterhoeven, Cong Yang,
	Michael Trimarchi, Randy Dunlap, dri-devel, linux-kernel



On 10/15/2024 8:34 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The new driver needs the dsc helper code to be available:
> 
> x86_64-linux-ld: vmlinux.o: in function `s6e3ha8_amb577px01_wqhd_prepare':
> panel-samsung-s6e3ha8.c:(.text+0x16b1e65): undefined reference to `drm_dsc_pps_payload_pack'
> 
> Select it from Kconfig as we do for other similar drivers.
> 
> Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Hi Arnd,

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang

> ---
> v2: add dependency to the correct driver
> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index ddfaa99ea9dd..128c12e8b84f 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -703,6 +703,7 @@ config DRM_PANEL_SAMSUNG_S6E3HA8
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_DSC_HELPER
>   	select VIDEOMODE_HELPERS
>   
>   config DRM_PANEL_SAMSUNG_S6E63J0X03
> -- 
> 2.39.5
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER
  2024-10-15 15:34 [PATCH] [v2] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER Arnd Bergmann
  2024-10-15 16:49 ` Jessica Zhang
@ 2024-10-16  8:21 ` Neil Armstrong
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2024-10-16  8:21 UTC (permalink / raw)
  To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Dzmitry Sankouski, Arnd Bergmann
  Cc: Arnd Bergmann, Jessica Zhang, Dmitry Baryshkov,
	Geert Uytterhoeven, Cong Yang, Michael Trimarchi, Randy Dunlap,
	dri-devel, linux-kernel

Hi,

On Tue, 15 Oct 2024 15:34:38 +0000, Arnd Bergmann wrote:
> The new driver needs the dsc helper code to be available:
> 
> x86_64-linux-ld: vmlinux.o: in function `s6e3ha8_amb577px01_wqhd_prepare':
> panel-samsung-s6e3ha8.c:(.text+0x16b1e65): undefined reference to `drm_dsc_pps_payload_pack'
> 
> Select it from Kconfig as we do for other similar drivers.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/fd3b2c5f40a1e028bc813284260d430257444334

-- 
Neil


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-16  8:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 15:34 [PATCH] [v2] drm/panel: s6e3ha8: select CONFIG_DRM_DISPLAY_DSC_HELPER Arnd Bergmann
2024-10-15 16:49 ` Jessica Zhang
2024-10-16  8:21 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox