* [PATCH -next] iio: imu: bmi270: Remove duplicated include in bmi270_i2c.c
@ 2024-10-16 0:39 Yang Li
2024-10-16 2:31 ` Alex Lanzano
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2024-10-16 0:39 UTC (permalink / raw)
To: lanzano.alex, jic23, lars; +Cc: linux-iio, linux-kernel, Yang Li, Abaci Robot
The header files linux/module.h is included twice in bmi270_i2c.c,
so one inclusion of each can be removed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/iio/imu/bmi270/bmi270_i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
index e9025d22d5cc..71cc271cdf30 100644
--- a/drivers/iio/imu/bmi270/bmi270_i2c.c
+++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
@@ -3,7 +3,6 @@
#include <linux/module.h>
#include <linux/i2c.h>
#include <linux/iio/iio.h>
-#include <linux/module.h>
#include <linux/mod_devicetable.h>
#include <linux/regmap.h>
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] iio: imu: bmi270: Remove duplicated include in bmi270_i2c.c
2024-10-16 0:39 [PATCH -next] iio: imu: bmi270: Remove duplicated include in bmi270_i2c.c Yang Li
@ 2024-10-16 2:31 ` Alex Lanzano
2024-10-17 17:55 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Alex Lanzano @ 2024-10-16 2:31 UTC (permalink / raw)
To: Yang Li; +Cc: jic23, lars, linux-iio, linux-kernel, Abaci Robot
On Wed, Oct 16, 2024 at 08:39:19AM +0800, Yang Li wrote:
> The header files linux/module.h is included twice in bmi270_i2c.c,
> so one inclusion of each can be removed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/iio/imu/bmi270/bmi270_i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> index e9025d22d5cc..71cc271cdf30 100644
> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -3,7 +3,6 @@
> #include <linux/module.h>
> #include <linux/i2c.h>
> #include <linux/iio/iio.h>
> -#include <linux/module.h>
> #include <linux/mod_devicetable.h>
> #include <linux/regmap.h>
Good catch!
Minor nit: Should remove the top module.h include instead to keep
alphabetical ordering.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] iio: imu: bmi270: Remove duplicated include in bmi270_i2c.c
2024-10-16 2:31 ` Alex Lanzano
@ 2024-10-17 17:55 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2024-10-17 17:55 UTC (permalink / raw)
To: Alex Lanzano; +Cc: Yang Li, lars, linux-iio, linux-kernel, Abaci Robot
On Tue, 15 Oct 2024 22:31:57 -0400
Alex Lanzano <lanzano.alex@gmail.com> wrote:
> On Wed, Oct 16, 2024 at 08:39:19AM +0800, Yang Li wrote:
> > The header files linux/module.h is included twice in bmi270_i2c.c,
> > so one inclusion of each can be removed.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > drivers/iio/imu/bmi270/bmi270_i2c.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> > index e9025d22d5cc..71cc271cdf30 100644
> > --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> > +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> > @@ -3,7 +3,6 @@
> > #include <linux/module.h>
> > #include <linux/i2c.h>
> > #include <linux/iio/iio.h>
> > -#include <linux/module.h>
> > #include <linux/mod_devicetable.h>
> > #include <linux/regmap.h>
>
> Good catch!
>
> Minor nit: Should remove the top module.h include instead to keep
> alphabetical ordering.
>
Given I messed up the pull request anyway, I've snuck this one is
as an obviously fine last minute tidy up. With the other entry removed as
suggested.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-17 17:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-16 0:39 [PATCH -next] iio: imu: bmi270: Remove duplicated include in bmi270_i2c.c Yang Li
2024-10-16 2:31 ` Alex Lanzano
2024-10-17 17:55 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox