public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS E1404FA
@ 2024-10-15 14:01 Илья Яковлев
  2024-10-15 15:41 ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Илья Яковлев @ 2024-10-15 14:01 UTC (permalink / raw)
  To: linux-sound, linux-kernel, broonie


[-- Attachment #1.1: Type: text/plain, Size: 99 bytes --]

ASUS VivoBook E1404FA needs a quirks-table entry for the internal
microphone to function properly.

[-- Attachment #1.2: Type: text/html, Size: 339 bytes --]

[-- Attachment #2: Asus_E1404FA_dmic.patch --]
[-- Type: text/x-patch, Size: 687 bytes --]

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index ace6328..d06c162 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -325,6 +325,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"),
                }
        },
+       {
+               .driver_data = &acp6x_card,
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "E1404FA"),
+               }
+       },
        {
                .driver_data = &acp6x_card,
                .matches = {

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS E1404FA
  2024-10-15 14:01 Илья Яковлев
@ 2024-10-15 15:41 ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-10-15 15:41 UTC (permalink / raw)
  To: Илья Яковлев
  Cc: linux-sound, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

On Tue, Oct 15, 2024 at 09:01:39PM +0700, Илья Яковлев wrote:
> ASUS VivoBook E1404FA needs a quirks-table entry for the internal
> microphone to function properly.

> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index ace6328..d06c162 100644

You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS E1404FA
@ 2024-10-16  3:40 Ilya Dudikov
  2024-10-18 17:43 ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Ilya Dudikov @ 2024-10-16  3:40 UTC (permalink / raw)
  To: linux-sound, linux-kernel, broonie
  Cc: Ilya Dudikov, perex, lgirdwood, mario.limonciello

From: Ilya Dudikov <ilyadud@mail.ru>

ASUS Vivobook E1404FA needs a quirks-table entry for the internal microphone to function properly.

Signed-off-by: Ilya Dudikov <ilyadud@mail.ru>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index ace6328e91e3..d06c162701d2 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -325,6 +325,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "E1404FA"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS E1404FA
  2024-10-16  3:40 [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS E1404FA Ilya Dudikov
@ 2024-10-18 17:43 ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-10-18 17:43 UTC (permalink / raw)
  To: linux-sound, linux-kernel, Ilya Dudikov
  Cc: Ilya Dudikov, perex, lgirdwood, mario.limonciello

On Wed, 16 Oct 2024 10:40:37 +0700, Ilya Dudikov wrote:
> ASUS Vivobook E1404FA needs a quirks-table entry for the internal microphone to function properly.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Fix non-functional mic on ASUS E1404FA
      commit: b0867999e3282378a0b26a7ad200233044d31eca

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-18 17:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-16  3:40 [PATCH] ASoC: amd: yc: Fix non-functional mic on ASUS E1404FA Ilya Dudikov
2024-10-18 17:43 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2024-10-15 14:01 Илья Яковлев
2024-10-15 15:41 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox