* [PATCH] ASoC: amd: acp: Add stream name to ACP PDM DMIC devices
@ 2024-10-17 17:45 Mario Limonciello
0 siblings, 0 replies; 3+ messages in thread
From: Mario Limonciello @ 2024-10-17 17:45 UTC (permalink / raw)
To: Mark Brown, Jaroslav Kysela, Takashi Iwai, Vijendar Mukunda
Cc: open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list, Mario Limonciello
From: Mario Limonciello <mario.limonciello@amd.com>
This makes the devices consistent with the earlier acp devices.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
sound/soc/amd/acp/acp-rembrandt.c | 1 +
sound/soc/amd/acp/acp-renoir.c | 1 +
sound/soc/amd/acp/acp63.c | 1 +
sound/soc/amd/acp/acp70.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/sound/soc/amd/acp/acp-rembrandt.c b/sound/soc/amd/acp/acp-rembrandt.c
index 008d97598b629..1ed85cf76f520 100644
--- a/sound/soc/amd/acp/acp-rembrandt.c
+++ b/sound/soc/amd/acp/acp-rembrandt.c
@@ -153,6 +153,7 @@ static struct snd_soc_dai_driver acp_rmb_dai[] = {
.name = "acp-pdm-dmic",
.id = DMIC_INSTANCE,
.capture = {
+ .stream_name = "DMIC capture",
.rates = SNDRV_PCM_RATE_8000_48000,
.formats = SNDRV_PCM_FMTBIT_S32_LE,
.channels_min = 2,
diff --git a/sound/soc/amd/acp/acp-renoir.c b/sound/soc/amd/acp/acp-renoir.c
index 166f1efacf1d8..b9339bde34adc 100644
--- a/sound/soc/amd/acp/acp-renoir.c
+++ b/sound/soc/amd/acp/acp-renoir.c
@@ -131,6 +131,7 @@ static struct snd_soc_dai_driver acp_renoir_dai[] = {
.name = "acp-pdm-dmic",
.id = DMIC_INSTANCE,
.capture = {
+ .stream_name = "DMIC capture",
.rates = SNDRV_PCM_RATE_8000_48000,
.formats = SNDRV_PCM_FMTBIT_S32_LE,
.channels_min = 2,
diff --git a/sound/soc/amd/acp/acp63.c b/sound/soc/amd/acp/acp63.c
index e0b86132eb958..feb619f1e1ef8 100644
--- a/sound/soc/amd/acp/acp63.c
+++ b/sound/soc/amd/acp/acp63.c
@@ -147,6 +147,7 @@ static struct snd_soc_dai_driver acp63_dai[] = {
.name = "acp-pdm-dmic",
.id = DMIC_INSTANCE,
.capture = {
+ .stream_name = "DMIC capture",
.rates = SNDRV_PCM_RATE_8000_48000,
.formats = SNDRV_PCM_FMTBIT_S32_LE,
.channels_min = 2,
diff --git a/sound/soc/amd/acp/acp70.c b/sound/soc/amd/acp/acp70.c
index 3e4fd113a8a41..fe830c270463e 100644
--- a/sound/soc/amd/acp/acp70.c
+++ b/sound/soc/amd/acp/acp70.c
@@ -126,6 +126,7 @@ static struct snd_soc_dai_driver acp70_dai[] = {
.name = "acp-pdm-dmic",
.id = DMIC_INSTANCE,
.capture = {
+ .stream_name = "DMIC capture",
.rates = SNDRV_PCM_RATE_8000_48000,
.formats = SNDRV_PCM_FMTBIT_S32_LE,
.channels_min = 2,
base-commit: 469819cc17368702a6f68cec2148f518d3f3679b
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ASoC: amd: acp: Add stream name to ACP PDM DMIC devices
@ 2024-10-17 21:09 Mario Limonciello
2024-10-18 20:01 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Mario Limonciello @ 2024-10-17 21:09 UTC (permalink / raw)
To: Mark Brown, Jaroslav Kysela, Takashi Iwai, Vijendar Mukunda
Cc: open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list, Mario Limonciello
From: Mario Limonciello <mario.limonciello@amd.com>
Add for sof and legacy dai links to dummy DMIC codec.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
sound/soc/amd/acp/acp-mach-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
index e9ff4815c12c8..893ab814cbbdf 100644
--- a/sound/soc/amd/acp/acp-mach-common.c
+++ b/sound/soc/amd/acp/acp-mach-common.c
@@ -1567,6 +1567,7 @@ int acp_sofdsp_dai_links_create(struct snd_soc_card *card)
if (drv_data->dmic_cpu_id == DMIC) {
links[i].name = "acp-dmic-codec";
+ links[i].stream_name = "DMIC capture";
links[i].id = DMIC_BE_ID;
links[i].codecs = dmic_codec;
links[i].num_codecs = ARRAY_SIZE(dmic_codec);
@@ -1749,6 +1750,7 @@ int acp_legacy_dai_links_create(struct snd_soc_card *card)
if (drv_data->dmic_cpu_id == DMIC) {
links[i].name = "acp-dmic-codec";
+ links[i].stream_name = "DMIC capture";
links[i].id = DMIC_BE_ID;
if (drv_data->dmic_codec_id == DMIC) {
links[i].codecs = dmic_codec;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: amd: acp: Add stream name to ACP PDM DMIC devices
2024-10-17 21:09 [PATCH] ASoC: amd: acp: Add stream name to ACP PDM DMIC devices Mario Limonciello
@ 2024-10-18 20:01 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-10-18 20:01 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Vijendar Mukunda,
Mario Limonciello
Cc: linux-sound, linux-kernel, Mario Limonciello
On Thu, 17 Oct 2024 16:09:52 -0500, Mario Limonciello wrote:
> Add for sof and legacy dai links to dummy DMIC codec.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: acp: Add stream name to ACP PDM DMIC devices
commit: b2385de2ae11bdd34855276e0a254109469227eb
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-18 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-17 21:09 [PATCH] ASoC: amd: acp: Add stream name to ACP PDM DMIC devices Mario Limonciello
2024-10-18 20:01 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2024-10-17 17:45 Mario Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox