* [PATCH] drivers/pcwd_pci:Fix the wrong format specifier
@ 2024-10-08 8:48 Zhu Jun
2024-11-04 13:59 ` Wim Van Sebroeck
0 siblings, 1 reply; 2+ messages in thread
From: Zhu Jun @ 2024-10-08 8:48 UTC (permalink / raw)
To: wim; +Cc: linux, linux-watchdog, linux-kernel, zhujun2
The format specifier of "int" in printf() should be "%d", not
"%u".
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
drivers/watchdog/pcwd_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
index a489b426f2ba..3672e7f23b39 100644
--- a/drivers/watchdog/pcwd_pci.c
+++ b/drivers/watchdog/pcwd_pci.c
@@ -230,7 +230,7 @@ static void pcipcwd_show_card_info(void)
got_fw_rev = send_command(CMD_GET_FIRMWARE_VERSION, &fw_rev_major,
&fw_rev_minor);
if (got_fw_rev)
- sprintf(fw_ver_str, "%u.%02u", fw_rev_major, fw_rev_minor);
+ sprintf(fw_ver_str, "%d.%02d", fw_rev_major, fw_rev_minor);
else
sprintf(fw_ver_str, "<card no answer>");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/pcwd_pci:Fix the wrong format specifier
2024-10-08 8:48 [PATCH] drivers/pcwd_pci:Fix the wrong format specifier Zhu Jun
@ 2024-11-04 13:59 ` Wim Van Sebroeck
0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2024-11-04 13:59 UTC (permalink / raw)
To: Zhu Jun; +Cc: wim, linux, linux-watchdog, linux-kernel
Hi Zhu,
> The format specifier of "int" in printf() should be "%d", not
> "%u".
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
> drivers/watchdog/pcwd_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
> index a489b426f2ba..3672e7f23b39 100644
> --- a/drivers/watchdog/pcwd_pci.c
> +++ b/drivers/watchdog/pcwd_pci.c
> @@ -230,7 +230,7 @@ static void pcipcwd_show_card_info(void)
> got_fw_rev = send_command(CMD_GET_FIRMWARE_VERSION, &fw_rev_major,
> &fw_rev_minor);
> if (got_fw_rev)
> - sprintf(fw_ver_str, "%u.%02u", fw_rev_major, fw_rev_minor);
> + sprintf(fw_ver_str, "%d.%02d", fw_rev_major, fw_rev_minor);
> else
> sprintf(fw_ver_str, "<card no answer>");
>
> --
> 2.17.1
%d = The argument is treated as an integer and presented as a (signed) decimal number.
%u = The argument is treated as an integer and presented as an unsigned decimal number.
I do hope that version number are unsigned...
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-04 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-08 8:48 [PATCH] drivers/pcwd_pci:Fix the wrong format specifier Zhu Jun
2024-11-04 13:59 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox