* [PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties
@ 2024-11-04 19:08 Rob Herring (Arm)
2024-11-09 15:20 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-11-04 19:08 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen; +Cc: linux-iio, linux-kernel
The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/iio/dac/mcp4725.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
index 25bb1c0490af..1337fb02ccf5 100644
--- a/drivers/iio/dac/mcp4725.c
+++ b/drivers/iio/dac/mcp4725.c
@@ -379,7 +379,7 @@ static int mcp4725_probe_dt(struct device *dev,
struct mcp4725_platform_data *pdata)
{
/* check if is the vref-supply defined */
- pdata->use_vref = device_property_read_bool(dev, "vref-supply");
+ pdata->use_vref = device_property_present(dev, "vref-supply");
pdata->vref_buffered =
device_property_read_bool(dev, "microchip,vref-buffered");
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties
2024-11-04 19:08 [PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties Rob Herring (Arm)
@ 2024-11-09 15:20 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-11-09 15:20 UTC (permalink / raw)
To: Rob Herring (Arm); +Cc: Lars-Peter Clausen, linux-iio, linux-kernel
On Mon, 4 Nov 2024 13:08:46 -0600
"Rob Herring (Arm)" <robh@kernel.org> wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied to the testing branch of iio.git. I'll rebase that on 6.13-rc1
once available and push out for linux-next to pick up.
thanks,
Jonathan
> ---
> drivers/iio/dac/mcp4725.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
> index 25bb1c0490af..1337fb02ccf5 100644
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -379,7 +379,7 @@ static int mcp4725_probe_dt(struct device *dev,
> struct mcp4725_platform_data *pdata)
> {
> /* check if is the vref-supply defined */
> - pdata->use_vref = device_property_read_bool(dev, "vref-supply");
> + pdata->use_vref = device_property_present(dev, "vref-supply");
> pdata->vref_buffered =
> device_property_read_bool(dev, "microchip,vref-buffered");
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-09 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-04 19:08 [PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties Rob Herring (Arm)
2024-11-09 15:20 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox