* [PATCH] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF, not select it
@ 2024-11-29 10:41 Ricardo Ribalda
2024-11-29 17:45 ` Herve Codina
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Ribalda @ 2024-11-29 10:41 UTC (permalink / raw)
To: Herve Codina, Derek Kiernan, Dragan Cvetic, Arnd Bergmann,
Greg Kroah-Hartman
Cc: linux-kernel, Ricardo Ribalda
Most (maybe all?) the drivers depend on OF instead of selecting it. This
is more convenient for CI because we can have test scripts that do:
make allyesconfig
scripts/config -d OF
make olddefconfig
Without this patch, OF cannot be disabled that way.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/misc/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 902c306bc972..2ea5f40ff4e4 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -612,8 +612,7 @@ config MARVELL_CN10K_DPI
config MCHP_LAN966X_PCI
tristate "Microchip LAN966x PCIe Support"
- depends on PCI
- select OF
+ depends on PCI && OF
select OF_OVERLAY
select IRQ_DOMAIN
help
---
base-commit: 7af08b57bcb9ebf78675c50069c54125c0a8b795
change-id: 20241129-lan966x-depend-8bc69b4954e5
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF, not select it
2024-11-29 10:41 [PATCH] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF, not select it Ricardo Ribalda
@ 2024-11-29 17:45 ` Herve Codina
2024-11-29 17:57 ` Ricardo Ribalda
0 siblings, 1 reply; 4+ messages in thread
From: Herve Codina @ 2024-11-29 17:45 UTC (permalink / raw)
To: Ricardo Ribalda
Cc: Derek Kiernan, Dragan Cvetic, Arnd Bergmann, Greg Kroah-Hartman,
linux-kernel
Hi Ricardo,
On Fri, 29 Nov 2024 10:41:17 +0000
Ricardo Ribalda <ribalda@chromium.org> wrote:
> Most (maybe all?) the drivers depend on OF instead of selecting it. This
> is more convenient for CI because we can have test scripts that do:
> make allyesconfig
> scripts/config -d OF
> make olddefconfig
>
> Without this patch, OF cannot be disabled that way.
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/misc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 902c306bc972..2ea5f40ff4e4 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -612,8 +612,7 @@ config MARVELL_CN10K_DPI
>
> config MCHP_LAN966X_PCI
> tristate "Microchip LAN966x PCIe Support"
> - depends on PCI
> - select OF
> + depends on PCI && OF
> select OF_OVERLAY
> select IRQ_DOMAIN
> help
>
> ---
> base-commit: 7af08b57bcb9ebf78675c50069c54125c0a8b795
> change-id: 20241129-lan966x-depend-8bc69b4954e5
>
Not sure it should be done that way (See [1]). Also I pointed out this
patch in the discussion.
[1] https://lore.kernel.org/all/dywwnh7ns47ffndsttstpcsw44avxjvzcddmceha7xavqjdi77@cqdgmpdtywol/
Best regards,
Hervé
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF, not select it
2024-11-29 17:45 ` Herve Codina
@ 2024-11-29 17:57 ` Ricardo Ribalda
2024-11-29 18:12 ` Herve Codina
0 siblings, 1 reply; 4+ messages in thread
From: Ricardo Ribalda @ 2024-11-29 17:57 UTC (permalink / raw)
To: Herve Codina
Cc: Derek Kiernan, Dragan Cvetic, Arnd Bergmann, Greg Kroah-Hartman,
linux-kernel
Thanks for the headsup
On Fri, 29 Nov 2024 at 18:45, Herve Codina <herve.codina@bootlin.com> wrote:
>
> Hi Ricardo,
>
> On Fri, 29 Nov 2024 10:41:17 +0000
> Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> > Most (maybe all?) the drivers depend on OF instead of selecting it. This
> > is more convenient for CI because we can have test scripts that do:
> > make allyesconfig
> > scripts/config -d OF
> > make olddefconfig
> >
> > Without this patch, OF cannot be disabled that way.
> >
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> > ---
> > drivers/misc/Kconfig | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index 902c306bc972..2ea5f40ff4e4 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -612,8 +612,7 @@ config MARVELL_CN10K_DPI
> >
> > config MCHP_LAN966X_PCI
> > tristate "Microchip LAN966x PCIe Support"
> > - depends on PCI
> > - select OF
> > + depends on PCI && OF
> > select OF_OVERLAY
> > select IRQ_DOMAIN
> > help
> >
> > ---
> > base-commit: 7af08b57bcb9ebf78675c50069c54125c0a8b795
> > change-id: 20241129-lan966x-depend-8bc69b4954e5
> >
>
> Not sure it should be done that way (See [1]). Also I pointed out this
> patch in the discussion.
>
I have no strong opinion for my version or:
depends on PCI && OF_OVERLAY
Shall I send a v2 or you prefer to handle it yourself?
Regards!
> [1] https://lore.kernel.org/all/dywwnh7ns47ffndsttstpcsw44avxjvzcddmceha7xavqjdi77@cqdgmpdtywol/
>
> Best regards,
> Hervé
--
Ricardo Ribalda
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF, not select it
2024-11-29 17:57 ` Ricardo Ribalda
@ 2024-11-29 18:12 ` Herve Codina
0 siblings, 0 replies; 4+ messages in thread
From: Herve Codina @ 2024-11-29 18:12 UTC (permalink / raw)
To: Ricardo Ribalda
Cc: Derek Kiernan, Dragan Cvetic, Arnd Bergmann, Greg Kroah-Hartman,
linux-kernel
Hi Ricardo,
On Fri, 29 Nov 2024 18:57:09 +0100
Ricardo Ribalda <ribalda@chromium.org> wrote:
> Thanks for the headsup
>
> On Fri, 29 Nov 2024 at 18:45, Herve Codina <herve.codina@bootlin.com> wrote:
> >
> > Hi Ricardo,
> >
> > On Fri, 29 Nov 2024 10:41:17 +0000
> > Ricardo Ribalda <ribalda@chromium.org> wrote:
> >
> > > Most (maybe all?) the drivers depend on OF instead of selecting it. This
> > > is more convenient for CI because we can have test scripts that do:
> > > make allyesconfig
> > > scripts/config -d OF
> > > make olddefconfig
> > >
> > > Without this patch, OF cannot be disabled that way.
> > >
> > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> > > ---
> > > drivers/misc/Kconfig | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index 902c306bc972..2ea5f40ff4e4 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -612,8 +612,7 @@ config MARVELL_CN10K_DPI
> > >
> > > config MCHP_LAN966X_PCI
> > > tristate "Microchip LAN966x PCIe Support"
> > > - depends on PCI
> > > - select OF
> > > + depends on PCI && OF
> > > select OF_OVERLAY
> > > select IRQ_DOMAIN
> > > help
> > >
> > > ---
> > > base-commit: 7af08b57bcb9ebf78675c50069c54125c0a8b795
> > > change-id: 20241129-lan966x-depend-8bc69b4954e5
> > >
> >
> > Not sure it should be done that way (See [1]). Also I pointed out this
> > patch in the discussion.
> >
>
> I have no strong opinion for my version or:
>
> depends on PCI && OF_OVERLAY
>
>
> Shall I send a v2 or you prefer to handle it yourself?
You can send a v2 with
depends on PCI
depends on OF_OVERLAY
If you send a v2, can you add people listed in
https://lore.kernel.org/all/dywwnh7ns47ffndsttstpcsw44avxjvzcddmceha7xavqjdi77@cqdgmpdtywol/
Best regards,
Hervé
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-29 18:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-29 10:41 [PATCH] misc: Kconfig: Make MCHP_LAN966X_PCI depend on OF, not select it Ricardo Ribalda
2024-11-29 17:45 ` Herve Codina
2024-11-29 17:57 ` Ricardo Ribalda
2024-11-29 18:12 ` Herve Codina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox