[PATCH] uio: uio_dmem_genirq: check the return value of devm_kasprintf()

[PATCH] uio: uio_dmem_genirq: check the return value of devm_kasprintf()

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

devm_kasprintf() can fail so check its return value and bail-out on no
memory.

Fixes: 52e2dc2ce2d8 ("uio: Convert a few more users to using %pOFn instead of device_node.name")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/uio/uio_dmem_genirq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
index c70dd81bfc61f..31aa75110ba59 100644
--- a/drivers/uio/uio_dmem_genirq.c
+++ b/drivers/uio/uio_dmem_genirq.c
@@ -167,6 +167,8 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)
 		}
 		uioinfo->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOFn",
 					       pdev->dev.of_node);
+		if (!uioinfo->name)
+			return -ENOMEM;
 		uioinfo->version = "devicetree";
 	}
 
-- 
2.45.2

Re: [PATCH] uio: uio_dmem_genirq: check the return value of devm_kasprintf()

[Bartosz Golaszewski]

On Mon, Dec 2, 2024 at 7:17 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> devm_kasprintf() can fail so check its return value and bail-out on no
> memory.
>
> Fixes: 52e2dc2ce2d8 ("uio: Convert a few more users to using %pOFn instead of device_node.name")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/uio/uio_dmem_genirq.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
> index c70dd81bfc61f..31aa75110ba59 100644
> --- a/drivers/uio/uio_dmem_genirq.c
> +++ b/drivers/uio/uio_dmem_genirq.c
> @@ -167,6 +167,8 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)
>                 }
>                 uioinfo->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOFn",
>                                                pdev->dev.of_node);
> +               if (!uioinfo->name)
> +                       return -ENOMEM;
>                 uioinfo->version = "devicetree";
>         }
>
> --
> 2.45.2
>

Gentle ping?

Bartosz

Re: [PATCH] uio: uio_dmem_genirq: check the return value of devm_kasprintf()

[Greg Kroah-Hartman]

On Fri, Jan 10, 2025 at 09:41:16AM +0100, Bartosz Golaszewski wrote:
> On Mon, Dec 2, 2024 at 7:17 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > devm_kasprintf() can fail so check its return value and bail-out on no
> > memory.
> >
> > Fixes: 52e2dc2ce2d8 ("uio: Convert a few more users to using %pOFn instead of device_node.name")
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> >  drivers/uio/uio_dmem_genirq.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
> > index c70dd81bfc61f..31aa75110ba59 100644
> > --- a/drivers/uio/uio_dmem_genirq.c
> > +++ b/drivers/uio/uio_dmem_genirq.c
> > @@ -167,6 +167,8 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)
> >                 }
> >                 uioinfo->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOFn",
> >                                                pdev->dev.of_node);
> > +               if (!uioinfo->name)
> > +                       return -ENOMEM;
> >                 uioinfo->version = "devicetree";
> >         }
> >
> > --
> > 2.45.2
> >
> 
> Gentle ping?

It's in my queue.  The "fix up an error path" patches are on the bottom
of all my reviews as generally they are a pain to review as it takes a
lot of out-of-band code reading.  And they have a bad history of being
wrong.  And they are really low on the priority as they really can't be
triggered :)

So I'll get to them, but realize that they are a pain to deal with...

thanks,

greg k-h