* drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
@ 2023-11-11 12:55 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2023-11-11 12:55 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: oe-kbuild-all, linux-kernel, Jens Axboe, Coly Li
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3ca112b71f35dd5d99fc4571a56b5fc6f0c15814
commit: a702a692cd7559053ea573f4e2c84828f0e62824 bcache: use a separate data structure for the on-disk super block
date: 3 years, 10 months ago
config: i386-randconfig-062-20230914 (https://download.01.org/0day-ci/archive/20231111/202311112007.VxK2JAc1-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231111/202311112007.VxK2JAc1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311112007.VxK2JAc1-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/md/bcache/super.c:108:24: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
drivers/md/bcache/super.c:108:24: sparse: expected unsigned int nr_keys
drivers/md/bcache/super.c:108:24: sparse: got restricted __le16 [usertype] keys
>> drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
drivers/md/bcache/super.c:237:21: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
drivers/md/bcache/super.c:237:21: sparse: expected unsigned int nr_keys
drivers/md/bcache/super.c:237:21: sparse: got restricted __le16 [usertype] keys
>> drivers/md/bcache/super.c:237:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le64 [usertype] csum @@ got unsigned long long @@
drivers/md/bcache/super.c:237:19: sparse: expected restricted __le64 [usertype] csum
drivers/md/bcache/super.c:237:19: sparse: got unsigned long long
drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
include/uapi/linux/bcache.h:345:38: sparse: sparse: array of flexible structures
drivers/md/bcache/super.c:574:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] prio @@ got restricted __le16 [usertype] @@
drivers/md/bcache/super.c:574:33: sparse: expected unsigned short [usertype] prio
drivers/md/bcache/super.c:574:33: sparse: got restricted __le16 [usertype]
drivers/md/bcache/super.c:642:27: sparse: sparse: cast to restricted __le16
drivers/md/bcache/super.c:744:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:744:32: sparse: expected unsigned int [usertype] invalidated
drivers/md/bcache/super.c:744:32: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1104:26: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] rtime @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1104:26: sparse: expected unsigned int [usertype] rtime
drivers/md/bcache/super.c:1104:26: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1148:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1148:32: sparse: expected unsigned int [usertype] invalidated
drivers/md/bcache/super.c:1148:32: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1502:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] last_reg @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1502:36: sparse: expected unsigned int [usertype] last_reg
drivers/md/bcache/super.c:1502:36: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
drivers/md/bcache/bset.h:231:36: sparse: sparse: array of flexible structures
vim +108 drivers/md/bcache/super.c
cafe563591446c Kent Overstreet 2013-03-23 61
cafe563591446c Kent Overstreet 2013-03-23 62 static const char *read_super(struct cache_sb *sb, struct block_device *bdev,
cafe563591446c Kent Overstreet 2013-03-23 63 struct page **res)
cafe563591446c Kent Overstreet 2013-03-23 64 {
cafe563591446c Kent Overstreet 2013-03-23 65 const char *err;
a702a692cd7559 Christoph Hellwig 2020-01-24 66 struct cache_sb_disk *s;
cafe563591446c Kent Overstreet 2013-03-23 67 struct buffer_head *bh = __bread(bdev, 1, SB_SIZE);
6f10f7d1b02b1b Coly Li 2018-08-11 68 unsigned int i;
cafe563591446c Kent Overstreet 2013-03-23 69
cafe563591446c Kent Overstreet 2013-03-23 70 if (!bh)
cafe563591446c Kent Overstreet 2013-03-23 71 return "IO error";
cafe563591446c Kent Overstreet 2013-03-23 72
a702a692cd7559 Christoph Hellwig 2020-01-24 73 s = (struct cache_sb_disk *)bh->b_data;
cafe563591446c Kent Overstreet 2013-03-23 74
cafe563591446c Kent Overstreet 2013-03-23 75 sb->offset = le64_to_cpu(s->offset);
cafe563591446c Kent Overstreet 2013-03-23 76 sb->version = le64_to_cpu(s->version);
cafe563591446c Kent Overstreet 2013-03-23 77
cafe563591446c Kent Overstreet 2013-03-23 78 memcpy(sb->magic, s->magic, 16);
cafe563591446c Kent Overstreet 2013-03-23 79 memcpy(sb->uuid, s->uuid, 16);
cafe563591446c Kent Overstreet 2013-03-23 80 memcpy(sb->set_uuid, s->set_uuid, 16);
cafe563591446c Kent Overstreet 2013-03-23 81 memcpy(sb->label, s->label, SB_LABEL_SIZE);
cafe563591446c Kent Overstreet 2013-03-23 82
cafe563591446c Kent Overstreet 2013-03-23 83 sb->flags = le64_to_cpu(s->flags);
cafe563591446c Kent Overstreet 2013-03-23 84 sb->seq = le64_to_cpu(s->seq);
cafe563591446c Kent Overstreet 2013-03-23 85 sb->last_mount = le32_to_cpu(s->last_mount);
cafe563591446c Kent Overstreet 2013-03-23 86 sb->first_bucket = le16_to_cpu(s->first_bucket);
cafe563591446c Kent Overstreet 2013-03-23 87 sb->keys = le16_to_cpu(s->keys);
cafe563591446c Kent Overstreet 2013-03-23 88
cafe563591446c Kent Overstreet 2013-03-23 89 for (i = 0; i < SB_JOURNAL_BUCKETS; i++)
cafe563591446c Kent Overstreet 2013-03-23 90 sb->d[i] = le64_to_cpu(s->d[i]);
cafe563591446c Kent Overstreet 2013-03-23 91
cafe563591446c Kent Overstreet 2013-03-23 92 pr_debug("read sb version %llu, flags %llu, seq %llu, journal size %u",
cafe563591446c Kent Overstreet 2013-03-23 93 sb->version, sb->flags, sb->seq, sb->keys);
cafe563591446c Kent Overstreet 2013-03-23 94
aaf8dbeab58657 Coly Li 2019-11-13 95 err = "Not a bcache superblock (bad offset)";
cafe563591446c Kent Overstreet 2013-03-23 96 if (sb->offset != SB_SECTOR)
cafe563591446c Kent Overstreet 2013-03-23 97 goto err;
cafe563591446c Kent Overstreet 2013-03-23 98
aaf8dbeab58657 Coly Li 2019-11-13 99 err = "Not a bcache superblock (bad magic)";
cafe563591446c Kent Overstreet 2013-03-23 100 if (memcmp(sb->magic, bcache_magic, 16))
cafe563591446c Kent Overstreet 2013-03-23 101 goto err;
cafe563591446c Kent Overstreet 2013-03-23 102
cafe563591446c Kent Overstreet 2013-03-23 103 err = "Too many journal buckets";
cafe563591446c Kent Overstreet 2013-03-23 104 if (sb->keys > SB_JOURNAL_BUCKETS)
cafe563591446c Kent Overstreet 2013-03-23 105 goto err;
cafe563591446c Kent Overstreet 2013-03-23 106
cafe563591446c Kent Overstreet 2013-03-23 107 err = "Bad checksum";
cafe563591446c Kent Overstreet 2013-03-23 @108 if (s->csum != csum_set(s))
cafe563591446c Kent Overstreet 2013-03-23 109 goto err;
cafe563591446c Kent Overstreet 2013-03-23 110
cafe563591446c Kent Overstreet 2013-03-23 111 err = "Bad UUID";
169ef1cf6171d3 Kent Overstreet 2013-03-28 112 if (bch_is_zero(sb->uuid, 16))
cafe563591446c Kent Overstreet 2013-03-23 113 goto err;
cafe563591446c Kent Overstreet 2013-03-23 114
8abb2a5dbadab9 Kent Overstreet 2013-04-23 115 sb->block_size = le16_to_cpu(s->block_size);
8abb2a5dbadab9 Kent Overstreet 2013-04-23 116
8abb2a5dbadab9 Kent Overstreet 2013-04-23 117 err = "Superblock block size smaller than device block size";
8abb2a5dbadab9 Kent Overstreet 2013-04-23 118 if (sb->block_size << 9 < bdev_logical_block_size(bdev))
8abb2a5dbadab9 Kent Overstreet 2013-04-23 119 goto err;
8abb2a5dbadab9 Kent Overstreet 2013-04-23 120
2903381fce7100 Kent Overstreet 2013-04-11 121 switch (sb->version) {
2903381fce7100 Kent Overstreet 2013-04-11 122 case BCACHE_SB_VERSION_BDEV:
2903381fce7100 Kent Overstreet 2013-04-11 123 sb->data_offset = BDEV_DATA_START_DEFAULT;
2903381fce7100 Kent Overstreet 2013-04-11 124 break;
2903381fce7100 Kent Overstreet 2013-04-11 125 case BCACHE_SB_VERSION_BDEV_WITH_OFFSET:
2903381fce7100 Kent Overstreet 2013-04-11 126 sb->data_offset = le64_to_cpu(s->data_offset);
cafe563591446c Kent Overstreet 2013-03-23 127
2903381fce7100 Kent Overstreet 2013-04-11 128 err = "Bad data offset";
2903381fce7100 Kent Overstreet 2013-04-11 129 if (sb->data_offset < BDEV_DATA_START_DEFAULT)
cafe563591446c Kent Overstreet 2013-03-23 130 goto err;
cafe563591446c Kent Overstreet 2013-03-23 131
2903381fce7100 Kent Overstreet 2013-04-11 132 break;
2903381fce7100 Kent Overstreet 2013-04-11 133 case BCACHE_SB_VERSION_CDEV:
2903381fce7100 Kent Overstreet 2013-04-11 134 case BCACHE_SB_VERSION_CDEV_WITH_UUID:
2903381fce7100 Kent Overstreet 2013-04-11 135 sb->nbuckets = le64_to_cpu(s->nbuckets);
2903381fce7100 Kent Overstreet 2013-04-11 136 sb->bucket_size = le16_to_cpu(s->bucket_size);
2903381fce7100 Kent Overstreet 2013-04-11 137
2903381fce7100 Kent Overstreet 2013-04-11 138 sb->nr_in_set = le16_to_cpu(s->nr_in_set);
2903381fce7100 Kent Overstreet 2013-04-11 139 sb->nr_this_dev = le16_to_cpu(s->nr_this_dev);
2903381fce7100 Kent Overstreet 2013-04-11 140
cafe563591446c Kent Overstreet 2013-03-23 141 err = "Too many buckets";
cafe563591446c Kent Overstreet 2013-03-23 142 if (sb->nbuckets > LONG_MAX)
cafe563591446c Kent Overstreet 2013-03-23 143 goto err;
cafe563591446c Kent Overstreet 2013-03-23 144
cafe563591446c Kent Overstreet 2013-03-23 145 err = "Not enough buckets";
cafe563591446c Kent Overstreet 2013-03-23 146 if (sb->nbuckets < 1 << 7)
cafe563591446c Kent Overstreet 2013-03-23 147 goto err;
cafe563591446c Kent Overstreet 2013-03-23 148
2903381fce7100 Kent Overstreet 2013-04-11 149 err = "Bad block/bucket size";
2903381fce7100 Kent Overstreet 2013-04-11 150 if (!is_power_of_2(sb->block_size) ||
2903381fce7100 Kent Overstreet 2013-04-11 151 sb->block_size > PAGE_SECTORS ||
2903381fce7100 Kent Overstreet 2013-04-11 152 !is_power_of_2(sb->bucket_size) ||
2903381fce7100 Kent Overstreet 2013-04-11 153 sb->bucket_size < PAGE_SECTORS)
2903381fce7100 Kent Overstreet 2013-04-11 154 goto err;
2903381fce7100 Kent Overstreet 2013-04-11 155
cafe563591446c Kent Overstreet 2013-03-23 156 err = "Invalid superblock: device too small";
b0d30981c05f32 Coly Li 2018-08-11 157 if (get_capacity(bdev->bd_disk) <
b0d30981c05f32 Coly Li 2018-08-11 158 sb->bucket_size * sb->nbuckets)
cafe563591446c Kent Overstreet 2013-03-23 159 goto err;
cafe563591446c Kent Overstreet 2013-03-23 160
cafe563591446c Kent Overstreet 2013-03-23 161 err = "Bad UUID";
169ef1cf6171d3 Kent Overstreet 2013-03-28 162 if (bch_is_zero(sb->set_uuid, 16))
cafe563591446c Kent Overstreet 2013-03-23 163 goto err;
cafe563591446c Kent Overstreet 2013-03-23 164
cafe563591446c Kent Overstreet 2013-03-23 165 err = "Bad cache device number in set";
cafe563591446c Kent Overstreet 2013-03-23 166 if (!sb->nr_in_set ||
cafe563591446c Kent Overstreet 2013-03-23 167 sb->nr_in_set <= sb->nr_this_dev ||
cafe563591446c Kent Overstreet 2013-03-23 168 sb->nr_in_set > MAX_CACHES_PER_SET)
cafe563591446c Kent Overstreet 2013-03-23 169 goto err;
cafe563591446c Kent Overstreet 2013-03-23 170
cafe563591446c Kent Overstreet 2013-03-23 171 err = "Journal buckets not sequential";
cafe563591446c Kent Overstreet 2013-03-23 172 for (i = 0; i < sb->keys; i++)
cafe563591446c Kent Overstreet 2013-03-23 173 if (sb->d[i] != sb->first_bucket + i)
cafe563591446c Kent Overstreet 2013-03-23 174 goto err;
cafe563591446c Kent Overstreet 2013-03-23 175
cafe563591446c Kent Overstreet 2013-03-23 176 err = "Too many journal buckets";
cafe563591446c Kent Overstreet 2013-03-23 177 if (sb->first_bucket + sb->keys > sb->nbuckets)
cafe563591446c Kent Overstreet 2013-03-23 178 goto err;
cafe563591446c Kent Overstreet 2013-03-23 179
cafe563591446c Kent Overstreet 2013-03-23 180 err = "Invalid superblock: first bucket comes before end of super";
cafe563591446c Kent Overstreet 2013-03-23 181 if (sb->first_bucket * sb->bucket_size < 16)
cafe563591446c Kent Overstreet 2013-03-23 182 goto err;
2903381fce7100 Kent Overstreet 2013-04-11 183
2903381fce7100 Kent Overstreet 2013-04-11 184 break;
2903381fce7100 Kent Overstreet 2013-04-11 185 default:
2903381fce7100 Kent Overstreet 2013-04-11 186 err = "Unsupported superblock version";
2903381fce7100 Kent Overstreet 2013-04-11 187 goto err;
2903381fce7100 Kent Overstreet 2013-04-11 188 }
2903381fce7100 Kent Overstreet 2013-04-11 189
75cbb3f1d84042 Arnd Bergmann 2018-07-26 190 sb->last_mount = (u32)ktime_get_real_seconds();
cafe563591446c Kent Overstreet 2013-03-23 191 err = NULL;
cafe563591446c Kent Overstreet 2013-03-23 192
cafe563591446c Kent Overstreet 2013-03-23 193 get_page(bh->b_page);
cafe563591446c Kent Overstreet 2013-03-23 194 *res = bh->b_page;
cafe563591446c Kent Overstreet 2013-03-23 195 err:
cafe563591446c Kent Overstreet 2013-03-23 196 put_bh(bh);
cafe563591446c Kent Overstreet 2013-03-23 197 return err;
cafe563591446c Kent Overstreet 2013-03-23 198 }
cafe563591446c Kent Overstreet 2013-03-23 199
4246a0b63bd8f5 Christoph Hellwig 2015-07-20 200 static void write_bdev_super_endio(struct bio *bio)
cafe563591446c Kent Overstreet 2013-03-23 201 {
cafe563591446c Kent Overstreet 2013-03-23 202 struct cached_dev *dc = bio->bi_private;
08ec1e6282f271 Coly Li 2019-06-28 203
08ec1e6282f271 Coly Li 2019-06-28 204 if (bio->bi_status)
08ec1e6282f271 Coly Li 2019-06-28 205 bch_count_backing_io_errors(dc, bio);
cafe563591446c Kent Overstreet 2013-03-23 206
cb7a583e6a6ace Kent Overstreet 2013-12-16 207 closure_put(&dc->sb_write);
cafe563591446c Kent Overstreet 2013-03-23 208 }
cafe563591446c Kent Overstreet 2013-03-23 209
cafe563591446c Kent Overstreet 2013-03-23 210 static void __write_super(struct cache_sb *sb, struct bio *bio)
cafe563591446c Kent Overstreet 2013-03-23 211 {
a702a692cd7559 Christoph Hellwig 2020-01-24 212 struct cache_sb_disk *out = page_address(bio_first_page_all(bio));
6f10f7d1b02b1b Coly Li 2018-08-11 213 unsigned int i;
cafe563591446c Kent Overstreet 2013-03-23 214
4f024f3797c43c Kent Overstreet 2013-10-11 215 bio->bi_iter.bi_sector = SB_SECTOR;
4f024f3797c43c Kent Overstreet 2013-10-11 216 bio->bi_iter.bi_size = SB_SIZE;
ad0d9e76a41247 Mike Christie 2016-06-05 217 bio_set_op_attrs(bio, REQ_OP_WRITE, REQ_SYNC|REQ_META);
169ef1cf6171d3 Kent Overstreet 2013-03-28 218 bch_bio_map(bio, NULL);
cafe563591446c Kent Overstreet 2013-03-23 219
cafe563591446c Kent Overstreet 2013-03-23 220 out->offset = cpu_to_le64(sb->offset);
cafe563591446c Kent Overstreet 2013-03-23 221 out->version = cpu_to_le64(sb->version);
cafe563591446c Kent Overstreet 2013-03-23 222
cafe563591446c Kent Overstreet 2013-03-23 223 memcpy(out->uuid, sb->uuid, 16);
cafe563591446c Kent Overstreet 2013-03-23 224 memcpy(out->set_uuid, sb->set_uuid, 16);
cafe563591446c Kent Overstreet 2013-03-23 225 memcpy(out->label, sb->label, SB_LABEL_SIZE);
cafe563591446c Kent Overstreet 2013-03-23 226
cafe563591446c Kent Overstreet 2013-03-23 227 out->flags = cpu_to_le64(sb->flags);
cafe563591446c Kent Overstreet 2013-03-23 228 out->seq = cpu_to_le64(sb->seq);
cafe563591446c Kent Overstreet 2013-03-23 229
cafe563591446c Kent Overstreet 2013-03-23 230 out->last_mount = cpu_to_le32(sb->last_mount);
cafe563591446c Kent Overstreet 2013-03-23 231 out->first_bucket = cpu_to_le16(sb->first_bucket);
cafe563591446c Kent Overstreet 2013-03-23 232 out->keys = cpu_to_le16(sb->keys);
cafe563591446c Kent Overstreet 2013-03-23 233
cafe563591446c Kent Overstreet 2013-03-23 234 for (i = 0; i < sb->keys; i++)
cafe563591446c Kent Overstreet 2013-03-23 235 out->d[i] = cpu_to_le64(sb->d[i]);
cafe563591446c Kent Overstreet 2013-03-23 236
cafe563591446c Kent Overstreet 2013-03-23 @237 out->csum = csum_set(out);
cafe563591446c Kent Overstreet 2013-03-23 238
cafe563591446c Kent Overstreet 2013-03-23 239 pr_debug("ver %llu, flags %llu, seq %llu",
cafe563591446c Kent Overstreet 2013-03-23 240 sb->version, sb->flags, sb->seq);
cafe563591446c Kent Overstreet 2013-03-23 241
4e49ea4a3d2763 Mike Christie 2016-06-05 242 submit_bio(bio);
cafe563591446c Kent Overstreet 2013-03-23 243 }
cafe563591446c Kent Overstreet 2013-03-23 244
:::::: The code at line 108 was first introduced by commit
:::::: cafe563591446cf80bfbc2fe3bc72a2e36cf1060 bcache: A block layer cache
:::::: TO: Kent Overstreet <koverstreet@google.com>
:::::: CC: Kent Overstreet <koverstreet@google.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
@ 2024-12-06 1:15 kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2024-12-06 1:15 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: oe-kbuild-all, linux-kernel, Jens Axboe, Coly Li
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 896d8946da97332d4dc80fa1937d8dd6b1c35ad4
commit: a702a692cd7559053ea573f4e2c84828f0e62824 bcache: use a separate data structure for the on-disk super block
date: 4 years, 10 months ago
config: x86_64-randconfig-r133-20240105 (https://download.01.org/0day-ci/archive/20241206/202412060920.ozdqp15O-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241206/202412060920.ozdqp15O-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412060920.ozdqp15O-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/md/bcache/super.c:108:24: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
drivers/md/bcache/super.c:108:24: sparse: expected unsigned int nr_keys
drivers/md/bcache/super.c:108:24: sparse: got restricted __le16 [usertype] keys
>> drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
drivers/md/bcache/super.c:237:21: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
drivers/md/bcache/super.c:237:21: sparse: expected unsigned int nr_keys
drivers/md/bcache/super.c:237:21: sparse: got restricted __le16 [usertype] keys
>> drivers/md/bcache/super.c:237:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le64 [usertype] csum @@ got unsigned long long @@
drivers/md/bcache/super.c:237:19: sparse: expected restricted __le64 [usertype] csum
drivers/md/bcache/super.c:237:19: sparse: got unsigned long long
drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
include/uapi/linux/bcache.h:345:38: sparse: sparse: array of flexible structures
drivers/md/bcache/super.c:574:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] prio @@ got restricted __le16 [usertype] @@
drivers/md/bcache/super.c:574:33: sparse: expected unsigned short [usertype] prio
drivers/md/bcache/super.c:574:33: sparse: got restricted __le16 [usertype]
drivers/md/bcache/super.c:642:27: sparse: sparse: cast to restricted __le16
drivers/md/bcache/super.c:744:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:744:32: sparse: expected unsigned int [usertype] invalidated
drivers/md/bcache/super.c:744:32: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1104:26: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] rtime @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1104:26: sparse: expected unsigned int [usertype] rtime
drivers/md/bcache/super.c:1104:26: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1148:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1148:32: sparse: expected unsigned int [usertype] invalidated
drivers/md/bcache/super.c:1148:32: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1502:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] last_reg @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1502:36: sparse: expected unsigned int [usertype] last_reg
drivers/md/bcache/super.c:1502:36: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
drivers/md/bcache/bset.h:231:36: sparse: sparse: array of flexible structures
vim +108 drivers/md/bcache/super.c
cafe563591446cf Kent Overstreet 2013-03-23 61
cafe563591446cf Kent Overstreet 2013-03-23 62 static const char *read_super(struct cache_sb *sb, struct block_device *bdev,
cafe563591446cf Kent Overstreet 2013-03-23 63 struct page **res)
cafe563591446cf Kent Overstreet 2013-03-23 64 {
cafe563591446cf Kent Overstreet 2013-03-23 65 const char *err;
a702a692cd75590 Christoph Hellwig 2020-01-24 66 struct cache_sb_disk *s;
cafe563591446cf Kent Overstreet 2013-03-23 67 struct buffer_head *bh = __bread(bdev, 1, SB_SIZE);
6f10f7d1b02b1bb Coly Li 2018-08-11 68 unsigned int i;
cafe563591446cf Kent Overstreet 2013-03-23 69
cafe563591446cf Kent Overstreet 2013-03-23 70 if (!bh)
cafe563591446cf Kent Overstreet 2013-03-23 71 return "IO error";
cafe563591446cf Kent Overstreet 2013-03-23 72
a702a692cd75590 Christoph Hellwig 2020-01-24 73 s = (struct cache_sb_disk *)bh->b_data;
cafe563591446cf Kent Overstreet 2013-03-23 74
cafe563591446cf Kent Overstreet 2013-03-23 75 sb->offset = le64_to_cpu(s->offset);
cafe563591446cf Kent Overstreet 2013-03-23 76 sb->version = le64_to_cpu(s->version);
cafe563591446cf Kent Overstreet 2013-03-23 77
cafe563591446cf Kent Overstreet 2013-03-23 78 memcpy(sb->magic, s->magic, 16);
cafe563591446cf Kent Overstreet 2013-03-23 79 memcpy(sb->uuid, s->uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 80 memcpy(sb->set_uuid, s->set_uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 81 memcpy(sb->label, s->label, SB_LABEL_SIZE);
cafe563591446cf Kent Overstreet 2013-03-23 82
cafe563591446cf Kent Overstreet 2013-03-23 83 sb->flags = le64_to_cpu(s->flags);
cafe563591446cf Kent Overstreet 2013-03-23 84 sb->seq = le64_to_cpu(s->seq);
cafe563591446cf Kent Overstreet 2013-03-23 85 sb->last_mount = le32_to_cpu(s->last_mount);
cafe563591446cf Kent Overstreet 2013-03-23 86 sb->first_bucket = le16_to_cpu(s->first_bucket);
cafe563591446cf Kent Overstreet 2013-03-23 87 sb->keys = le16_to_cpu(s->keys);
cafe563591446cf Kent Overstreet 2013-03-23 88
cafe563591446cf Kent Overstreet 2013-03-23 89 for (i = 0; i < SB_JOURNAL_BUCKETS; i++)
cafe563591446cf Kent Overstreet 2013-03-23 90 sb->d[i] = le64_to_cpu(s->d[i]);
cafe563591446cf Kent Overstreet 2013-03-23 91
cafe563591446cf Kent Overstreet 2013-03-23 92 pr_debug("read sb version %llu, flags %llu, seq %llu, journal size %u",
cafe563591446cf Kent Overstreet 2013-03-23 93 sb->version, sb->flags, sb->seq, sb->keys);
cafe563591446cf Kent Overstreet 2013-03-23 94
aaf8dbeab586572 Coly Li 2019-11-13 95 err = "Not a bcache superblock (bad offset)";
cafe563591446cf Kent Overstreet 2013-03-23 96 if (sb->offset != SB_SECTOR)
cafe563591446cf Kent Overstreet 2013-03-23 97 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 98
aaf8dbeab586572 Coly Li 2019-11-13 99 err = "Not a bcache superblock (bad magic)";
cafe563591446cf Kent Overstreet 2013-03-23 100 if (memcmp(sb->magic, bcache_magic, 16))
cafe563591446cf Kent Overstreet 2013-03-23 101 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 102
cafe563591446cf Kent Overstreet 2013-03-23 103 err = "Too many journal buckets";
cafe563591446cf Kent Overstreet 2013-03-23 104 if (sb->keys > SB_JOURNAL_BUCKETS)
cafe563591446cf Kent Overstreet 2013-03-23 105 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 106
cafe563591446cf Kent Overstreet 2013-03-23 107 err = "Bad checksum";
cafe563591446cf Kent Overstreet 2013-03-23 @108 if (s->csum != csum_set(s))
cafe563591446cf Kent Overstreet 2013-03-23 109 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 110
cafe563591446cf Kent Overstreet 2013-03-23 111 err = "Bad UUID";
169ef1cf6171d35 Kent Overstreet 2013-03-28 112 if (bch_is_zero(sb->uuid, 16))
cafe563591446cf Kent Overstreet 2013-03-23 113 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 114
8abb2a5dbadab91 Kent Overstreet 2013-04-23 115 sb->block_size = le16_to_cpu(s->block_size);
8abb2a5dbadab91 Kent Overstreet 2013-04-23 116
8abb2a5dbadab91 Kent Overstreet 2013-04-23 117 err = "Superblock block size smaller than device block size";
8abb2a5dbadab91 Kent Overstreet 2013-04-23 118 if (sb->block_size << 9 < bdev_logical_block_size(bdev))
8abb2a5dbadab91 Kent Overstreet 2013-04-23 119 goto err;
8abb2a5dbadab91 Kent Overstreet 2013-04-23 120
2903381fce71004 Kent Overstreet 2013-04-11 121 switch (sb->version) {
2903381fce71004 Kent Overstreet 2013-04-11 122 case BCACHE_SB_VERSION_BDEV:
2903381fce71004 Kent Overstreet 2013-04-11 123 sb->data_offset = BDEV_DATA_START_DEFAULT;
2903381fce71004 Kent Overstreet 2013-04-11 124 break;
2903381fce71004 Kent Overstreet 2013-04-11 125 case BCACHE_SB_VERSION_BDEV_WITH_OFFSET:
2903381fce71004 Kent Overstreet 2013-04-11 126 sb->data_offset = le64_to_cpu(s->data_offset);
cafe563591446cf Kent Overstreet 2013-03-23 127
2903381fce71004 Kent Overstreet 2013-04-11 128 err = "Bad data offset";
2903381fce71004 Kent Overstreet 2013-04-11 129 if (sb->data_offset < BDEV_DATA_START_DEFAULT)
cafe563591446cf Kent Overstreet 2013-03-23 130 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 131
2903381fce71004 Kent Overstreet 2013-04-11 132 break;
2903381fce71004 Kent Overstreet 2013-04-11 133 case BCACHE_SB_VERSION_CDEV:
2903381fce71004 Kent Overstreet 2013-04-11 134 case BCACHE_SB_VERSION_CDEV_WITH_UUID:
2903381fce71004 Kent Overstreet 2013-04-11 135 sb->nbuckets = le64_to_cpu(s->nbuckets);
2903381fce71004 Kent Overstreet 2013-04-11 136 sb->bucket_size = le16_to_cpu(s->bucket_size);
2903381fce71004 Kent Overstreet 2013-04-11 137
2903381fce71004 Kent Overstreet 2013-04-11 138 sb->nr_in_set = le16_to_cpu(s->nr_in_set);
2903381fce71004 Kent Overstreet 2013-04-11 139 sb->nr_this_dev = le16_to_cpu(s->nr_this_dev);
2903381fce71004 Kent Overstreet 2013-04-11 140
cafe563591446cf Kent Overstreet 2013-03-23 141 err = "Too many buckets";
cafe563591446cf Kent Overstreet 2013-03-23 142 if (sb->nbuckets > LONG_MAX)
cafe563591446cf Kent Overstreet 2013-03-23 143 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 144
cafe563591446cf Kent Overstreet 2013-03-23 145 err = "Not enough buckets";
cafe563591446cf Kent Overstreet 2013-03-23 146 if (sb->nbuckets < 1 << 7)
cafe563591446cf Kent Overstreet 2013-03-23 147 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 148
2903381fce71004 Kent Overstreet 2013-04-11 149 err = "Bad block/bucket size";
2903381fce71004 Kent Overstreet 2013-04-11 150 if (!is_power_of_2(sb->block_size) ||
2903381fce71004 Kent Overstreet 2013-04-11 151 sb->block_size > PAGE_SECTORS ||
2903381fce71004 Kent Overstreet 2013-04-11 152 !is_power_of_2(sb->bucket_size) ||
2903381fce71004 Kent Overstreet 2013-04-11 153 sb->bucket_size < PAGE_SECTORS)
2903381fce71004 Kent Overstreet 2013-04-11 154 goto err;
2903381fce71004 Kent Overstreet 2013-04-11 155
cafe563591446cf Kent Overstreet 2013-03-23 156 err = "Invalid superblock: device too small";
b0d30981c05f32d Coly Li 2018-08-11 157 if (get_capacity(bdev->bd_disk) <
b0d30981c05f32d Coly Li 2018-08-11 158 sb->bucket_size * sb->nbuckets)
cafe563591446cf Kent Overstreet 2013-03-23 159 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 160
cafe563591446cf Kent Overstreet 2013-03-23 161 err = "Bad UUID";
169ef1cf6171d35 Kent Overstreet 2013-03-28 162 if (bch_is_zero(sb->set_uuid, 16))
cafe563591446cf Kent Overstreet 2013-03-23 163 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 164
cafe563591446cf Kent Overstreet 2013-03-23 165 err = "Bad cache device number in set";
cafe563591446cf Kent Overstreet 2013-03-23 166 if (!sb->nr_in_set ||
cafe563591446cf Kent Overstreet 2013-03-23 167 sb->nr_in_set <= sb->nr_this_dev ||
cafe563591446cf Kent Overstreet 2013-03-23 168 sb->nr_in_set > MAX_CACHES_PER_SET)
cafe563591446cf Kent Overstreet 2013-03-23 169 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 170
cafe563591446cf Kent Overstreet 2013-03-23 171 err = "Journal buckets not sequential";
cafe563591446cf Kent Overstreet 2013-03-23 172 for (i = 0; i < sb->keys; i++)
cafe563591446cf Kent Overstreet 2013-03-23 173 if (sb->d[i] != sb->first_bucket + i)
cafe563591446cf Kent Overstreet 2013-03-23 174 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 175
cafe563591446cf Kent Overstreet 2013-03-23 176 err = "Too many journal buckets";
cafe563591446cf Kent Overstreet 2013-03-23 177 if (sb->first_bucket + sb->keys > sb->nbuckets)
cafe563591446cf Kent Overstreet 2013-03-23 178 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 179
cafe563591446cf Kent Overstreet 2013-03-23 180 err = "Invalid superblock: first bucket comes before end of super";
cafe563591446cf Kent Overstreet 2013-03-23 181 if (sb->first_bucket * sb->bucket_size < 16)
cafe563591446cf Kent Overstreet 2013-03-23 182 goto err;
2903381fce71004 Kent Overstreet 2013-04-11 183
2903381fce71004 Kent Overstreet 2013-04-11 184 break;
2903381fce71004 Kent Overstreet 2013-04-11 185 default:
2903381fce71004 Kent Overstreet 2013-04-11 186 err = "Unsupported superblock version";
2903381fce71004 Kent Overstreet 2013-04-11 187 goto err;
2903381fce71004 Kent Overstreet 2013-04-11 188 }
2903381fce71004 Kent Overstreet 2013-04-11 189
75cbb3f1d840429 Arnd Bergmann 2018-07-26 190 sb->last_mount = (u32)ktime_get_real_seconds();
cafe563591446cf Kent Overstreet 2013-03-23 191 err = NULL;
cafe563591446cf Kent Overstreet 2013-03-23 192
cafe563591446cf Kent Overstreet 2013-03-23 193 get_page(bh->b_page);
cafe563591446cf Kent Overstreet 2013-03-23 194 *res = bh->b_page;
cafe563591446cf Kent Overstreet 2013-03-23 195 err:
cafe563591446cf Kent Overstreet 2013-03-23 196 put_bh(bh);
cafe563591446cf Kent Overstreet 2013-03-23 197 return err;
cafe563591446cf Kent Overstreet 2013-03-23 198 }
cafe563591446cf Kent Overstreet 2013-03-23 199
4246a0b63bd8f56 Christoph Hellwig 2015-07-20 200 static void write_bdev_super_endio(struct bio *bio)
cafe563591446cf Kent Overstreet 2013-03-23 201 {
cafe563591446cf Kent Overstreet 2013-03-23 202 struct cached_dev *dc = bio->bi_private;
08ec1e6282f2716 Coly Li 2019-06-28 203
08ec1e6282f2716 Coly Li 2019-06-28 204 if (bio->bi_status)
08ec1e6282f2716 Coly Li 2019-06-28 205 bch_count_backing_io_errors(dc, bio);
cafe563591446cf Kent Overstreet 2013-03-23 206
cb7a583e6a6ace6 Kent Overstreet 2013-12-16 207 closure_put(&dc->sb_write);
cafe563591446cf Kent Overstreet 2013-03-23 208 }
cafe563591446cf Kent Overstreet 2013-03-23 209
cafe563591446cf Kent Overstreet 2013-03-23 210 static void __write_super(struct cache_sb *sb, struct bio *bio)
cafe563591446cf Kent Overstreet 2013-03-23 211 {
a702a692cd75590 Christoph Hellwig 2020-01-24 212 struct cache_sb_disk *out = page_address(bio_first_page_all(bio));
6f10f7d1b02b1bb Coly Li 2018-08-11 213 unsigned int i;
cafe563591446cf Kent Overstreet 2013-03-23 214
4f024f3797c43cb Kent Overstreet 2013-10-11 215 bio->bi_iter.bi_sector = SB_SECTOR;
4f024f3797c43cb Kent Overstreet 2013-10-11 216 bio->bi_iter.bi_size = SB_SIZE;
ad0d9e76a412470 Mike Christie 2016-06-05 217 bio_set_op_attrs(bio, REQ_OP_WRITE, REQ_SYNC|REQ_META);
169ef1cf6171d35 Kent Overstreet 2013-03-28 218 bch_bio_map(bio, NULL);
cafe563591446cf Kent Overstreet 2013-03-23 219
cafe563591446cf Kent Overstreet 2013-03-23 220 out->offset = cpu_to_le64(sb->offset);
cafe563591446cf Kent Overstreet 2013-03-23 221 out->version = cpu_to_le64(sb->version);
cafe563591446cf Kent Overstreet 2013-03-23 222
cafe563591446cf Kent Overstreet 2013-03-23 223 memcpy(out->uuid, sb->uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 224 memcpy(out->set_uuid, sb->set_uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 225 memcpy(out->label, sb->label, SB_LABEL_SIZE);
cafe563591446cf Kent Overstreet 2013-03-23 226
cafe563591446cf Kent Overstreet 2013-03-23 227 out->flags = cpu_to_le64(sb->flags);
cafe563591446cf Kent Overstreet 2013-03-23 228 out->seq = cpu_to_le64(sb->seq);
cafe563591446cf Kent Overstreet 2013-03-23 229
cafe563591446cf Kent Overstreet 2013-03-23 230 out->last_mount = cpu_to_le32(sb->last_mount);
cafe563591446cf Kent Overstreet 2013-03-23 231 out->first_bucket = cpu_to_le16(sb->first_bucket);
cafe563591446cf Kent Overstreet 2013-03-23 232 out->keys = cpu_to_le16(sb->keys);
cafe563591446cf Kent Overstreet 2013-03-23 233
cafe563591446cf Kent Overstreet 2013-03-23 234 for (i = 0; i < sb->keys; i++)
cafe563591446cf Kent Overstreet 2013-03-23 235 out->d[i] = cpu_to_le64(sb->d[i]);
cafe563591446cf Kent Overstreet 2013-03-23 236
cafe563591446cf Kent Overstreet 2013-03-23 @237 out->csum = csum_set(out);
cafe563591446cf Kent Overstreet 2013-03-23 238
cafe563591446cf Kent Overstreet 2013-03-23 239 pr_debug("ver %llu, flags %llu, seq %llu",
cafe563591446cf Kent Overstreet 2013-03-23 240 sb->version, sb->flags, sb->seq);
cafe563591446cf Kent Overstreet 2013-03-23 241
4e49ea4a3d27636 Mike Christie 2016-06-05 242 submit_bio(bio);
cafe563591446cf Kent Overstreet 2013-03-23 243 }
cafe563591446cf Kent Overstreet 2013-03-23 244
:::::: The code at line 108 was first introduced by commit
:::::: cafe563591446cf80bfbc2fe3bc72a2e36cf1060 bcache: A block layer cache
:::::: TO: Kent Overstreet <koverstreet@google.com>
:::::: CC: Kent Overstreet <koverstreet@google.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
@ 2024-12-09 4:00 kernel test robot
2024-12-10 16:34 ` Coly Li
0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2024-12-09 4:00 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: oe-kbuild-all, linux-kernel, Jens Axboe, Coly Li
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b5f217084ab3ddd4bdd03cd437f8e3b7e2d1f5b6
commit: a702a692cd7559053ea573f4e2c84828f0e62824 bcache: use a separate data structure for the on-disk super block
date: 4 years, 10 months ago
config: x86_64-randconfig-r133-20240105 (https://download.01.org/0day-ci/archive/20241207/202412071044.tthTVBw4-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241207/202412071044.tthTVBw4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412071044.tthTVBw4-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/md/bcache/super.c:108:24: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
drivers/md/bcache/super.c:108:24: sparse: expected unsigned int nr_keys
drivers/md/bcache/super.c:108:24: sparse: got restricted __le16 [usertype] keys
>> drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
drivers/md/bcache/super.c:237:21: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
drivers/md/bcache/super.c:237:21: sparse: expected unsigned int nr_keys
drivers/md/bcache/super.c:237:21: sparse: got restricted __le16 [usertype] keys
>> drivers/md/bcache/super.c:237:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le64 [usertype] csum @@ got unsigned long long @@
drivers/md/bcache/super.c:237:19: sparse: expected restricted __le64 [usertype] csum
drivers/md/bcache/super.c:237:19: sparse: got unsigned long long
drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
include/uapi/linux/bcache.h:345:38: sparse: sparse: array of flexible structures
drivers/md/bcache/super.c:574:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] prio @@ got restricted __le16 [usertype] @@
drivers/md/bcache/super.c:574:33: sparse: expected unsigned short [usertype] prio
drivers/md/bcache/super.c:574:33: sparse: got restricted __le16 [usertype]
drivers/md/bcache/super.c:642:27: sparse: sparse: cast to restricted __le16
drivers/md/bcache/super.c:744:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:744:32: sparse: expected unsigned int [usertype] invalidated
drivers/md/bcache/super.c:744:32: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1104:26: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] rtime @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1104:26: sparse: expected unsigned int [usertype] rtime
drivers/md/bcache/super.c:1104:26: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1148:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1148:32: sparse: expected unsigned int [usertype] invalidated
drivers/md/bcache/super.c:1148:32: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c:1502:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] last_reg @@ got restricted __le32 [usertype] @@
drivers/md/bcache/super.c:1502:36: sparse: expected unsigned int [usertype] last_reg
drivers/md/bcache/super.c:1502:36: sparse: got restricted __le32 [usertype]
drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
drivers/md/bcache/bset.h:231:36: sparse: sparse: array of flexible structures
vim +108 drivers/md/bcache/super.c
cafe563591446cf Kent Overstreet 2013-03-23 61
cafe563591446cf Kent Overstreet 2013-03-23 62 static const char *read_super(struct cache_sb *sb, struct block_device *bdev,
cafe563591446cf Kent Overstreet 2013-03-23 63 struct page **res)
cafe563591446cf Kent Overstreet 2013-03-23 64 {
cafe563591446cf Kent Overstreet 2013-03-23 65 const char *err;
a702a692cd75590 Christoph Hellwig 2020-01-24 66 struct cache_sb_disk *s;
cafe563591446cf Kent Overstreet 2013-03-23 67 struct buffer_head *bh = __bread(bdev, 1, SB_SIZE);
6f10f7d1b02b1bb Coly Li 2018-08-11 68 unsigned int i;
cafe563591446cf Kent Overstreet 2013-03-23 69
cafe563591446cf Kent Overstreet 2013-03-23 70 if (!bh)
cafe563591446cf Kent Overstreet 2013-03-23 71 return "IO error";
cafe563591446cf Kent Overstreet 2013-03-23 72
a702a692cd75590 Christoph Hellwig 2020-01-24 73 s = (struct cache_sb_disk *)bh->b_data;
cafe563591446cf Kent Overstreet 2013-03-23 74
cafe563591446cf Kent Overstreet 2013-03-23 75 sb->offset = le64_to_cpu(s->offset);
cafe563591446cf Kent Overstreet 2013-03-23 76 sb->version = le64_to_cpu(s->version);
cafe563591446cf Kent Overstreet 2013-03-23 77
cafe563591446cf Kent Overstreet 2013-03-23 78 memcpy(sb->magic, s->magic, 16);
cafe563591446cf Kent Overstreet 2013-03-23 79 memcpy(sb->uuid, s->uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 80 memcpy(sb->set_uuid, s->set_uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 81 memcpy(sb->label, s->label, SB_LABEL_SIZE);
cafe563591446cf Kent Overstreet 2013-03-23 82
cafe563591446cf Kent Overstreet 2013-03-23 83 sb->flags = le64_to_cpu(s->flags);
cafe563591446cf Kent Overstreet 2013-03-23 84 sb->seq = le64_to_cpu(s->seq);
cafe563591446cf Kent Overstreet 2013-03-23 85 sb->last_mount = le32_to_cpu(s->last_mount);
cafe563591446cf Kent Overstreet 2013-03-23 86 sb->first_bucket = le16_to_cpu(s->first_bucket);
cafe563591446cf Kent Overstreet 2013-03-23 87 sb->keys = le16_to_cpu(s->keys);
cafe563591446cf Kent Overstreet 2013-03-23 88
cafe563591446cf Kent Overstreet 2013-03-23 89 for (i = 0; i < SB_JOURNAL_BUCKETS; i++)
cafe563591446cf Kent Overstreet 2013-03-23 90 sb->d[i] = le64_to_cpu(s->d[i]);
cafe563591446cf Kent Overstreet 2013-03-23 91
cafe563591446cf Kent Overstreet 2013-03-23 92 pr_debug("read sb version %llu, flags %llu, seq %llu, journal size %u",
cafe563591446cf Kent Overstreet 2013-03-23 93 sb->version, sb->flags, sb->seq, sb->keys);
cafe563591446cf Kent Overstreet 2013-03-23 94
aaf8dbeab586572 Coly Li 2019-11-13 95 err = "Not a bcache superblock (bad offset)";
cafe563591446cf Kent Overstreet 2013-03-23 96 if (sb->offset != SB_SECTOR)
cafe563591446cf Kent Overstreet 2013-03-23 97 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 98
aaf8dbeab586572 Coly Li 2019-11-13 99 err = "Not a bcache superblock (bad magic)";
cafe563591446cf Kent Overstreet 2013-03-23 100 if (memcmp(sb->magic, bcache_magic, 16))
cafe563591446cf Kent Overstreet 2013-03-23 101 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 102
cafe563591446cf Kent Overstreet 2013-03-23 103 err = "Too many journal buckets";
cafe563591446cf Kent Overstreet 2013-03-23 104 if (sb->keys > SB_JOURNAL_BUCKETS)
cafe563591446cf Kent Overstreet 2013-03-23 105 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 106
cafe563591446cf Kent Overstreet 2013-03-23 107 err = "Bad checksum";
cafe563591446cf Kent Overstreet 2013-03-23 @108 if (s->csum != csum_set(s))
cafe563591446cf Kent Overstreet 2013-03-23 109 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 110
cafe563591446cf Kent Overstreet 2013-03-23 111 err = "Bad UUID";
169ef1cf6171d35 Kent Overstreet 2013-03-28 112 if (bch_is_zero(sb->uuid, 16))
cafe563591446cf Kent Overstreet 2013-03-23 113 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 114
8abb2a5dbadab91 Kent Overstreet 2013-04-23 115 sb->block_size = le16_to_cpu(s->block_size);
8abb2a5dbadab91 Kent Overstreet 2013-04-23 116
8abb2a5dbadab91 Kent Overstreet 2013-04-23 117 err = "Superblock block size smaller than device block size";
8abb2a5dbadab91 Kent Overstreet 2013-04-23 118 if (sb->block_size << 9 < bdev_logical_block_size(bdev))
8abb2a5dbadab91 Kent Overstreet 2013-04-23 119 goto err;
8abb2a5dbadab91 Kent Overstreet 2013-04-23 120
2903381fce71004 Kent Overstreet 2013-04-11 121 switch (sb->version) {
2903381fce71004 Kent Overstreet 2013-04-11 122 case BCACHE_SB_VERSION_BDEV:
2903381fce71004 Kent Overstreet 2013-04-11 123 sb->data_offset = BDEV_DATA_START_DEFAULT;
2903381fce71004 Kent Overstreet 2013-04-11 124 break;
2903381fce71004 Kent Overstreet 2013-04-11 125 case BCACHE_SB_VERSION_BDEV_WITH_OFFSET:
2903381fce71004 Kent Overstreet 2013-04-11 126 sb->data_offset = le64_to_cpu(s->data_offset);
cafe563591446cf Kent Overstreet 2013-03-23 127
2903381fce71004 Kent Overstreet 2013-04-11 128 err = "Bad data offset";
2903381fce71004 Kent Overstreet 2013-04-11 129 if (sb->data_offset < BDEV_DATA_START_DEFAULT)
cafe563591446cf Kent Overstreet 2013-03-23 130 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 131
2903381fce71004 Kent Overstreet 2013-04-11 132 break;
2903381fce71004 Kent Overstreet 2013-04-11 133 case BCACHE_SB_VERSION_CDEV:
2903381fce71004 Kent Overstreet 2013-04-11 134 case BCACHE_SB_VERSION_CDEV_WITH_UUID:
2903381fce71004 Kent Overstreet 2013-04-11 135 sb->nbuckets = le64_to_cpu(s->nbuckets);
2903381fce71004 Kent Overstreet 2013-04-11 136 sb->bucket_size = le16_to_cpu(s->bucket_size);
2903381fce71004 Kent Overstreet 2013-04-11 137
2903381fce71004 Kent Overstreet 2013-04-11 138 sb->nr_in_set = le16_to_cpu(s->nr_in_set);
2903381fce71004 Kent Overstreet 2013-04-11 139 sb->nr_this_dev = le16_to_cpu(s->nr_this_dev);
2903381fce71004 Kent Overstreet 2013-04-11 140
cafe563591446cf Kent Overstreet 2013-03-23 141 err = "Too many buckets";
cafe563591446cf Kent Overstreet 2013-03-23 142 if (sb->nbuckets > LONG_MAX)
cafe563591446cf Kent Overstreet 2013-03-23 143 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 144
cafe563591446cf Kent Overstreet 2013-03-23 145 err = "Not enough buckets";
cafe563591446cf Kent Overstreet 2013-03-23 146 if (sb->nbuckets < 1 << 7)
cafe563591446cf Kent Overstreet 2013-03-23 147 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 148
2903381fce71004 Kent Overstreet 2013-04-11 149 err = "Bad block/bucket size";
2903381fce71004 Kent Overstreet 2013-04-11 150 if (!is_power_of_2(sb->block_size) ||
2903381fce71004 Kent Overstreet 2013-04-11 151 sb->block_size > PAGE_SECTORS ||
2903381fce71004 Kent Overstreet 2013-04-11 152 !is_power_of_2(sb->bucket_size) ||
2903381fce71004 Kent Overstreet 2013-04-11 153 sb->bucket_size < PAGE_SECTORS)
2903381fce71004 Kent Overstreet 2013-04-11 154 goto err;
2903381fce71004 Kent Overstreet 2013-04-11 155
cafe563591446cf Kent Overstreet 2013-03-23 156 err = "Invalid superblock: device too small";
b0d30981c05f32d Coly Li 2018-08-11 157 if (get_capacity(bdev->bd_disk) <
b0d30981c05f32d Coly Li 2018-08-11 158 sb->bucket_size * sb->nbuckets)
cafe563591446cf Kent Overstreet 2013-03-23 159 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 160
cafe563591446cf Kent Overstreet 2013-03-23 161 err = "Bad UUID";
169ef1cf6171d35 Kent Overstreet 2013-03-28 162 if (bch_is_zero(sb->set_uuid, 16))
cafe563591446cf Kent Overstreet 2013-03-23 163 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 164
cafe563591446cf Kent Overstreet 2013-03-23 165 err = "Bad cache device number in set";
cafe563591446cf Kent Overstreet 2013-03-23 166 if (!sb->nr_in_set ||
cafe563591446cf Kent Overstreet 2013-03-23 167 sb->nr_in_set <= sb->nr_this_dev ||
cafe563591446cf Kent Overstreet 2013-03-23 168 sb->nr_in_set > MAX_CACHES_PER_SET)
cafe563591446cf Kent Overstreet 2013-03-23 169 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 170
cafe563591446cf Kent Overstreet 2013-03-23 171 err = "Journal buckets not sequential";
cafe563591446cf Kent Overstreet 2013-03-23 172 for (i = 0; i < sb->keys; i++)
cafe563591446cf Kent Overstreet 2013-03-23 173 if (sb->d[i] != sb->first_bucket + i)
cafe563591446cf Kent Overstreet 2013-03-23 174 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 175
cafe563591446cf Kent Overstreet 2013-03-23 176 err = "Too many journal buckets";
cafe563591446cf Kent Overstreet 2013-03-23 177 if (sb->first_bucket + sb->keys > sb->nbuckets)
cafe563591446cf Kent Overstreet 2013-03-23 178 goto err;
cafe563591446cf Kent Overstreet 2013-03-23 179
cafe563591446cf Kent Overstreet 2013-03-23 180 err = "Invalid superblock: first bucket comes before end of super";
cafe563591446cf Kent Overstreet 2013-03-23 181 if (sb->first_bucket * sb->bucket_size < 16)
cafe563591446cf Kent Overstreet 2013-03-23 182 goto err;
2903381fce71004 Kent Overstreet 2013-04-11 183
2903381fce71004 Kent Overstreet 2013-04-11 184 break;
2903381fce71004 Kent Overstreet 2013-04-11 185 default:
2903381fce71004 Kent Overstreet 2013-04-11 186 err = "Unsupported superblock version";
2903381fce71004 Kent Overstreet 2013-04-11 187 goto err;
2903381fce71004 Kent Overstreet 2013-04-11 188 }
2903381fce71004 Kent Overstreet 2013-04-11 189
75cbb3f1d840429 Arnd Bergmann 2018-07-26 190 sb->last_mount = (u32)ktime_get_real_seconds();
cafe563591446cf Kent Overstreet 2013-03-23 191 err = NULL;
cafe563591446cf Kent Overstreet 2013-03-23 192
cafe563591446cf Kent Overstreet 2013-03-23 193 get_page(bh->b_page);
cafe563591446cf Kent Overstreet 2013-03-23 194 *res = bh->b_page;
cafe563591446cf Kent Overstreet 2013-03-23 195 err:
cafe563591446cf Kent Overstreet 2013-03-23 196 put_bh(bh);
cafe563591446cf Kent Overstreet 2013-03-23 197 return err;
cafe563591446cf Kent Overstreet 2013-03-23 198 }
cafe563591446cf Kent Overstreet 2013-03-23 199
4246a0b63bd8f56 Christoph Hellwig 2015-07-20 200 static void write_bdev_super_endio(struct bio *bio)
cafe563591446cf Kent Overstreet 2013-03-23 201 {
cafe563591446cf Kent Overstreet 2013-03-23 202 struct cached_dev *dc = bio->bi_private;
08ec1e6282f2716 Coly Li 2019-06-28 203
08ec1e6282f2716 Coly Li 2019-06-28 204 if (bio->bi_status)
08ec1e6282f2716 Coly Li 2019-06-28 205 bch_count_backing_io_errors(dc, bio);
cafe563591446cf Kent Overstreet 2013-03-23 206
cb7a583e6a6ace6 Kent Overstreet 2013-12-16 207 closure_put(&dc->sb_write);
cafe563591446cf Kent Overstreet 2013-03-23 208 }
cafe563591446cf Kent Overstreet 2013-03-23 209
cafe563591446cf Kent Overstreet 2013-03-23 210 static void __write_super(struct cache_sb *sb, struct bio *bio)
cafe563591446cf Kent Overstreet 2013-03-23 211 {
a702a692cd75590 Christoph Hellwig 2020-01-24 212 struct cache_sb_disk *out = page_address(bio_first_page_all(bio));
6f10f7d1b02b1bb Coly Li 2018-08-11 213 unsigned int i;
cafe563591446cf Kent Overstreet 2013-03-23 214
4f024f3797c43cb Kent Overstreet 2013-10-11 215 bio->bi_iter.bi_sector = SB_SECTOR;
4f024f3797c43cb Kent Overstreet 2013-10-11 216 bio->bi_iter.bi_size = SB_SIZE;
ad0d9e76a412470 Mike Christie 2016-06-05 217 bio_set_op_attrs(bio, REQ_OP_WRITE, REQ_SYNC|REQ_META);
169ef1cf6171d35 Kent Overstreet 2013-03-28 218 bch_bio_map(bio, NULL);
cafe563591446cf Kent Overstreet 2013-03-23 219
cafe563591446cf Kent Overstreet 2013-03-23 220 out->offset = cpu_to_le64(sb->offset);
cafe563591446cf Kent Overstreet 2013-03-23 221 out->version = cpu_to_le64(sb->version);
cafe563591446cf Kent Overstreet 2013-03-23 222
cafe563591446cf Kent Overstreet 2013-03-23 223 memcpy(out->uuid, sb->uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 224 memcpy(out->set_uuid, sb->set_uuid, 16);
cafe563591446cf Kent Overstreet 2013-03-23 225 memcpy(out->label, sb->label, SB_LABEL_SIZE);
cafe563591446cf Kent Overstreet 2013-03-23 226
cafe563591446cf Kent Overstreet 2013-03-23 227 out->flags = cpu_to_le64(sb->flags);
cafe563591446cf Kent Overstreet 2013-03-23 228 out->seq = cpu_to_le64(sb->seq);
cafe563591446cf Kent Overstreet 2013-03-23 229
cafe563591446cf Kent Overstreet 2013-03-23 230 out->last_mount = cpu_to_le32(sb->last_mount);
cafe563591446cf Kent Overstreet 2013-03-23 231 out->first_bucket = cpu_to_le16(sb->first_bucket);
cafe563591446cf Kent Overstreet 2013-03-23 232 out->keys = cpu_to_le16(sb->keys);
cafe563591446cf Kent Overstreet 2013-03-23 233
cafe563591446cf Kent Overstreet 2013-03-23 234 for (i = 0; i < sb->keys; i++)
cafe563591446cf Kent Overstreet 2013-03-23 235 out->d[i] = cpu_to_le64(sb->d[i]);
cafe563591446cf Kent Overstreet 2013-03-23 236
cafe563591446cf Kent Overstreet 2013-03-23 @237 out->csum = csum_set(out);
cafe563591446cf Kent Overstreet 2013-03-23 238
cafe563591446cf Kent Overstreet 2013-03-23 239 pr_debug("ver %llu, flags %llu, seq %llu",
cafe563591446cf Kent Overstreet 2013-03-23 240 sb->version, sb->flags, sb->seq);
cafe563591446cf Kent Overstreet 2013-03-23 241
4e49ea4a3d27636 Mike Christie 2016-06-05 242 submit_bio(bio);
cafe563591446cf Kent Overstreet 2013-03-23 243 }
cafe563591446cf Kent Overstreet 2013-03-23 244
:::::: The code at line 108 was first introduced by commit
:::::: cafe563591446cf80bfbc2fe3bc72a2e36cf1060 bcache: A block layer cache
:::::: TO: Kent Overstreet <koverstreet@google.com>
:::::: CC: Kent Overstreet <koverstreet@google.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
2024-12-09 4:00 kernel test robot
@ 2024-12-10 16:34 ` Coly Li
2024-12-12 6:23 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Coly Li @ 2024-12-10 16:34 UTC (permalink / raw)
To: kernel test robot
Cc: Christoph Hellwig, oe-kbuild-all, linux-kernel, Jens Axboe
I don’t know whom to ask, just try to ask kernel test robot directly.
Although this patch was not composed from me, I still wonder who to understand the following warning information and where the problem is.
e.g. for the following warning,
> sparse warnings: (new ones prefixed by >>)
> drivers/md/bcache/super.c:108:24: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
> drivers/md/bcache/super.c:108:24: sparse: expected unsigned int nr_keys
> drivers/md/bcache/super.c:108:24: sparse: got restricted __le16 [usertype] keys
>>> drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
It complains about line 108 which is,
> cafe563591446cf Kent Overstreet 2013-03-23 107 err = "Bad checksum";
> cafe563591446cf Kent Overstreet 2013-03-23 @108 if (s->csum != csum_set(s))
> cafe563591446cf Kent Overstreet 2013-03-23 109 goto err;
Here s->sum is __le64, csum_set() is uint64_t, these two types have same length. I don’t see the direct connection between code and warning.
Thanks in advance for the patience to give me a hint.
Coly Li
> 2024年12月9日 12:00，kernel test robot <lkp@intel.com> 写道：
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: b5f217084ab3ddd4bdd03cd437f8e3b7e2d1f5b6
> commit: a702a692cd7559053ea573f4e2c84828f0e62824 bcache: use a separate data structure for the on-disk super block
> date: 4 years, 10 months ago
> config: x86_64-randconfig-r133-20240105 (https://download.01.org/0day-ci/archive/20241207/202412071044.tthTVBw4-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241207/202412071044.tthTVBw4-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412071044.tthTVBw4-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> drivers/md/bcache/super.c:108:24: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
> drivers/md/bcache/super.c:108:24: sparse: expected unsigned int nr_keys
> drivers/md/bcache/super.c:108:24: sparse: got restricted __le16 [usertype] keys
>>> drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
> drivers/md/bcache/super.c:237:21: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int nr_keys @@ got restricted __le16 [usertype] keys @@
> drivers/md/bcache/super.c:237:21: sparse: expected unsigned int nr_keys
> drivers/md/bcache/super.c:237:21: sparse: got restricted __le16 [usertype] keys
>>> drivers/md/bcache/super.c:237:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le64 [usertype] csum @@ got unsigned long long @@
> drivers/md/bcache/super.c:237:19: sparse: expected restricted __le64 [usertype] csum
> drivers/md/bcache/super.c:237:19: sparse: got unsigned long long
> drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
> include/uapi/linux/bcache.h:345:38: sparse: sparse: array of flexible structures
> drivers/md/bcache/super.c:574:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] prio @@ got restricted __le16 [usertype] @@
> drivers/md/bcache/super.c:574:33: sparse: expected unsigned short [usertype] prio
> drivers/md/bcache/super.c:574:33: sparse: got restricted __le16 [usertype]
> drivers/md/bcache/super.c:642:27: sparse: sparse: cast to restricted __le16
> drivers/md/bcache/super.c:744:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
> drivers/md/bcache/super.c:744:32: sparse: expected unsigned int [usertype] invalidated
> drivers/md/bcache/super.c:744:32: sparse: got restricted __le32 [usertype]
> drivers/md/bcache/super.c:1104:26: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] rtime @@ got restricted __le32 [usertype] @@
> drivers/md/bcache/super.c:1104:26: sparse: expected unsigned int [usertype] rtime
> drivers/md/bcache/super.c:1104:26: sparse: got restricted __le32 [usertype]
> drivers/md/bcache/super.c:1148:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] invalidated @@ got restricted __le32 [usertype] @@
> drivers/md/bcache/super.c:1148:32: sparse: expected unsigned int [usertype] invalidated
> drivers/md/bcache/super.c:1148:32: sparse: got restricted __le32 [usertype]
> drivers/md/bcache/super.c:1502:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] last_reg @@ got restricted __le32 [usertype] @@
> drivers/md/bcache/super.c:1502:36: sparse: expected unsigned int [usertype] last_reg
> drivers/md/bcache/super.c:1502:36: sparse: got restricted __le32 [usertype]
> drivers/md/bcache/super.c: note: in included file (through drivers/md/bcache/bcache.h):
> drivers/md/bcache/bset.h:231:36: sparse: sparse: array of flexible structures
>
> vim +108 drivers/md/bcache/super.c
>
> cafe563591446cf Kent Overstreet 2013-03-23 61
> cafe563591446cf Kent Overstreet 2013-03-23 62 static const char *read_super(struct cache_sb *sb, struct block_device *bdev,
> cafe563591446cf Kent Overstreet 2013-03-23 63 struct page **res)
> cafe563591446cf Kent Overstreet 2013-03-23 64 {
> cafe563591446cf Kent Overstreet 2013-03-23 65 const char *err;
> a702a692cd75590 Christoph Hellwig 2020-01-24 66 struct cache_sb_disk *s;
> cafe563591446cf Kent Overstreet 2013-03-23 67 struct buffer_head *bh = __bread(bdev, 1, SB_SIZE);
> 6f10f7d1b02b1bb Coly Li 2018-08-11 68 unsigned int i;
> cafe563591446cf Kent Overstreet 2013-03-23 69
> cafe563591446cf Kent Overstreet 2013-03-23 70 if (!bh)
> cafe563591446cf Kent Overstreet 2013-03-23 71 return "IO error";
> cafe563591446cf Kent Overstreet 2013-03-23 72
> a702a692cd75590 Christoph Hellwig 2020-01-24 73 s = (struct cache_sb_disk *)bh->b_data;
> cafe563591446cf Kent Overstreet 2013-03-23 74
> cafe563591446cf Kent Overstreet 2013-03-23 75 sb->offset = le64_to_cpu(s->offset);
> cafe563591446cf Kent Overstreet 2013-03-23 76 sb->version = le64_to_cpu(s->version);
> cafe563591446cf Kent Overstreet 2013-03-23 77
> cafe563591446cf Kent Overstreet 2013-03-23 78 memcpy(sb->magic, s->magic, 16);
> cafe563591446cf Kent Overstreet 2013-03-23 79 memcpy(sb->uuid, s->uuid, 16);
> cafe563591446cf Kent Overstreet 2013-03-23 80 memcpy(sb->set_uuid, s->set_uuid, 16);
> cafe563591446cf Kent Overstreet 2013-03-23 81 memcpy(sb->label, s->label, SB_LABEL_SIZE);
> cafe563591446cf Kent Overstreet 2013-03-23 82
> cafe563591446cf Kent Overstreet 2013-03-23 83 sb->flags = le64_to_cpu(s->flags);
> cafe563591446cf Kent Overstreet 2013-03-23 84 sb->seq = le64_to_cpu(s->seq);
> cafe563591446cf Kent Overstreet 2013-03-23 85 sb->last_mount = le32_to_cpu(s->last_mount);
> cafe563591446cf Kent Overstreet 2013-03-23 86 sb->first_bucket = le16_to_cpu(s->first_bucket);
> cafe563591446cf Kent Overstreet 2013-03-23 87 sb->keys = le16_to_cpu(s->keys);
> cafe563591446cf Kent Overstreet 2013-03-23 88
> cafe563591446cf Kent Overstreet 2013-03-23 89 for (i = 0; i < SB_JOURNAL_BUCKETS; i++)
> cafe563591446cf Kent Overstreet 2013-03-23 90 sb->d[i] = le64_to_cpu(s->d[i]);
> cafe563591446cf Kent Overstreet 2013-03-23 91
> cafe563591446cf Kent Overstreet 2013-03-23 92 pr_debug("read sb version %llu, flags %llu, seq %llu, journal size %u",
> cafe563591446cf Kent Overstreet 2013-03-23 93 sb->version, sb->flags, sb->seq, sb->keys);
> cafe563591446cf Kent Overstreet 2013-03-23 94
> aaf8dbeab586572 Coly Li 2019-11-13 95 err = "Not a bcache superblock (bad offset)";
> cafe563591446cf Kent Overstreet 2013-03-23 96 if (sb->offset != SB_SECTOR)
> cafe563591446cf Kent Overstreet 2013-03-23 97 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 98
> aaf8dbeab586572 Coly Li 2019-11-13 99 err = "Not a bcache superblock (bad magic)";
> cafe563591446cf Kent Overstreet 2013-03-23 100 if (memcmp(sb->magic, bcache_magic, 16))
> cafe563591446cf Kent Overstreet 2013-03-23 101 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 102
> cafe563591446cf Kent Overstreet 2013-03-23 103 err = "Too many journal buckets";
> cafe563591446cf Kent Overstreet 2013-03-23 104 if (sb->keys > SB_JOURNAL_BUCKETS)
> cafe563591446cf Kent Overstreet 2013-03-23 105 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 106
> cafe563591446cf Kent Overstreet 2013-03-23 107 err = "Bad checksum";
> cafe563591446cf Kent Overstreet 2013-03-23 @108 if (s->csum != csum_set(s))
> cafe563591446cf Kent Overstreet 2013-03-23 109 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 110
> cafe563591446cf Kent Overstreet 2013-03-23 111 err = "Bad UUID";
> 169ef1cf6171d35 Kent Overstreet 2013-03-28 112 if (bch_is_zero(sb->uuid, 16))
> cafe563591446cf Kent Overstreet 2013-03-23 113 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 114
> 8abb2a5dbadab91 Kent Overstreet 2013-04-23 115 sb->block_size = le16_to_cpu(s->block_size);
> 8abb2a5dbadab91 Kent Overstreet 2013-04-23 116
> 8abb2a5dbadab91 Kent Overstreet 2013-04-23 117 err = "Superblock block size smaller than device block size";
> 8abb2a5dbadab91 Kent Overstreet 2013-04-23 118 if (sb->block_size << 9 < bdev_logical_block_size(bdev))
> 8abb2a5dbadab91 Kent Overstreet 2013-04-23 119 goto err;
> 8abb2a5dbadab91 Kent Overstreet 2013-04-23 120
> 2903381fce71004 Kent Overstreet 2013-04-11 121 switch (sb->version) {
> 2903381fce71004 Kent Overstreet 2013-04-11 122 case BCACHE_SB_VERSION_BDEV:
> 2903381fce71004 Kent Overstreet 2013-04-11 123 sb->data_offset = BDEV_DATA_START_DEFAULT;
> 2903381fce71004 Kent Overstreet 2013-04-11 124 break;
> 2903381fce71004 Kent Overstreet 2013-04-11 125 case BCACHE_SB_VERSION_BDEV_WITH_OFFSET:
> 2903381fce71004 Kent Overstreet 2013-04-11 126 sb->data_offset = le64_to_cpu(s->data_offset);
> cafe563591446cf Kent Overstreet 2013-03-23 127
> 2903381fce71004 Kent Overstreet 2013-04-11 128 err = "Bad data offset";
> 2903381fce71004 Kent Overstreet 2013-04-11 129 if (sb->data_offset < BDEV_DATA_START_DEFAULT)
> cafe563591446cf Kent Overstreet 2013-03-23 130 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 131
> 2903381fce71004 Kent Overstreet 2013-04-11 132 break;
> 2903381fce71004 Kent Overstreet 2013-04-11 133 case BCACHE_SB_VERSION_CDEV:
> 2903381fce71004 Kent Overstreet 2013-04-11 134 case BCACHE_SB_VERSION_CDEV_WITH_UUID:
> 2903381fce71004 Kent Overstreet 2013-04-11 135 sb->nbuckets = le64_to_cpu(s->nbuckets);
> 2903381fce71004 Kent Overstreet 2013-04-11 136 sb->bucket_size = le16_to_cpu(s->bucket_size);
> 2903381fce71004 Kent Overstreet 2013-04-11 137
> 2903381fce71004 Kent Overstreet 2013-04-11 138 sb->nr_in_set = le16_to_cpu(s->nr_in_set);
> 2903381fce71004 Kent Overstreet 2013-04-11 139 sb->nr_this_dev = le16_to_cpu(s->nr_this_dev);
> 2903381fce71004 Kent Overstreet 2013-04-11 140
> cafe563591446cf Kent Overstreet 2013-03-23 141 err = "Too many buckets";
> cafe563591446cf Kent Overstreet 2013-03-23 142 if (sb->nbuckets > LONG_MAX)
> cafe563591446cf Kent Overstreet 2013-03-23 143 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 144
> cafe563591446cf Kent Overstreet 2013-03-23 145 err = "Not enough buckets";
> cafe563591446cf Kent Overstreet 2013-03-23 146 if (sb->nbuckets < 1 << 7)
> cafe563591446cf Kent Overstreet 2013-03-23 147 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 148
> 2903381fce71004 Kent Overstreet 2013-04-11 149 err = "Bad block/bucket size";
> 2903381fce71004 Kent Overstreet 2013-04-11 150 if (!is_power_of_2(sb->block_size) ||
> 2903381fce71004 Kent Overstreet 2013-04-11 151 sb->block_size > PAGE_SECTORS ||
> 2903381fce71004 Kent Overstreet 2013-04-11 152 !is_power_of_2(sb->bucket_size) ||
> 2903381fce71004 Kent Overstreet 2013-04-11 153 sb->bucket_size < PAGE_SECTORS)
> 2903381fce71004 Kent Overstreet 2013-04-11 154 goto err;
> 2903381fce71004 Kent Overstreet 2013-04-11 155
> cafe563591446cf Kent Overstreet 2013-03-23 156 err = "Invalid superblock: device too small";
> b0d30981c05f32d Coly Li 2018-08-11 157 if (get_capacity(bdev->bd_disk) <
> b0d30981c05f32d Coly Li 2018-08-11 158 sb->bucket_size * sb->nbuckets)
> cafe563591446cf Kent Overstreet 2013-03-23 159 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 160
> cafe563591446cf Kent Overstreet 2013-03-23 161 err = "Bad UUID";
> 169ef1cf6171d35 Kent Overstreet 2013-03-28 162 if (bch_is_zero(sb->set_uuid, 16))
> cafe563591446cf Kent Overstreet 2013-03-23 163 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 164
> cafe563591446cf Kent Overstreet 2013-03-23 165 err = "Bad cache device number in set";
> cafe563591446cf Kent Overstreet 2013-03-23 166 if (!sb->nr_in_set ||
> cafe563591446cf Kent Overstreet 2013-03-23 167 sb->nr_in_set <= sb->nr_this_dev ||
> cafe563591446cf Kent Overstreet 2013-03-23 168 sb->nr_in_set > MAX_CACHES_PER_SET)
> cafe563591446cf Kent Overstreet 2013-03-23 169 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 170
> cafe563591446cf Kent Overstreet 2013-03-23 171 err = "Journal buckets not sequential";
> cafe563591446cf Kent Overstreet 2013-03-23 172 for (i = 0; i < sb->keys; i++)
> cafe563591446cf Kent Overstreet 2013-03-23 173 if (sb->d[i] != sb->first_bucket + i)
> cafe563591446cf Kent Overstreet 2013-03-23 174 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 175
> cafe563591446cf Kent Overstreet 2013-03-23 176 err = "Too many journal buckets";
> cafe563591446cf Kent Overstreet 2013-03-23 177 if (sb->first_bucket + sb->keys > sb->nbuckets)
> cafe563591446cf Kent Overstreet 2013-03-23 178 goto err;
> cafe563591446cf Kent Overstreet 2013-03-23 179
> cafe563591446cf Kent Overstreet 2013-03-23 180 err = "Invalid superblock: first bucket comes before end of super";
> cafe563591446cf Kent Overstreet 2013-03-23 181 if (sb->first_bucket * sb->bucket_size < 16)
> cafe563591446cf Kent Overstreet 2013-03-23 182 goto err;
> 2903381fce71004 Kent Overstreet 2013-04-11 183
> 2903381fce71004 Kent Overstreet 2013-04-11 184 break;
> 2903381fce71004 Kent Overstreet 2013-04-11 185 default:
> 2903381fce71004 Kent Overstreet 2013-04-11 186 err = "Unsupported superblock version";
> 2903381fce71004 Kent Overstreet 2013-04-11 187 goto err;
> 2903381fce71004 Kent Overstreet 2013-04-11 188 }
> 2903381fce71004 Kent Overstreet 2013-04-11 189
> 75cbb3f1d840429 Arnd Bergmann 2018-07-26 190 sb->last_mount = (u32)ktime_get_real_seconds();
> cafe563591446cf Kent Overstreet 2013-03-23 191 err = NULL;
> cafe563591446cf Kent Overstreet 2013-03-23 192
> cafe563591446cf Kent Overstreet 2013-03-23 193 get_page(bh->b_page);
> cafe563591446cf Kent Overstreet 2013-03-23 194 *res = bh->b_page;
> cafe563591446cf Kent Overstreet 2013-03-23 195 err:
> cafe563591446cf Kent Overstreet 2013-03-23 196 put_bh(bh);
> cafe563591446cf Kent Overstreet 2013-03-23 197 return err;
> cafe563591446cf Kent Overstreet 2013-03-23 198 }
> cafe563591446cf Kent Overstreet 2013-03-23 199
> 4246a0b63bd8f56 Christoph Hellwig 2015-07-20 200 static void write_bdev_super_endio(struct bio *bio)
> cafe563591446cf Kent Overstreet 2013-03-23 201 {
> cafe563591446cf Kent Overstreet 2013-03-23 202 struct cached_dev *dc = bio->bi_private;
> 08ec1e6282f2716 Coly Li 2019-06-28 203
> 08ec1e6282f2716 Coly Li 2019-06-28 204 if (bio->bi_status)
> 08ec1e6282f2716 Coly Li 2019-06-28 205 bch_count_backing_io_errors(dc, bio);
> cafe563591446cf Kent Overstreet 2013-03-23 206
> cb7a583e6a6ace6 Kent Overstreet 2013-12-16 207 closure_put(&dc->sb_write);
> cafe563591446cf Kent Overstreet 2013-03-23 208 }
> cafe563591446cf Kent Overstreet 2013-03-23 209
> cafe563591446cf Kent Overstreet 2013-03-23 210 static void __write_super(struct cache_sb *sb, struct bio *bio)
> cafe563591446cf Kent Overstreet 2013-03-23 211 {
> a702a692cd75590 Christoph Hellwig 2020-01-24 212 struct cache_sb_disk *out = page_address(bio_first_page_all(bio));
> 6f10f7d1b02b1bb Coly Li 2018-08-11 213 unsigned int i;
> cafe563591446cf Kent Overstreet 2013-03-23 214
> 4f024f3797c43cb Kent Overstreet 2013-10-11 215 bio->bi_iter.bi_sector = SB_SECTOR;
> 4f024f3797c43cb Kent Overstreet 2013-10-11 216 bio->bi_iter.bi_size = SB_SIZE;
> ad0d9e76a412470 Mike Christie 2016-06-05 217 bio_set_op_attrs(bio, REQ_OP_WRITE, REQ_SYNC|REQ_META);
> 169ef1cf6171d35 Kent Overstreet 2013-03-28 218 bch_bio_map(bio, NULL);
> cafe563591446cf Kent Overstreet 2013-03-23 219
> cafe563591446cf Kent Overstreet 2013-03-23 220 out->offset = cpu_to_le64(sb->offset);
> cafe563591446cf Kent Overstreet 2013-03-23 221 out->version = cpu_to_le64(sb->version);
> cafe563591446cf Kent Overstreet 2013-03-23 222
> cafe563591446cf Kent Overstreet 2013-03-23 223 memcpy(out->uuid, sb->uuid, 16);
> cafe563591446cf Kent Overstreet 2013-03-23 224 memcpy(out->set_uuid, sb->set_uuid, 16);
> cafe563591446cf Kent Overstreet 2013-03-23 225 memcpy(out->label, sb->label, SB_LABEL_SIZE);
> cafe563591446cf Kent Overstreet 2013-03-23 226
> cafe563591446cf Kent Overstreet 2013-03-23 227 out->flags = cpu_to_le64(sb->flags);
> cafe563591446cf Kent Overstreet 2013-03-23 228 out->seq = cpu_to_le64(sb->seq);
> cafe563591446cf Kent Overstreet 2013-03-23 229
> cafe563591446cf Kent Overstreet 2013-03-23 230 out->last_mount = cpu_to_le32(sb->last_mount);
> cafe563591446cf Kent Overstreet 2013-03-23 231 out->first_bucket = cpu_to_le16(sb->first_bucket);
> cafe563591446cf Kent Overstreet 2013-03-23 232 out->keys = cpu_to_le16(sb->keys);
> cafe563591446cf Kent Overstreet 2013-03-23 233
> cafe563591446cf Kent Overstreet 2013-03-23 234 for (i = 0; i < sb->keys; i++)
> cafe563591446cf Kent Overstreet 2013-03-23 235 out->d[i] = cpu_to_le64(sb->d[i]);
> cafe563591446cf Kent Overstreet 2013-03-23 236
> cafe563591446cf Kent Overstreet 2013-03-23 @237 out->csum = csum_set(out);
> cafe563591446cf Kent Overstreet 2013-03-23 238
> cafe563591446cf Kent Overstreet 2013-03-23 239 pr_debug("ver %llu, flags %llu, seq %llu",
> cafe563591446cf Kent Overstreet 2013-03-23 240 sb->version, sb->flags, sb->seq);
> cafe563591446cf Kent Overstreet 2013-03-23 241
> 4e49ea4a3d27636 Mike Christie 2016-06-05 242 submit_bio(bio);
> cafe563591446cf Kent Overstreet 2013-03-23 243 }
> cafe563591446cf Kent Overstreet 2013-03-23 244
>
> :::::: The code at line 108 was first introduced by commit
> :::::: cafe563591446cf80bfbc2fe3bc72a2e36cf1060 bcache: A block layer cache
>
> :::::: TO: Kent Overstreet <koverstreet@google.com>
> :::::: CC: Kent Overstreet <koverstreet@google.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
2024-12-10 16:34 ` Coly Li
@ 2024-12-12 6:23 ` Christoph Hellwig
2024-12-12 17:45 ` Coly Li
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2024-12-12 6:23 UTC (permalink / raw)
To: Coly Li
Cc: kernel test robot, Christoph Hellwig, oe-kbuild-all, linux-kernel,
Jens Axboe
On Wed, Dec 11, 2024 at 12:34:20AM +0800, Coly Li wrote:
> > drivers/md/bcache/super.c:108:24: sparse: expected unsigned int nr_keys
> > drivers/md/bcache/super.c:108:24: sparse: got restricted __le16 [usertype] keys
> >>> drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
>
> It complains about line 108 which is,
> > cafe563591446cf Kent Overstreet 2013-03-23 107 err = "Bad checksum";
> > cafe563591446cf Kent Overstreet 2013-03-23 @108 if (s->csum != csum_set(s))
> > cafe563591446cf Kent Overstreet 2013-03-23 109 goto err;
>
> Here s->sum is __le64, csum_set() is uint64_t, these two types have same length. I don’t see the direct connection between code and warning.
The are the same size, but not the same endianess. In other words this
is a hint that this code is most likely broken on big endian systems
due to the lack of a bytespace (which is a no-op on little endian
systems).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
2024-12-12 6:23 ` Christoph Hellwig
@ 2024-12-12 17:45 ` Coly Li
0 siblings, 0 replies; 6+ messages in thread
From: Coly Li @ 2024-12-12 17:45 UTC (permalink / raw)
To: Christoph Hellwig
Cc: kernel test robot, oe-kbuild-all, linux-kernel, Jens Axboe
> 2024年12月12日 14:23，Christoph Hellwig <hch@lst.de> 写道：
>
> On Wed, Dec 11, 2024 at 12:34:20AM +0800, Coly Li wrote:
>>> drivers/md/bcache/super.c:108:24: sparse: expected unsigned int nr_keys
>>> drivers/md/bcache/super.c:108:24: sparse: got restricted __le16 [usertype] keys
>>>>> drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer
>>
>> It complains about line 108 which is,
>>> cafe563591446cf Kent Overstreet 2013-03-23 107 err = "Bad checksum";
>>> cafe563591446cf Kent Overstreet 2013-03-23 @108 if (s->csum != csum_set(s))
>>> cafe563591446cf Kent Overstreet 2013-03-23 109 goto err;
>>
>> Here s->sum is __le64, csum_set() is uint64_t, these two types have same length. I don’t see the direct connection between code and warning.
>
> The are the same size, but not the same endianess. In other words this
> is a hint that this code is most likely broken on big endian systems
> due to the lack of a bytespace (which is a no-op on little endian
> systems).
Oh I see. Thank you for the information.
Bcache doesn’t support moving cache device between machines with different endians. The on-disk data always has identical endian type as the in-memory data. The reason for __le64 was because it had to be a type defined.
Although there are some cpu_to_xxx used in code, indeed the btree keys are used directly after reading in from disk, or written directly without any cpu_to_xxx convert.
So this warning can be ignored.
Coly Li
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-12 17:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-06 1:15 drivers/md/bcache/super.c:108:14: sparse: sparse: restricted __le64 degrades to integer kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-12-09 4:00 kernel test robot
2024-12-10 16:34 ` Coly Li
2024-12-12 6:23 ` Christoph Hellwig
2024-12-12 17:45 ` Coly Li
2023-11-11 12:55 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox