* [PATCH] sample/acrn: Remove redundant assignment to itself
@ 2024-12-06 2:41 liujing
2024-12-06 6:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: liujing @ 2024-12-06 2:41 UTC (permalink / raw)
To: gregkh, thorsten.blum; +Cc: linux-kernel, liujing
Delete the self-redundancy assignment for sig, argc, and argv.
Signed-off-by: liujing <liujing@cmss.chinamobile.com>
diff --git a/samples/acrn/vm-sample.c b/samples/acrn/vm-sample.c
index c61e0f91456e..f6d62d1659ef 100644
--- a/samples/acrn/vm-sample.c
+++ b/samples/acrn/vm-sample.c
@@ -34,7 +34,6 @@ int is_running = 1;
void vm_exit(int sig)
{
- sig = sig;
is_running = 0;
ioctl(hsm_fd, ACRN_IOCTL_PAUSE_VM, vmid);
@@ -50,8 +49,6 @@ int main(int argc, char **argv)
struct acrn_io_request *io_req;
struct acrn_ioreq_notify __attribute__((aligned(8))) notify;
- argc = argc;
- argv = argv;
ret = posix_memalign(&guest_memory, 4096, GUEST_MEMORY_SIZE);
if (ret < 0) {
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] sample/acrn: Remove redundant assignment to itself
2024-12-06 2:41 [PATCH] sample/acrn: Remove redundant assignment to itself liujing
@ 2024-12-06 6:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2024-12-06 6:22 UTC (permalink / raw)
To: liujing; +Cc: thorsten.blum, linux-kernel
On Fri, Dec 06, 2024 at 10:41:27AM +0800, liujing wrote:
> Delete the self-redundancy assignment for sig, argc, and argv.
But perhaps they are there for a reason?
> Signed-off-by: liujing <liujing@cmss.chinamobile.com>
>
> diff --git a/samples/acrn/vm-sample.c b/samples/acrn/vm-sample.c
> index c61e0f91456e..f6d62d1659ef 100644
> --- a/samples/acrn/vm-sample.c
> +++ b/samples/acrn/vm-sample.c
> @@ -34,7 +34,6 @@ int is_running = 1;
>
> void vm_exit(int sig)
> {
> - sig = sig;
>
> is_running = 0;
> ioctl(hsm_fd, ACRN_IOCTL_PAUSE_VM, vmid);
> @@ -50,8 +49,6 @@ int main(int argc, char **argv)
> struct acrn_io_request *io_req;
> struct acrn_ioreq_notify __attribute__((aligned(8))) notify;
>
> - argc = argc;
> - argv = argv;
If you remove these, odds are now you will have build errors/warnings,
right? That's why someone added these.
sorry,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-06 6:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-06 2:41 [PATCH] sample/acrn: Remove redundant assignment to itself liujing
2024-12-06 6:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox