From: Armin Wolf <W_Armin@gmx.de>
To: jlee@suse.com, farhan.anwar8@gmail.com, rayanmargham4@gmail.com
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kuurtb@gmail.com
Subject: [PATCH v4 5/5] platform/x86: acer-wmi: Ignore AC events
Date: Tue, 10 Dec 2024 01:16:57 +0100 [thread overview]
Message-ID: <20241210001657.3362-6-W_Armin@gmx.de> (raw)
In-Reply-To: <20241210001657.3362-1-W_Armin@gmx.de>
On the Acer Swift SFG14-41, the events 8 - 1 and 8 - 0 are printed on
AC connect/disconnect. Ignore those events to avoid spamming the
kernel log with error messages.
Reported-by: Farhan Anwar <farhan.anwar8@gmail.com>
Closes: https://lore.kernel.org/platform-driver-x86/2ffb529d-e7c8-4026-a3b8-120c8e7afec8@gmail.com
Tested-by: Rayan Margham <rayanmargham4@gmail.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/platform/x86/acer-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index aad8eb0ddae5..ef26ec8d90ea 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -99,6 +99,7 @@ enum acer_wmi_event_ids {
WMID_HOTKEY_EVENT = 0x1,
WMID_ACCEL_OR_KBD_DOCK_EVENT = 0x5,
WMID_GAMING_TURBO_KEY_EVENT = 0x7,
+ WMID_AC_EVENT = 0x8,
};
enum acer_wmi_predator_v4_sys_info_command {
@@ -2304,6 +2305,9 @@ static void acer_wmi_notify(union acpi_object *obj, void *context)
if (return_value.key_num == 0x5 && has_cap(ACER_CAP_PLATFORM_PROFILE))
acer_thermal_profile_change();
break;
+ case WMID_AC_EVENT:
+ /* We ignore AC events here */
+ break;
default:
pr_warn("Unknown function number - %d - %d\n",
return_value.function, return_value.key_num);
--
2.39.5
next prev parent reply other threads:[~2024-12-10 0:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 0:16 [PATCH v4 0/5] acer-wmi: Various improvements Armin Wolf
2024-12-10 0:16 ` [PATCH v4 1/5] platform/x86: acer-wmi: Add support for Acer PH14-51 Armin Wolf
2024-12-10 2:09 ` Kurt Borja
2024-12-10 0:16 ` [PATCH v4 2/5] platform/x86: acer-wmi: Rename ACER_CAP_FAN_SPEED_READ Armin Wolf
2024-12-10 2:11 ` Kurt Borja
2024-12-10 0:16 ` [PATCH v4 3/5] platform/x86: acer-wmi: Improve error handling when reading gaming system information Armin Wolf
2024-12-10 2:06 ` Kurt Borja
2024-12-10 4:08 ` Armin Wolf
2024-12-10 4:18 ` Kurt Borja
2024-12-10 0:16 ` [PATCH v4 4/5] platform/x86: acer-wmi: Implement proper hwmon support Armin Wolf
2024-12-10 0:16 ` Armin Wolf [this message]
2024-12-10 2:16 ` [PATCH v4 5/5] platform/x86: acer-wmi: Ignore AC events Kurt Borja
2024-12-10 4:06 ` Armin Wolf
2024-12-10 14:43 ` Ilpo Järvinen
2024-12-14 10:45 ` David Wang
2025-01-20 12:43 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210001657.3362-6-W_Armin@gmx.de \
--to=w_armin@gmx.de \
--cc=farhan.anwar8@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jlee@suse.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rayanmargham4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox