From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: David Wang <00107082@163.com>
Cc: w_armin@gmx.de, farhan.anwar8@gmail.com,
Hans de Goede <hdegoede@redhat.com>,
jlee@suse.com, kuurtb@gmail.com,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, rayanmargham4@gmail.com
Subject: Re: [PATCH v4 5/5] platform/x86: acer-wmi: Ignore AC events
Date: Mon, 20 Jan 2025 14:43:58 +0200 (EET) [thread overview]
Message-ID: <f9f5d603-e391-47a8-adf4-d2e0c5a6836b@linux.intel.com> (raw)
In-Reply-To: <20241214104505.16025-1-00107082@163.com>
On Sat, 14 Dec 2024, David Wang wrote:
> May I suggest pr_info() this WMID_AC_EVENT event, there were discussions
> about possible unstable adapter cord causing flood of events 8-0/1. The
> logs may help identify the cause.
I don't think flood of pr_info() would be desired if that's the case.
While one could ratelimit the print out, it still seems useless noise for
normal operation which this patch aimed to eliminate.
It sounds more like you'd want to print something if and only if a flood
is detected (how to determine what is "flood", I don't know enough details
of this particular case)?
In any case, if feels something that would be better put into own a patch
with a proper justification and explanation what constitutes as "flood".
--
i.
prev parent reply other threads:[~2025-01-20 12:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 0:16 [PATCH v4 0/5] acer-wmi: Various improvements Armin Wolf
2024-12-10 0:16 ` [PATCH v4 1/5] platform/x86: acer-wmi: Add support for Acer PH14-51 Armin Wolf
2024-12-10 2:09 ` Kurt Borja
2024-12-10 0:16 ` [PATCH v4 2/5] platform/x86: acer-wmi: Rename ACER_CAP_FAN_SPEED_READ Armin Wolf
2024-12-10 2:11 ` Kurt Borja
2024-12-10 0:16 ` [PATCH v4 3/5] platform/x86: acer-wmi: Improve error handling when reading gaming system information Armin Wolf
2024-12-10 2:06 ` Kurt Borja
2024-12-10 4:08 ` Armin Wolf
2024-12-10 4:18 ` Kurt Borja
2024-12-10 0:16 ` [PATCH v4 4/5] platform/x86: acer-wmi: Implement proper hwmon support Armin Wolf
2024-12-10 0:16 ` [PATCH v4 5/5] platform/x86: acer-wmi: Ignore AC events Armin Wolf
2024-12-10 2:16 ` Kurt Borja
2024-12-10 4:06 ` Armin Wolf
2024-12-10 14:43 ` Ilpo Järvinen
2024-12-14 10:45 ` David Wang
2025-01-20 12:43 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f5d603-e391-47a8-adf4-d2e0c5a6836b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=00107082@163.com \
--cc=farhan.anwar8@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jlee@suse.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rayanmargham4@gmail.com \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox