* [PATCH] phy: mediatek: phy-mtk-hdmi: add regulator dependency
@ 2024-12-13 8:30 Arnd Bergmann
2024-12-13 9:12 ` AngeloGioacchino Del Regno
2024-12-24 15:21 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-12-13 8:30 UTC (permalink / raw)
To: Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I,
Matthias Brugger, AngeloGioacchino Del Regno
Cc: Arnd Bergmann, Phi-bang Nguyen, Jacob Keller, Daniel Golle,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The driver no longer builds when regulator support is unavailable:
arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_register_regulators':
phy-mtk-hdmi.c:(.text.unlikely+0x3e): undefined reference to `devm_regulator_register'
arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_is_enabled':
phy-mtk-hdmi-mt8195.c:(.text+0x326): undefined reference to `rdev_get_drvdata'
arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_disable':
phy-mtk-hdmi-mt8195.c:(.text+0x346): undefined reference to `rdev_get_drvdata'
arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_enable':
Fixes: 49393b2da1cd ("phy: mediatek: phy-mtk-hdmi: Register PHY provided regulator")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/mediatek/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
index 60e00057e8bc..ba6461350951 100644
--- a/drivers/phy/mediatek/Kconfig
+++ b/drivers/phy/mediatek/Kconfig
@@ -65,6 +65,7 @@ config PHY_MTK_HDMI
depends on ARCH_MEDIATEK || COMPILE_TEST
depends on COMMON_CLK
depends on OF
+ depends on REGULATOR
select GENERIC_PHY
help
Support HDMI PHY for Mediatek SoCs.
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: mediatek: phy-mtk-hdmi: add regulator dependency
2024-12-13 8:30 [PATCH] phy: mediatek: phy-mtk-hdmi: add regulator dependency Arnd Bergmann
@ 2024-12-13 9:12 ` AngeloGioacchino Del Regno
2024-12-24 15:21 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-12-13 9:12 UTC (permalink / raw)
To: Arnd Bergmann, Chunfeng Yun, Vinod Koul, Kishon Vijay Abraham I,
Matthias Brugger
Cc: Arnd Bergmann, Phi-bang Nguyen, Jacob Keller, Daniel Golle,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel
Il 13/12/24 09:30, Arnd Bergmann ha scritto:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver no longer builds when regulator support is unavailable:
>
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_register_regulators':
> phy-mtk-hdmi.c:(.text.unlikely+0x3e): undefined reference to `devm_regulator_register'
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_is_enabled':
> phy-mtk-hdmi-mt8195.c:(.text+0x326): undefined reference to `rdev_get_drvdata'
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_disable':
> phy-mtk-hdmi-mt8195.c:(.text+0x346): undefined reference to `rdev_get_drvdata'
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_enable':
>
> Fixes: 49393b2da1cd ("phy: mediatek: phy-mtk-hdmi: Register PHY provided regulator")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Sorry about the miss.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: mediatek: phy-mtk-hdmi: add regulator dependency
2024-12-13 8:30 [PATCH] phy: mediatek: phy-mtk-hdmi: add regulator dependency Arnd Bergmann
2024-12-13 9:12 ` AngeloGioacchino Del Regno
@ 2024-12-24 15:21 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-12-24 15:21 UTC (permalink / raw)
To: Chunfeng Yun, Kishon Vijay Abraham I, Matthias Brugger,
AngeloGioacchino Del Regno, Arnd Bergmann
Cc: Arnd Bergmann, Phi-bang Nguyen, Jacob Keller, Daniel Golle,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel
On Fri, 13 Dec 2024 09:30:51 +0100, Arnd Bergmann wrote:
> The driver no longer builds when regulator support is unavailable:
>
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_register_regulators':
> phy-mtk-hdmi.c:(.text.unlikely+0x3e): undefined reference to `devm_regulator_register'
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_is_enabled':
> phy-mtk-hdmi-mt8195.c:(.text+0x326): undefined reference to `rdev_get_drvdata'
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_disable':
> phy-mtk-hdmi-mt8195.c:(.text+0x346): undefined reference to `rdev_get_drvdata'
> arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_enable':
>
> [...]
Applied, thanks!
[1/1] phy: mediatek: phy-mtk-hdmi: add regulator dependency
commit: 17194c2998d39ab366a2ecbc4d1f3281e00d6a05
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-24 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-13 8:30 [PATCH] phy: mediatek: phy-mtk-hdmi: add regulator dependency Arnd Bergmann
2024-12-13 9:12 ` AngeloGioacchino Del Regno
2024-12-24 15:21 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox