* [PATCHv3] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get()
@ 2024-12-15 12:53 Karol Przybylski
2024-12-15 13:12 ` Laurent Pinchart
2024-12-16 10:05 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Karol Przybylski @ 2024-12-15 12:53 UTC (permalink / raw)
To: karprzy7, laurent.pinchart, tomi.valkeinen, maarten.lankhorst,
mripard, tzimmermann, airlied, simona, michal.simek
Cc: dri-devel, linux-arm-kernel, linux-kernel, stable
This patch fixes a potential integer overflow in the zynqmp_dp_rate_get()
The issue comes up when the expression
drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000 is evaluated using 32-bit
Now the constant is a compatible 64-bit type.
Resolves coverity issues: CID 1636340 and CID 1635811
Cc: stable@vger.kernel.org
Fixes: 28edaacb821c6 ("drm: zynqmp_dp: Add debugfs interface for compliance testing")
Signed-off-by: Karol Przybylski <karprzy7@gmail.com>
---
Changes from previous versions:
Added Fixes tag
Added Cc for stable kernel version
Fixed formatting
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 25c5dc61ee88..56a261a40ea3 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -2190,7 +2190,7 @@ static int zynqmp_dp_rate_get(void *data, u64 *val)
struct zynqmp_dp *dp = data;
mutex_lock(&dp->lock);
- *val = drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000;
+ *val = drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000ULL;
mutex_unlock(&dp->lock);
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCHv3] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get()
2024-12-15 12:53 [PATCHv3] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get() Karol Przybylski
@ 2024-12-15 13:12 ` Laurent Pinchart
2024-12-16 10:05 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2024-12-15 13:12 UTC (permalink / raw)
To: Karol Przybylski
Cc: tomi.valkeinen, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, michal.simek, dri-devel, linux-arm-kernel, linux-kernel,
stable
Ho Karol,
Thank you for the patch.
On Sun, Dec 15, 2024 at 01:53:55PM +0100, Karol Przybylski wrote:
> This patch fixes a potential integer overflow in the zynqmp_dp_rate_get()
>
> The issue comes up when the expression
> drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000 is evaluated using 32-bit
> Now the constant is a compatible 64-bit type.
>
> Resolves coverity issues: CID 1636340 and CID 1635811
>
> Cc: stable@vger.kernel.org
> Fixes: 28edaacb821c6 ("drm: zynqmp_dp: Add debugfs interface for compliance testing")
> Signed-off-by: Karol Przybylski <karprzy7@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes from previous versions:
> Added Fixes tag
> Added Cc for stable kernel version
> Fixed formatting
>
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 25c5dc61ee88..56a261a40ea3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -2190,7 +2190,7 @@ static int zynqmp_dp_rate_get(void *data, u64 *val)
> struct zynqmp_dp *dp = data;
>
> mutex_lock(&dp->lock);
> - *val = drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000;
> + *val = drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000ULL;
> mutex_unlock(&dp->lock);
> return 0;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCHv3] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get()
2024-12-15 12:53 [PATCHv3] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get() Karol Przybylski
2024-12-15 13:12 ` Laurent Pinchart
@ 2024-12-16 10:05 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2024-12-16 10:05 UTC (permalink / raw)
To: Karol Przybylski, laurent.pinchart, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, michal.simek
Cc: dri-devel, linux-arm-kernel, linux-kernel, stable
Hi,
On 15/12/2024 14:53, Karol Przybylski wrote:
> This patch fixes a potential integer overflow in the zynqmp_dp_rate_get()
>
> The issue comes up when the expression
> drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000 is evaluated using 32-bit
> Now the constant is a compatible 64-bit type.
>
> Resolves coverity issues: CID 1636340 and CID 1635811
>
> Cc: stable@vger.kernel.org
> Fixes: 28edaacb821c6 ("drm: zynqmp_dp: Add debugfs interface for compliance testing")
> Signed-off-by: Karol Przybylski <karprzy7@gmail.com>
> ---
> Changes from previous versions:
> Added Fixes tag
> Added Cc for stable kernel version
> Fixed formatting
>
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> index 25c5dc61ee88..56a261a40ea3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> @@ -2190,7 +2190,7 @@ static int zynqmp_dp_rate_get(void *data, u64 *val)
> struct zynqmp_dp *dp = data;
>
> mutex_lock(&dp->lock);
> - *val = drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000;
> + *val = drm_dp_bw_code_to_link_rate(dp->test.bw_code) * 10000ULL;
> mutex_unlock(&dp->lock);
> return 0;
> }
Thanks, pushed to drm-misc-next.
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-16 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-15 12:53 [PATCHv3] drm: zynqmp_dp: Fix integer overflow in zynqmp_dp_rate_get() Karol Przybylski
2024-12-15 13:12 ` Laurent Pinchart
2024-12-16 10:05 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox