* kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
@ 2024-12-15 12:57 kernel test robot
2024-12-15 14:26 ` Philip Li
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2024-12-15 12:57 UTC (permalink / raw)
To: Kees Cook; +Cc: oe-kbuild-all, linux-kernel, Jonathan Corbet
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2d8308bf5b67dff50262d8a9260a50113b3628c6
commit: 0c3ebff535956d2718594dc90aa9cc87521ec9fd scripts: kernel-doc: Clarify missing struct member description
date: 1 year ago
config: arm-allnoconfig (https://download.01.org/0day-ci/archive/20241215/202412152053.KeJr8B5f-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241215/202412152053.KeJr8B5f-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412152053.KeJr8B5f-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
>> kernel/reboot.c:952: warning: Function parameter or struct member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'
--
>> lib/hweight.c:14: warning: Function parameter or struct member 'w' not described in '__sw_hweight32'
lib/hweight.c:14: warning: expecting prototype for hweightN(). Prototype was for __sw_hweight32() instead
vim +226 kernel/reboot.c
b63adb979583ef Guenter Roeck 2014-09-26 213
b63adb979583ef Guenter Roeck 2014-09-26 214 /**
b63adb979583ef Guenter Roeck 2014-09-26 215 * do_kernel_restart - Execute kernel restart handler call chain
b63adb979583ef Guenter Roeck 2014-09-26 216 *
b63adb979583ef Guenter Roeck 2014-09-26 217 * Calls functions registered with register_restart_handler.
b63adb979583ef Guenter Roeck 2014-09-26 218 *
b63adb979583ef Guenter Roeck 2014-09-26 219 * Expected to be called from machine_restart as last step of the restart
b63adb979583ef Guenter Roeck 2014-09-26 220 * sequence.
b63adb979583ef Guenter Roeck 2014-09-26 221 *
b63adb979583ef Guenter Roeck 2014-09-26 222 * Restarts the system immediately if a restart handler function has been
b63adb979583ef Guenter Roeck 2014-09-26 223 * registered. Otherwise does nothing.
b63adb979583ef Guenter Roeck 2014-09-26 224 */
b63adb979583ef Guenter Roeck 2014-09-26 225 void do_kernel_restart(char *cmd)
b63adb979583ef Guenter Roeck 2014-09-26 @226 {
b63adb979583ef Guenter Roeck 2014-09-26 227 atomic_notifier_call_chain(&restart_handler_list, reboot_mode, cmd);
b63adb979583ef Guenter Roeck 2014-09-26 228 }
b63adb979583ef Guenter Roeck 2014-09-26 229
:::::: The code at line 226 was first introduced by commit
:::::: b63adb979583ef185718d774d8162387db5589c0 kernel: add support for kernel restart handler call chain
:::::: TO: Guenter Roeck <linux@roeck-us.net>
:::::: CC: Guenter Roeck <linux@roeck-us.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
2024-12-15 12:57 kernel test robot
@ 2024-12-15 14:26 ` Philip Li
0 siblings, 0 replies; 4+ messages in thread
From: Philip Li @ 2024-12-15 14:26 UTC (permalink / raw)
To: kernel test robot; +Cc: Kees Cook, oe-kbuild-all, linux-kernel, Jonathan Corbet
On Sun, Dec 15, 2024 at 08:57:39PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 2d8308bf5b67dff50262d8a9260a50113b3628c6
> commit: 0c3ebff535956d2718594dc90aa9cc87521ec9fd scripts: kernel-doc: Clarify missing struct member description
> date: 1 year ago
> config: arm-allnoconfig (https://download.01.org/0day-ci/archive/20241215/202412152053.KeJr8B5f-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241215/202412152053.KeJr8B5f-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412152053.KeJr8B5f-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
Sorry, kindly ignore this, the commit is not the actual cause of
the issue.
>
> >> kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
> >> kernel/reboot.c:952: warning: Function parameter or struct member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'
> --
> >> lib/hweight.c:14: warning: Function parameter or struct member 'w' not described in '__sw_hweight32'
> lib/hweight.c:14: warning: expecting prototype for hweightN(). Prototype was for __sw_hweight32() instead
>
>
> vim +226 kernel/reboot.c
>
> b63adb979583ef Guenter Roeck 2014-09-26 213
> b63adb979583ef Guenter Roeck 2014-09-26 214 /**
> b63adb979583ef Guenter Roeck 2014-09-26 215 * do_kernel_restart - Execute kernel restart handler call chain
> b63adb979583ef Guenter Roeck 2014-09-26 216 *
> b63adb979583ef Guenter Roeck 2014-09-26 217 * Calls functions registered with register_restart_handler.
> b63adb979583ef Guenter Roeck 2014-09-26 218 *
> b63adb979583ef Guenter Roeck 2014-09-26 219 * Expected to be called from machine_restart as last step of the restart
> b63adb979583ef Guenter Roeck 2014-09-26 220 * sequence.
> b63adb979583ef Guenter Roeck 2014-09-26 221 *
> b63adb979583ef Guenter Roeck 2014-09-26 222 * Restarts the system immediately if a restart handler function has been
> b63adb979583ef Guenter Roeck 2014-09-26 223 * registered. Otherwise does nothing.
> b63adb979583ef Guenter Roeck 2014-09-26 224 */
> b63adb979583ef Guenter Roeck 2014-09-26 225 void do_kernel_restart(char *cmd)
> b63adb979583ef Guenter Roeck 2014-09-26 @226 {
> b63adb979583ef Guenter Roeck 2014-09-26 227 atomic_notifier_call_chain(&restart_handler_list, reboot_mode, cmd);
> b63adb979583ef Guenter Roeck 2014-09-26 228 }
> b63adb979583ef Guenter Roeck 2014-09-26 229
>
> :::::: The code at line 226 was first introduced by commit
> :::::: b63adb979583ef185718d774d8162387db5589c0 kernel: add support for kernel restart handler call chain
>
> :::::: TO: Guenter Roeck <linux@roeck-us.net>
> :::::: CC: Guenter Roeck <linux@roeck-us.net>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
@ 2024-12-17 5:02 kernel test robot
2024-12-17 7:42 ` Philip Li
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2024-12-17 5:02 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: oe-kbuild-all, linux-kernel, Nathan Chancellor
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f44d154d6e3d633d4c49a5d6aed8a0e4684ae25e
commit: 92ef432f027cffe0ff91ff2cbe9258d89ca53968 kbuild: support W=c and W=e shorthands for Kconfig
date: 1 year ago
config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20241217/202412171248.ro76Gqt1-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241217/202412171248.ro76Gqt1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412171248.ro76Gqt1-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
>> kernel/reboot.c:952: warning: Function parameter or struct member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'
--
lib/vsprintf.c: In function 'va_format':
>> lib/vsprintf.c:1683:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
1683 | buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
| ^~~
--
>> lib/hweight.c:14: warning: Function parameter or struct member 'w' not described in '__sw_hweight32'
>> lib/hweight.c:14: warning: expecting prototype for hweightN(). Prototype was for __sw_hweight32() instead
--
drivers/clk/clkdev.c: In function 'vclkdev_alloc':
>> drivers/clk/clkdev.c:173:17: warning: function 'vclkdev_alloc' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
173 | vscnprintf(cla->dev_id, sizeof(cla->dev_id), dev_fmt, ap);
| ^~~~~~~~~~
vim +226 kernel/reboot.c
b63adb979583ef Guenter Roeck 2014-09-26 213
b63adb979583ef Guenter Roeck 2014-09-26 214 /**
b63adb979583ef Guenter Roeck 2014-09-26 215 * do_kernel_restart - Execute kernel restart handler call chain
b63adb979583ef Guenter Roeck 2014-09-26 216 *
b63adb979583ef Guenter Roeck 2014-09-26 217 * Calls functions registered with register_restart_handler.
b63adb979583ef Guenter Roeck 2014-09-26 218 *
b63adb979583ef Guenter Roeck 2014-09-26 219 * Expected to be called from machine_restart as last step of the restart
b63adb979583ef Guenter Roeck 2014-09-26 220 * sequence.
b63adb979583ef Guenter Roeck 2014-09-26 221 *
b63adb979583ef Guenter Roeck 2014-09-26 222 * Restarts the system immediately if a restart handler function has been
b63adb979583ef Guenter Roeck 2014-09-26 223 * registered. Otherwise does nothing.
b63adb979583ef Guenter Roeck 2014-09-26 224 */
b63adb979583ef Guenter Roeck 2014-09-26 225 void do_kernel_restart(char *cmd)
b63adb979583ef Guenter Roeck 2014-09-26 @226 {
b63adb979583ef Guenter Roeck 2014-09-26 227 atomic_notifier_call_chain(&restart_handler_list, reboot_mode, cmd);
b63adb979583ef Guenter Roeck 2014-09-26 228 }
b63adb979583ef Guenter Roeck 2014-09-26 229
:::::: The code at line 226 was first introduced by commit
:::::: b63adb979583ef185718d774d8162387db5589c0 kernel: add support for kernel restart handler call chain
:::::: TO: Guenter Roeck <linux@roeck-us.net>
:::::: CC: Guenter Roeck <linux@roeck-us.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
2024-12-17 5:02 kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart' kernel test robot
@ 2024-12-17 7:42 ` Philip Li
0 siblings, 0 replies; 4+ messages in thread
From: Philip Li @ 2024-12-17 7:42 UTC (permalink / raw)
To: kernel test robot
Cc: Masahiro Yamada, oe-kbuild-all, linux-kernel, Nathan Chancellor
On Tue, Dec 17, 2024 at 01:02:37PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: f44d154d6e3d633d4c49a5d6aed8a0e4684ae25e
> commit: 92ef432f027cffe0ff91ff2cbe9258d89ca53968 kbuild: support W=c and W=e shorthands for Kconfig
> date: 1 year ago
> config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20241217/202412171248.ro76Gqt1-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241217/202412171248.ro76Gqt1-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412171248.ro76Gqt1-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
Sorry, kindly ignore this report that the commit is not the right one for the issue.
>
> >> kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
> >> kernel/reboot.c:952: warning: Function parameter or struct member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'
> --
> lib/vsprintf.c: In function 'va_format':
> >> lib/vsprintf.c:1683:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> 1683 | buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
> | ^~~
> --
> >> lib/hweight.c:14: warning: Function parameter or struct member 'w' not described in '__sw_hweight32'
> >> lib/hweight.c:14: warning: expecting prototype for hweightN(). Prototype was for __sw_hweight32() instead
> --
> drivers/clk/clkdev.c: In function 'vclkdev_alloc':
> >> drivers/clk/clkdev.c:173:17: warning: function 'vclkdev_alloc' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> 173 | vscnprintf(cla->dev_id, sizeof(cla->dev_id), dev_fmt, ap);
> | ^~~~~~~~~~
>
>
> vim +226 kernel/reboot.c
>
> b63adb979583ef Guenter Roeck 2014-09-26 213
> b63adb979583ef Guenter Roeck 2014-09-26 214 /**
> b63adb979583ef Guenter Roeck 2014-09-26 215 * do_kernel_restart - Execute kernel restart handler call chain
> b63adb979583ef Guenter Roeck 2014-09-26 216 *
> b63adb979583ef Guenter Roeck 2014-09-26 217 * Calls functions registered with register_restart_handler.
> b63adb979583ef Guenter Roeck 2014-09-26 218 *
> b63adb979583ef Guenter Roeck 2014-09-26 219 * Expected to be called from machine_restart as last step of the restart
> b63adb979583ef Guenter Roeck 2014-09-26 220 * sequence.
> b63adb979583ef Guenter Roeck 2014-09-26 221 *
> b63adb979583ef Guenter Roeck 2014-09-26 222 * Restarts the system immediately if a restart handler function has been
> b63adb979583ef Guenter Roeck 2014-09-26 223 * registered. Otherwise does nothing.
> b63adb979583ef Guenter Roeck 2014-09-26 224 */
> b63adb979583ef Guenter Roeck 2014-09-26 225 void do_kernel_restart(char *cmd)
> b63adb979583ef Guenter Roeck 2014-09-26 @226 {
> b63adb979583ef Guenter Roeck 2014-09-26 227 atomic_notifier_call_chain(&restart_handler_list, reboot_mode, cmd);
> b63adb979583ef Guenter Roeck 2014-09-26 228 }
> b63adb979583ef Guenter Roeck 2014-09-26 229
>
> :::::: The code at line 226 was first introduced by commit
> :::::: b63adb979583ef185718d774d8162387db5589c0 kernel: add support for kernel restart handler call chain
>
> :::::: TO: Guenter Roeck <linux@roeck-us.net>
> :::::: CC: Guenter Roeck <linux@roeck-us.net>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-17 7:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-17 5:02 kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart' kernel test robot
2024-12-17 7:42 ` Philip Li
-- strict thread matches above, loose matches on Subject: below --
2024-12-15 12:57 kernel test robot
2024-12-15 14:26 ` Philip Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox