From: Atharva Tiwari <evepolonium@gmail.com>
Cc: evepolonium@gmail.com, James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] nvme-fc: add DIF support for intergrity metadata
Date: Fri, 27 Dec 2024 09:57:22 +0530 [thread overview]
Message-ID: <20241227042722.1184-1-evepolonium@gmail.com> (raw)
This patch enhances the NVMe over Fibre Channel (NVMe-FC) driver to
handle requests with integrity metadata (DIF).
- Added the inclusion of `<linux/blk-integrity.h>` to enable integrity operations.
- Implemented support for mapping integrity metadata using `blk_rq_map_integrity_sg`.
- Ensures proper handling of requests with integrity metadata, including error cases where mapping fails.
This update improves the reliability of data integrity checks in environments utilizing DIF.
Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
---
drivers/nvme/host/fc.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index b81af7919e94..d0343133413f 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -17,6 +17,7 @@
#include "fc.h"
#include <scsi/scsi_transport_fc.h>
#include <linux/blk-mq-pci.h>
+#include <linux/blk-integrity.h>
/* *************************** Data Structures/Defines ****************** */
@@ -2620,10 +2621,16 @@ nvme_fc_map_data(struct nvme_fc_ctrl *ctrl, struct request *rq,
freq->sg_cnt = 0;
return -EFAULT;
}
-
- /*
- * TODO: blk_integrity_rq(rq) for DIF
- */
+ /* Handle requests with integrity metadata (DIF) */
+ if (blk_integrity_rq(rq)) {
+ ret = blk_rq_map_integrity_sg(rq, freq->sg_table.sgl);
+ if (ret < 0) {
+ sg_free_table_chained(&freq->sg_table, NVME_INLINE_SG_CNT);
+ freq->sg_cnt = 0;
+ return -EFAULT;
+ }
+ freq->sg_cnt += ret;
+ }
return 0;
}
--
2.39.5
next reply other threads:[~2024-12-27 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 4:27 Atharva Tiwari [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-26 9:14 [PATCH] nvme-fc: add DIF support for intergrity metadata Atharva Tiwari
2025-01-03 6:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241227042722.1184-1-evepolonium@gmail.com \
--to=evepolonium@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox