From: Christoph Hellwig <hch@lst.de>
To: Atharva Tiwari <evepolonium@gmail.com>
Cc: James Smart <james.smart@broadcom.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-fc: add DIF support for intergrity metadata
Date: Fri, 3 Jan 2025 07:57:25 +0100 [thread overview]
Message-ID: <20250103065725.GA28303@lst.de> (raw)
In-Reply-To: <20241226091415.354329-1-evepolonium@gmail.com>
On Thu, Dec 26, 2024 at 02:44:15PM +0530, Atharva Tiwari wrote:
> This patch enhances the NVMe over Fibre Channel (NVMe-FC) driver to
> handle requests with integrity metadata (DIF).
>
> - Added the inclusion of `<linux/blk-integrity.h>` to enable integrity operations.
> - Implemented support for mapping integrity metadata using `blk_rq_map_integrity_sg`.
> - Ensures proper handling of requests with integrity metadata, including error cases where mapping fails.
This isn't really how we write commit logs. The mechanics are
visible in the patch. Also please wrap commit log lines after 73
characters.
> + /* Handle requests with integrity metadata (DIF) */
> + if (blk_integrity_rq(rq)) {
> + ret = blk_rq_map_integrity_sg(rq, freq->sg_table.sgl);
> + if (ret < 0) {
> + sg_free_table_chained(&freq->sg_table, NVME_INLINE_SG_CNT);
> + freq->sg_cnt = 0;
> + return -EFAULT;
> + }
> + freq->sg_cnt += ret;
> + }
Who is going to look at the integrity sglist? Who is setting a
max_integrity_segments value for nvme-fc?
How was this tested?
next prev parent reply other threads:[~2025-01-03 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 9:14 [PATCH] nvme-fc: add DIF support for intergrity metadata Atharva Tiwari
2025-01-03 6:57 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-27 4:27 Atharva Tiwari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103065725.GA28303@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=evepolonium@gmail.com \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox