* Re: [PATCH 1/2] rt2x00: Remove unusued value [not found] ` <20250104103753.GA2228@wp.pl> @ 2025-01-04 12:51 ` Ariel Otilibili-Anieli 2025-01-05 21:21 ` Daniel Golle 0 siblings, 1 reply; 5+ messages in thread From: Ariel Otilibili-Anieli @ 2025-01-04 12:51 UTC (permalink / raw) To: Stanislaw Gruszka Cc: Daniel Golle, linux-wireless, netdev, Kalle Valo, Tomislav Požega, Linux-kernel Hi Stanislaw, On Saturday, January 04, 2025 11:37 CET, Stanislaw Gruszka <stf_xl@wp.pl> wrote: > Hi > > On Fri, Jan 03, 2025 at 02:39:21PM +0100, Ariel Otilibili-Anieli wrote: > > On Friday, January 03, 2025 14:10 CET, Stanislaw Gruszka <stf_xl@wp.pl> wrote: > > > > > > Thanks for having looked into this; I much appreciate your feedback. > > > > From what you two said, I understand that the patch should remove the duplicate code, and not change the logic behind. > > > > Is this right? > > Yes. Great, then; thanks for having acked the patch as such. > > Regards > Stanislaw > > > > If so; then, I have nothing else to do. > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] rt2x00: Remove unusued value 2025-01-04 12:51 ` [PATCH 1/2] rt2x00: Remove unusued value Ariel Otilibili-Anieli @ 2025-01-05 21:21 ` Daniel Golle 2025-01-06 7:23 ` Ariel Otilibili-Anieli 0 siblings, 1 reply; 5+ messages in thread From: Daniel Golle @ 2025-01-05 21:21 UTC (permalink / raw) To: Ariel Otilibili-Anieli Cc: Shiji Yang, Stanislaw Gruszka, linux-wireless, netdev, Kalle Valo, Tomislav Požega, Linux-kernel H again, On Sat, Jan 04, 2025 at 01:51:25PM +0100, Ariel Otilibili-Anieli wrote: > Great, then; thanks for having acked the patch as such. I just noticed that Shiji Yang had posted a series of patches for OpenWrt which also addresses the same issue, however, instead of removing the augmented assignment, it fixes it to the supposedly originally intended way. See https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/mac80211/patches/rt2x00/621-04-rt2x00-fix-register-operation-on-RXIQ-calibration.patch;h=aa6f9c437c6447831490588b2cead6919accda58;hb=5d583901657bdfbbf9fad77d9247872427aa5c99 I suppose this was tested together with the other changes of the same series, so we may want to pick that instead. Cheers Daniel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] rt2x00: Remove unusued value 2025-01-05 21:21 ` Daniel Golle @ 2025-01-06 7:23 ` Ariel Otilibili-Anieli 2025-01-07 10:23 ` Stanislaw Gruszka 2025-01-07 11:01 ` Jonas Gorski 0 siblings, 2 replies; 5+ messages in thread From: Ariel Otilibili-Anieli @ 2025-01-06 7:23 UTC (permalink / raw) To: Daniel Golle Cc: Shiji Yang, Stanislaw Gruszka, linux-wireless, netdev, Kalle Valo, Tomislav Požega, Linux-kernel Hi Daniel, hi Shiji, hi Stanislaw, On Sunday, January 05, 2025 22:21 CET, Daniel Golle <daniel@makrotopia.org> wrote: > H again, > > > On Sat, Jan 04, 2025 at 01:51:25PM +0100, Ariel Otilibili-Anieli wrote: > > Great, then; thanks for having acked the patch as such. > > I just noticed that Shiji Yang had posted a series of patches for > OpenWrt which also addresses the same issue, however, instead of > removing the augmented assignment, it fixes it to the supposedly > originally intended way. > > See > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/mac80211/patches/rt2x00/621-04-rt2x00-fix-register-operation-on-RXIQ-calibration.patch;h=aa6f9c437c6447831490588b2cead6919accda58;hb=5d583901657bdfbbf9fad77d9247872427aa5c99 > > I suppose this was tested together with the other changes of the same > series, so we may want to pick that instead. Thanks for having put some time into the research, Daniel; I looked into the openwrt archives for 2024, none of Shiji’s messages mentions that patch. Though, if you three agree, I will push a new series, modelled on that patch, and you as Suggested-by. Have a good week, Ariel > > > Cheers > > > Daniel > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] rt2x00: Remove unusued value 2025-01-06 7:23 ` Ariel Otilibili-Anieli @ 2025-01-07 10:23 ` Stanislaw Gruszka 2025-01-07 11:01 ` Jonas Gorski 1 sibling, 0 replies; 5+ messages in thread From: Stanislaw Gruszka @ 2025-01-07 10:23 UTC (permalink / raw) To: Ariel Otilibili-Anieli Cc: Daniel Golle, Shiji Yang, linux-wireless, netdev, Kalle Valo, Tomislav Požega, Linux-kernel Hi Ariel, On Mon, Jan 06, 2025 at 08:23:34AM +0100, Ariel Otilibili-Anieli wrote: > Hi Daniel, hi Shiji, hi Stanislaw, > > On Sunday, January 05, 2025 22:21 CET, Daniel Golle <daniel@makrotopia.org> wrote: > > > H again, > > > > > > On Sat, Jan 04, 2025 at 01:51:25PM +0100, Ariel Otilibili-Anieli wrote: > > > Great, then; thanks for having acked the patch as such. > > > > I just noticed that Shiji Yang had posted a series of patches for > > OpenWrt which also addresses the same issue, however, instead of > > removing the augmented assignment, it fixes it to the supposedly > > originally intended way. > > > > See > > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/mac80211/patches/rt2x00/621-04-rt2x00-fix-register-operation-on-RXIQ-calibration.patch;h=aa6f9c437c6447831490588b2cead6919accda58;hb=5d583901657bdfbbf9fad77d9247872427aa5c99 > > > > I suppose this was tested together with the other changes of the same > > series, so we may want to pick that instead. > > Thanks for having put some time into the research, Daniel; I looked into the openwrt archives for 2024, none of Shiji’s messages mentions that patch. > > Though, if you three agree, I will push a new series, modelled on that patch, and you as Suggested-by. Please post that change. But to not mix it with patches against other drivers in the same series. (multiple rt2x00 patches in one patchset are ok). And please use "wifi: rt2x00:" as subject prefix. Thanks Stanislaw ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] rt2x00: Remove unusued value 2025-01-06 7:23 ` Ariel Otilibili-Anieli 2025-01-07 10:23 ` Stanislaw Gruszka @ 2025-01-07 11:01 ` Jonas Gorski 1 sibling, 0 replies; 5+ messages in thread From: Jonas Gorski @ 2025-01-07 11:01 UTC (permalink / raw) To: Ariel Otilibili-Anieli Cc: Daniel Golle, Shiji Yang, Stanislaw Gruszka, linux-wireless, netdev, Kalle Valo, Tomislav Požega, Linux-kernel Hi, On Mon, Jan 6, 2025 at 8:23 AM Ariel Otilibili-Anieli <Ariel.Otilibili-Anieli@eurecom.fr> wrote: > > Hi Daniel, hi Shiji, hi Stanislaw, > > On Sunday, January 05, 2025 22:21 CET, Daniel Golle <daniel@makrotopia.org> wrote: > > > H again, > > > > > > On Sat, Jan 04, 2025 at 01:51:25PM +0100, Ariel Otilibili-Anieli wrote: > > > Great, then; thanks for having acked the patch as such. > > > > I just noticed that Shiji Yang had posted a series of patches for > > OpenWrt which also addresses the same issue, however, instead of > > removing the augmented assignment, it fixes it to the supposedly > > originally intended way. > > > > See > > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/kernel/mac80211/patches/rt2x00/621-04-rt2x00-fix-register-operation-on-RXIQ-calibration.patch;h=aa6f9c437c6447831490588b2cead6919accda58;hb=5d583901657bdfbbf9fad77d9247872427aa5c99 > > > > I suppose this was tested together with the other changes of the same > > series, so we may want to pick that instead. > > Thanks for having put some time into the research, Daniel; I looked into the openwrt archives for 2024, none of Shiji’s messages mentions that patch. You didn't find anything because these changes came in via a PR on github: https://github.com/openwrt/openwrt/pull/16845 :) OpenWrt accepts contributions both via email and PR on github. Best Regards, Jonas ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-01-07 11:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241221124445.1094460-1-ariel.otilibili-anieli@eurecom.fr>
[not found] ` <20241221124445.1094460-2-ariel.otilibili-anieli@eurecom.fr>
[not found] ` <20250103085540.GA94204@wp.pl>
[not found] ` <Z3fMxD2mAVsVl58h@pidgin.makrotopia.org>
[not found] ` <20250103131002.GA100011@wp.pl>
[not found] ` <2f7a83-6777e880-a451-5cf12280@99910178>
[not found] ` <20250104103753.GA2228@wp.pl>
2025-01-04 12:51 ` [PATCH 1/2] rt2x00: Remove unusued value Ariel Otilibili-Anieli
2025-01-05 21:21 ` Daniel Golle
2025-01-06 7:23 ` Ariel Otilibili-Anieli
2025-01-07 10:23 ` Stanislaw Gruszka
2025-01-07 11:01 ` Jonas Gorski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox