* [PATCH] USB: serial: ch341: use fix-width types consistently
@ 2025-01-08 10:15 Johan Hovold
2025-01-08 12:10 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2025-01-08 10:15 UTC (permalink / raw)
To: Johan Hovold; +Cc: Lode Willems, linux-usb, linux-kernel
Use Linux fix-width types consistently and drop a related unnecessary
cast.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/ch341.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index ac74b353b26d..7cc36f84821f 100644
--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -660,13 +660,12 @@ static int ch341_simulate_break(struct tty_struct *tty, int break_state)
static int ch341_break_ctl(struct tty_struct *tty, int break_state)
{
- const uint16_t ch341_break_reg =
- ((uint16_t) CH341_REG_LCR << 8) | CH341_REG_BREAK;
+ const u16 ch341_break_reg = (CH341_REG_LCR << 8) | CH341_REG_BREAK;
struct usb_serial_port *port = tty->driver_data;
struct ch341_private *priv = usb_get_serial_port_data(port);
+ u16 reg_contents;
+ u8 break_reg[2];
int r;
- uint16_t reg_contents;
- uint8_t break_reg[2];
if (priv->quirks & CH341_QUIRK_SIMULATE_BREAK)
return ch341_simulate_break(tty, break_state);
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] USB: serial: ch341: use fix-width types consistently
2025-01-08 10:15 [PATCH] USB: serial: ch341: use fix-width types consistently Johan Hovold
@ 2025-01-08 12:10 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-01-08 12:10 UTC (permalink / raw)
To: Johan Hovold; +Cc: Lode Willems, linux-usb, linux-kernel
On Wed, Jan 08, 2025 at 11:15:18AM +0100, Johan Hovold wrote:
> Use Linux fix-width types consistently and drop a related unnecessary
> cast.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/usb/serial/ch341.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
> index ac74b353b26d..7cc36f84821f 100644
> --- a/drivers/usb/serial/ch341.c
> +++ b/drivers/usb/serial/ch341.c
> @@ -660,13 +660,12 @@ static int ch341_simulate_break(struct tty_struct *tty, int break_state)
>
> static int ch341_break_ctl(struct tty_struct *tty, int break_state)
> {
> - const uint16_t ch341_break_reg =
> - ((uint16_t) CH341_REG_LCR << 8) | CH341_REG_BREAK;
> + const u16 ch341_break_reg = (CH341_REG_LCR << 8) | CH341_REG_BREAK;
> struct usb_serial_port *port = tty->driver_data;
> struct ch341_private *priv = usb_get_serial_port_data(port);
> + u16 reg_contents;
> + u8 break_reg[2];
> int r;
> - uint16_t reg_contents;
> - uint8_t break_reg[2];
>
> if (priv->quirks & CH341_QUIRK_SIMULATE_BREAK)
> return ch341_simulate_break(tty, break_state);
> --
> 2.45.2
>
>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-08 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08 10:15 [PATCH] USB: serial: ch341: use fix-width types consistently Johan Hovold
2025-01-08 12:10 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox