From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Yicong Yang <yangyicong@hisilicon.com>,
James Clark <james.clark@linaro.org>,
Howard Chu <howardchu95@gmail.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Levi Yun <yeoreum.yun@arm.com>, Ze Gao <zegao2021@gmail.com>,
Weilin Wang <weilin.wang@intel.com>, Xu Yang <xu.yang_2@nxp.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 01/11] perf debug: Avoid stack overflow in recursive error message
Date: Wed, 8 Jan 2025 23:50:58 -0800 [thread overview]
Message-ID: <20250109075108.7651-2-irogers@google.com> (raw)
In-Reply-To: <20250109075108.7651-1-irogers@google.com>
In debug_file, pr_warning_once is called on error. As that function
calls debug_file the function will yield a stack overflow. Switch the
location of the call so the recursion is avoided.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c
index 995f6bb05b5f..f9ef7d045c92 100644
--- a/tools/perf/util/debug.c
+++ b/tools/perf/util/debug.c
@@ -46,8 +46,8 @@ int debug_type_profile;
FILE *debug_file(void)
{
if (!_debug_file) {
- pr_warning_once("debug_file not set");
debug_set_file(stderr);
+ pr_warning_once("debug_file not set");
}
return _debug_file;
}
--
2.47.1.613.gc27f4b7a9f-goog
next prev parent reply other threads:[~2025-01-09 7:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 7:50 [PATCH v1 00/11] Python improvements for a real use of parse_events Ian Rogers
2025-01-09 7:50 ` Ian Rogers [this message]
2025-02-27 5:40 ` [PATCH v1 01/11] perf debug: Avoid stack overflow in recursive error message Howard Chu
2025-02-27 5:45 ` Ian Rogers
2025-02-27 6:03 ` Howard Chu
2025-01-09 7:50 ` [PATCH v1 02/11] perf evlist: Add success path to evlist__create_syswide_maps Ian Rogers
2025-01-09 7:51 ` [PATCH v1 03/11] perf evsel: tp_format accessing improvements Ian Rogers
2025-02-27 5:43 ` Howard Chu
2025-01-09 7:51 ` [PATCH v1 04/11] perf python: Add evlist enable and disable methods Ian Rogers
2025-01-09 7:51 ` [PATCH v1 05/11] perf python: Add member access to a number of evsel variables Ian Rogers
2025-01-09 7:51 ` [PATCH v1 06/11] perf python: Add optional cpus and threads arguments to parse_events Ian Rogers
2025-01-09 7:51 ` [PATCH v1 07/11] perf python: Update ungrouped evsel leader in clone Ian Rogers
2025-01-09 7:51 ` [PATCH v1 08/11] perf python: Avoid duplicated code in get_tracepoint_field Ian Rogers
2025-01-09 7:51 ` [PATCH v1 09/11] perf python: Add evlist all_cpus accessor Ian Rogers
2025-01-09 7:51 ` [PATCH v1 10/11] perf python: Add evlist.config to set up record options Ian Rogers
2025-02-27 5:46 ` Howard Chu
2025-02-27 6:21 ` Ian Rogers
2025-01-09 7:51 ` [PATCH v1 11/11] perf python tracepoint: Switch to using parse_events Ian Rogers
2025-02-04 22:23 ` [PATCH v1 00/11] Python improvements for a real use of parse_events Ian Rogers
2025-02-10 16:06 ` Ian Rogers
2025-02-10 19:42 ` Namhyung Kim
[not found] ` <CA+JHD90PDGA-Zbu6hUZ1DZQbSD71FBPRbBdGd1dWCxhi3q6Q1g@mail.gmail.com>
2025-02-25 6:30 ` Ian Rogers
2025-02-27 5:52 ` Howard Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109075108.7651-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
--cc=yangyicong@hisilicon.com \
--cc=yeoreum.yun@arm.com \
--cc=zegao2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox