From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [RESEND PATCH] mux: constify mux class
Date: Fri, 10 Jan 2025 10:08:43 +0100 [thread overview]
Message-ID: <2025011034-premium-suitable-8618@gregkh> (raw)
In-Reply-To: <CAMRc=Mf+QH22j3YK6FdUdPz6E69BKBm4GSrri1UB0B061y-SAw@mail.gmail.com>
On Thu, Jan 02, 2025 at 10:21:51AM +0100, Bartosz Golaszewski wrote:
> On Thu, Dec 5, 2024 at 10:12 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Dec 05, 2024 at 09:56:05AM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > All class functions used here take a const pointer to the class
> > > structure so we can make the struct itself constant.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > ---
> > > Greg: Peter picked this up into his branch long before the v6.13 merge
> > > window, then never sent it upstream. Could you pick this up this time
> > > into your tree?
> > >
> > > drivers/mux/core.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mux/core.c b/drivers/mux/core.c
> > > index 78c0022697ec7..02be4ba372571 100644
> > > --- a/drivers/mux/core.c
> > > +++ b/drivers/mux/core.c
> > > @@ -42,7 +42,7 @@ struct mux_state {
> > > unsigned int state;
> > > };
> > >
> > > -static struct class mux_class = {
> > > +static const struct class mux_class = {
> > > .name = "mux",
> > > };
> > >
> > > --
> > > 2.45.2
> > >
> >
> > Sure, will do, thanks. I should sweep the tree for the remaining ones
> > as well...
> >
> > thanks,
> >
> > greg k-h
>
> Hi! Gentle ping because I'm not sure if this got lost or you're still
> getting to it in your queue.
Sorry for the delay, will get this now.
greg k-h
prev parent reply other threads:[~2025-01-10 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 8:56 [RESEND PATCH] mux: constify mux class Bartosz Golaszewski
2024-12-05 9:12 ` Greg Kroah-Hartman
2025-01-02 9:21 ` Bartosz Golaszewski
2025-01-10 9:08 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025011034-premium-suitable-8618@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox