[PATCH v2] VMCI: fix reference to ioctl-number.rst

[PATCH v2] VMCI: fix reference to ioctl-number.rst

[Alyssa Ross]

There has never been an ioctl-number.h — this must have been a typo
for ioctl-number.txt (which later become ioctl-number.rst).

At the time this comment was written, the note didn't actually end up
appearing anywhere, but I fixed the omission from ioctl-number.rst in
0a8e4dc1d353 ("Documentation: ioctl: document 0x07 ioctl code").

Fixes: 20259849bb1a ("VMCI: Some header and config files.")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
v2: added patch description.
v1: https://lore.kernel.org/lkml/20240731111302.3072858-2-hi@alyssa.is/

 include/linux/vmw_vmci_defs.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h
index 6fb663b36f72..244c5ff412e1 100644
--- a/include/linux/vmw_vmci_defs.h
+++ b/include/linux/vmw_vmci_defs.h
@@ -431,11 +431,11 @@ enum {
 	((((_p)[0] & 0xFF) << 24) | (((_p)[1] & 0xFF) << 16) | ((_p)[2]))
 
 /*
- * The VMCI IOCTLs.  We use identity code 7, as noted in ioctl-number.h, and
- * we start at sequence 9f.  This gives us the same values that our shipping
- * products use, starting at 1951, provided we leave out the direction and
- * structure size.  Note that VMMon occupies the block following us, starting
- * at 2001.
+ * The VMCI IOCTLs.  We use identity code 7, as noted in ioctl-number.rst,
+ * and we start at sequence 9f.  This gives us the same values that our
+ * shipping products use, starting at 1951, provided we leave out the
+ * direction and structure size.  Note that VMMon occupies the block
+ * following us, starting at 2001.
  */
 #define IOCTL_VMCI_VERSION			_IO(7, 0x9f)	/* 1951 */
 #define IOCTL_VMCI_INIT_CONTEXT			_IO(7, 0xa0)

base-commit: 11066801dd4b7c4d75fce65c812723a80c1481ae
-- 
2.46.0

[PATCH v2] VMCI: fix reference to ioctl-number.rst

[Alyssa Ross]

There has never been an ioctl-number.h — this must have been a typo
for ioctl-number.txt (which later become ioctl-number.rst).

At the time this comment was written, the note didn't actually end up
appearing anywhere, but I fixed the omission from ioctl-number.rst in
0a8e4dc1d353 ("Documentation: ioctl: document 0x07 ioctl code").

Fixes: 20259849bb1a ("VMCI: Some header and config files.")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
Greg, would you mind picking this one up too, since it seems there's no
active VMCI tree at the moment?

v2: added patch description.
    https://lore.kernel.org/lkml/20241102103052.7425-2-hi@alyssa.is/
v1: https://lore.kernel.org/lkml/20240731111302.3072858-2-hi@alyssa.is/

 include/linux/vmw_vmci_defs.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h
index 6fb663b36f72..244c5ff412e1 100644
--- a/include/linux/vmw_vmci_defs.h
+++ b/include/linux/vmw_vmci_defs.h
@@ -431,11 +431,11 @@ enum {
 	((((_p)[0] & 0xFF) << 24) | (((_p)[1] & 0xFF) << 16) | ((_p)[2]))

 /*
- * The VMCI IOCTLs.  We use identity code 7, as noted in ioctl-number.h, and
- * we start at sequence 9f.  This gives us the same values that our shipping
- * products use, starting at 1951, provided we leave out the direction and
- * structure size.  Note that VMMon occupies the block following us, starting
- * at 2001.
+ * The VMCI IOCTLs.  We use identity code 7, as noted in ioctl-number.rst,
+ * and we start at sequence 9f.  This gives us the same values that our
+ * shipping products use, starting at 1951, provided we leave out the
+ * direction and structure size.  Note that VMMon occupies the block
+ * following us, starting at 2001.
  */
 #define IOCTL_VMCI_VERSION			_IO(7, 0x9f)	/* 1951 */
 #define IOCTL_VMCI_INIT_CONTEXT			_IO(7, 0xa0)

base-commit: 11066801dd4b7c4d75fce65c812723a80c1481ae
--
2.46.0

Re: [PATCH v2] VMCI: fix reference to ioctl-number.rst

[Greg Kroah-Hartman]

On Thu, Jan 09, 2025 at 08:38:07PM +0100, Alyssa Ross wrote:
> There has never been an ioctl-number.h — this must have been a typo
> for ioctl-number.txt (which later become ioctl-number.rst).
> 
> At the time this comment was written, the note didn't actually end up
> appearing anywhere, but I fixed the omission from ioctl-number.rst in
> 0a8e4dc1d353 ("Documentation: ioctl: document 0x07 ioctl code").
> 
> Fixes: 20259849bb1a ("VMCI: Some header and config files.")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
> ---
> Greg, would you mind picking this one up too, since it seems there's no
> active VMCI tree at the moment?

No problem, now taken.

thanks,

greg k-h