From: Jiwei Sun <sjiwei@163.com>
To: macro@orcam.me.uk, ilpo.jarvinen@linux.intel.com, bhelgaas@google.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
helgaas@kernel.org, lukas@wunner.de, ahuang12@lenovo.com,
sunjw10@lenovo.com, jiwei.sun.bj@qq.com, sunjw10@outlook.com
Subject: [PATCH v2 2/2] PCI: reread the Link Control 2 Register before using
Date: Wed, 15 Jan 2025 21:41:54 +0800 [thread overview]
Message-ID: <20250115134154.9220-3-sjiwei@163.com> (raw)
In-Reply-To: <20250115134154.9220-1-sjiwei@163.com>
From: Jiwei Sun <sunjw10@lenovo.com>
Since commit de9a6c8d5dbf ("PCI/bwctrl: Add pcie_set_target_speed() to set
PCIe Link Speed"), the local variable "lnkctl2" is not changed after
reading from PCI_EXP_LNKCTL2 in the pcie_failed_link_retrain(). It might
cause that the removing 2.5GT/s downstream link speed restriction codes
are not executed.
Reread the Link Control 2 Register before using.
Fixes: de9a6c8d5dbf ("PCI/bwctrl: Add pcie_set_target_speed() to set PCIe Link Speed")
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Jiwei Sun <sunjw10@lenovo.com>
---
drivers/pci/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 76f4df75b08a..02d2e16672a8 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -123,6 +123,7 @@ int pcie_failed_link_retrain(struct pci_dev *dev)
return ret;
}
+ pcie_capability_read_word(dev, PCI_EXP_LNKCTL2, &lnkctl2);
pcie_capability_read_word(dev, PCI_EXP_LNKSTA, &lnksta);
}
--
2.34.1
next prev parent reply other threads:[~2025-01-15 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 13:41 [PATCH v2 0/2] PCI: Fix the wrong reading of register fields Jiwei Sun
2025-01-15 13:41 ` [PATCH v2 1/2] " Jiwei Sun
2025-01-16 13:52 ` Ilpo Järvinen
2025-01-15 13:41 ` Jiwei Sun [this message]
2025-01-16 14:12 ` [PATCH v2 2/2] PCI: reread the Link Control 2 Register before using Ilpo Järvinen
2025-01-16 15:00 ` Maciej W. Rozycki
2025-01-17 13:53 ` Jiwei Sun
2025-01-18 1:03 ` Maciej W. Rozycki
2025-01-20 14:19 ` Jiwei
2025-01-20 15:05 ` Maciej W. Rozycki
2025-01-20 15:20 ` Jiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115134154.9220-3-sjiwei@163.com \
--to=sjiwei@163.com \
--cc=ahuang12@lenovo.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jiwei.sun.bj@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=sunjw10@lenovo.com \
--cc=sunjw10@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox