* [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"
@ 2025-01-16 15:21 Andy Shevchenko
2025-01-16 15:24 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-01-16 15:21 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J. Wysocki, linux-pm, linux-kernel
Cc: Rafael J. Wysocki, Pavel Machek, Len Brown, Andy Shevchenko,
Adrian Hunter
The introduced macros are not doing what they intend for.
Also there were no users of them for all this time.
Drop them for good and to avoid possible misleading.
This reverts commit 41a337b40e983db4f0e1602308109f2b93687a06.
Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/pm.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/linux/pm.h b/include/linux/pm.h
index 08c37b83fea8..5dae93817141 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -384,12 +384,8 @@ const struct dev_pm_ops name = { \
#ifdef CONFIG_PM
#define _EXPORT_DEV_PM_OPS(name, license, ns) _EXPORT_PM_OPS(name, license, ns)
-#define EXPORT_PM_FN_GPL(name) EXPORT_SYMBOL_GPL(name)
-#define EXPORT_PM_FN_NS_GPL(name, ns) EXPORT_SYMBOL_NS_GPL(name, "ns")
#else
#define _EXPORT_DEV_PM_OPS(name, license, ns) _DISCARD_PM_OPS(name, license, ns)
-#define EXPORT_PM_FN_GPL(name)
-#define EXPORT_PM_FN_NS_GPL(name, ns)
#endif
#ifdef CONFIG_PM_SLEEP
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"
2025-01-16 15:21 [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions" Andy Shevchenko
@ 2025-01-16 15:24 ` Greg Kroah-Hartman
2025-01-16 15:32 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2025-01-16 15:24 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafael J. Wysocki, linux-pm, linux-kernel, Rafael J. Wysocki,
Pavel Machek, Len Brown, Adrian Hunter
On Thu, Jan 16, 2025 at 05:21:51PM +0200, Andy Shevchenko wrote:
> The introduced macros are not doing what they intend for.
> Also there were no users of them for all this time.
> Drop them for good and to avoid possible misleading.
>
> This reverts commit 41a337b40e983db4f0e1602308109f2b93687a06.
>
> Reported-by: Adrian Hunter <adrian.hunter@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/pm.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index 08c37b83fea8..5dae93817141 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -384,12 +384,8 @@ const struct dev_pm_ops name = { \
>
> #ifdef CONFIG_PM
> #define _EXPORT_DEV_PM_OPS(name, license, ns) _EXPORT_PM_OPS(name, license, ns)
> -#define EXPORT_PM_FN_GPL(name) EXPORT_SYMBOL_GPL(name)
> -#define EXPORT_PM_FN_NS_GPL(name, ns) EXPORT_SYMBOL_NS_GPL(name, "ns")
> #else
> #define _EXPORT_DEV_PM_OPS(name, license, ns) _DISCARD_PM_OPS(name, license, ns)
> -#define EXPORT_PM_FN_GPL(name)
> -#define EXPORT_PM_FN_NS_GPL(name, ns)
Why not start using them instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"
2025-01-16 15:24 ` Greg Kroah-Hartman
@ 2025-01-16 15:32 ` Andy Shevchenko
2025-01-16 15:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2025-01-16 15:32 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Rafael J. Wysocki, linux-pm, linux-kernel, Rafael J. Wysocki,
Pavel Machek, Len Brown, Adrian Hunter
On Thu, Jan 16, 2025 at 04:24:16PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Jan 16, 2025 at 05:21:51PM +0200, Andy Shevchenko wrote:
...
> > #ifdef CONFIG_PM
> > #define _EXPORT_DEV_PM_OPS(name, license, ns) _EXPORT_PM_OPS(name, license, ns)
> > -#define EXPORT_PM_FN_GPL(name) EXPORT_SYMBOL_GPL(name)
> > -#define EXPORT_PM_FN_NS_GPL(name, ns) EXPORT_SYMBOL_NS_GPL(name, "ns")
> > #else
> > #define _EXPORT_DEV_PM_OPS(name, license, ns) _DISCARD_PM_OPS(name, license, ns)
> > -#define EXPORT_PM_FN_GPL(name)
> > -#define EXPORT_PM_FN_NS_GPL(name, ns)
>
> Why not start using them instead?
I tried and they didn't produce what we want (code elimination for
the CONFIG_PM=n).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions"
2025-01-16 15:32 ` Andy Shevchenko
@ 2025-01-16 15:39 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2025-01-16 15:39 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafael J. Wysocki, linux-pm, linux-kernel, Rafael J. Wysocki,
Pavel Machek, Len Brown, Adrian Hunter
On Thu, Jan 16, 2025 at 05:32:23PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 16, 2025 at 04:24:16PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Jan 16, 2025 at 05:21:51PM +0200, Andy Shevchenko wrote:
>
> ...
>
> > > #ifdef CONFIG_PM
> > > #define _EXPORT_DEV_PM_OPS(name, license, ns) _EXPORT_PM_OPS(name, license, ns)
> > > -#define EXPORT_PM_FN_GPL(name) EXPORT_SYMBOL_GPL(name)
> > > -#define EXPORT_PM_FN_NS_GPL(name, ns) EXPORT_SYMBOL_NS_GPL(name, "ns")
> > > #else
> > > #define _EXPORT_DEV_PM_OPS(name, license, ns) _DISCARD_PM_OPS(name, license, ns)
> > > -#define EXPORT_PM_FN_GPL(name)
> > > -#define EXPORT_PM_FN_NS_GPL(name, ns)
> >
> > Why not start using them instead?
>
> I tried and they didn't produce what we want (code elimination for
> the CONFIG_PM=n).
Ok, then please say that in the changelog text.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-16 15:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-16 15:21 [PATCH v1 1/1] PM: Revert "Add EXPORT macros for exporting PM functions" Andy Shevchenko
2025-01-16 15:24 ` Greg Kroah-Hartman
2025-01-16 15:32 ` Andy Shevchenko
2025-01-16 15:39 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox