* [PATCH 0/2] SPMI patches for the merge window
@ 2025-01-16 23:53 Stephen Boyd
2025-01-16 23:53 ` [PATCH 1/2] spmi: Set fwnode for spmi devices Stephen Boyd
2025-01-16 23:53 ` [PATCH 2/2] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe() Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2025-01-16 23:53 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, patches
We have two very small patches this time around, both about firmware
nodes. One plugs a leak and the other sets the fwnode properly for SPMI
devices.
Joe Hattori (1):
spmi: hisi-spmi-controller: Drop duplicated OF node assignment in
spmi_controller_probe()
Saravana Kannan (1):
spmi: Set fwnode for spmi devices
drivers/spmi/hisi-spmi-controller.c | 3 ---
drivers/spmi/spmi.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] spmi: Set fwnode for spmi devices
2025-01-16 23:53 [PATCH 0/2] SPMI patches for the merge window Stephen Boyd
@ 2025-01-16 23:53 ` Stephen Boyd
2025-01-16 23:53 ` [PATCH 2/2] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe() Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2025-01-16 23:53 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Saravana Kannan, linux-kernel, patches
From: Saravana Kannan <saravanak@google.com>
This allows fw_devlink to do proper dependency tracking for SPMI
devices. So, better deferred probe handling, async probing, async
suspend/resume, etc.
Signed-off-by: Saravana Kannan <saravanak@google.com>
Link: https://lore.kernel.org/r/20241115230509.1793191-1-saravanak@google.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
drivers/spmi/spmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index fb0101da1485..3cf8d9bd4566 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -517,7 +517,7 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
if (!sdev)
continue;
- sdev->dev.of_node = node;
+ device_set_node(&sdev->dev, of_fwnode_handle(node));
sdev->usid = (u8)reg[0];
err = spmi_device_add(sdev);
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe()
2025-01-16 23:53 [PATCH 0/2] SPMI patches for the merge window Stephen Boyd
2025-01-16 23:53 ` [PATCH 1/2] spmi: Set fwnode for spmi devices Stephen Boyd
@ 2025-01-16 23:53 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2025-01-16 23:53 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Joe Hattori, linux-kernel, patches
From: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
spmi_controller_probe() assigns a parent device and an OF node to an
SPMI controller. However, the operations are not needed as they are
already assigned in spmi_controller_alloc(). Thus, remove the duplicated
assignments. An unnecessary OF node reference acquisition is also
dropped by this patch.
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20250116044907.2947218-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
drivers/spmi/hisi-spmi-controller.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index 3cafdf22c909..122140b97579 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev)
spin_lock_init(&spmi_controller->lock);
- ctrl->dev.parent = pdev->dev.parent;
- ctrl->dev.of_node = of_node_get(pdev->dev.of_node);
-
/* Callbacks */
ctrl->read_cmd = spmi_read_cmd;
ctrl->write_cmd = spmi_write_cmd;
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-16 23:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-16 23:53 [PATCH 0/2] SPMI patches for the merge window Stephen Boyd
2025-01-16 23:53 ` [PATCH 1/2] spmi: Set fwnode for spmi devices Stephen Boyd
2025-01-16 23:53 ` [PATCH 2/2] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe() Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox