* [PATCH] scsi: mvsas: remove unused mvs_phys_reset
@ 2025-01-27 0:26 linux
2025-02-03 22:56 ` Martin K. Petersen
2025-02-10 2:58 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2025-01-27 0:26 UTC (permalink / raw)
To: James.Bottomley, martin.petersen
Cc: linux-scsi, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
mvs_phys_reset() was added in 2009's
commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change;
bug fixes")
but hasn't been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/scsi/mvsas/mv_sas.c | 10 ----------
drivers/scsi/mvsas/mv_sas.h | 1 -
2 files changed, 11 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 1444b1f1c4c8..c4592de4fefc 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -151,16 +151,6 @@ static inline u8 mvs_assign_reg_set(struct mvs_info *mvi,
return MVS_CHIP_DISP->assign_reg_set(mvi, &dev->taskfileset);
}
-void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard)
-{
- u32 no;
- for_each_phy(phy_mask, phy_mask, no) {
- if (!(phy_mask & 1))
- continue;
- MVS_CHIP_DISP->phy_reset(mvi, no, hard);
- }
-}
-
int mvs_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
void *funcdata)
{
diff --git a/drivers/scsi/mvsas/mv_sas.h b/drivers/scsi/mvsas/mv_sas.h
index 19b01f7c4767..09ce3f2241f2 100644
--- a/drivers/scsi/mvsas/mv_sas.h
+++ b/drivers/scsi/mvsas/mv_sas.h
@@ -425,7 +425,6 @@ struct mvs_task_exec_info {
void mvs_get_sas_addr(void *buf, u32 buflen);
void mvs_iounmap(void __iomem *regs);
int mvs_ioremap(struct mvs_info *mvi, int bar, int bar_ex);
-void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard);
int mvs_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func,
void *funcdata);
void mvs_set_sas_addr(struct mvs_info *mvi, int port_id, u32 off_lo,
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: mvsas: remove unused mvs_phys_reset
2025-01-27 0:26 [PATCH] scsi: mvsas: remove unused mvs_phys_reset linux
@ 2025-02-03 22:56 ` Martin K. Petersen
2025-02-10 2:58 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-02-03 22:56 UTC (permalink / raw)
To: linux; +Cc: James.Bottomley, martin.petersen, linux-scsi, linux-kernel
> mvs_phys_reset() was added in 2009's
> commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change;
> bug fixes")
> but hasn't been used.
Applied to 6.15/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: mvsas: remove unused mvs_phys_reset
2025-01-27 0:26 [PATCH] scsi: mvsas: remove unused mvs_phys_reset linux
2025-02-03 22:56 ` Martin K. Petersen
@ 2025-02-10 2:58 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-02-10 2:58 UTC (permalink / raw)
To: James.Bottomley, linux; +Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Mon, 27 Jan 2025 00:26:01 +0000, linux@treblig.org wrote:
> mvs_phys_reset() was added in 2009's
> commit 20b09c2992fe ("[SCSI] mvsas: add support for 94xx; layout change;
> bug fixes")
> but hasn't been used.
>
> Remove it.
>
> [...]
Applied to 6.15/scsi-queue, thanks!
[1/1] scsi: mvsas: remove unused mvs_phys_reset
https://git.kernel.org/mkp/scsi/c/a307d6ec1239
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-10 2:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-27 0:26 [PATCH] scsi: mvsas: remove unused mvs_phys_reset linux
2025-02-03 22:56 ` Martin K. Petersen
2025-02-10 2:58 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox