public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shyam Saini <shyamsaini@linux.microsoft.com>
To: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Cc: code@tyhicks.com, linux@rasmusvillemoes.dk, mcgrof@kernel.org,
	frkaya@linux.microsoft.com, vijayb@linux.microsoft.com,
	petr.pavlu@suse.com, linux@weissschuh.net,
	samitolvanen@google.com, da.gomez@samsung.com,
	gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org
Subject: [v1 1/3] kernel: param: rename locate_module_kobject
Date: Mon,  3 Feb 2025 21:22:20 -0800	[thread overview]
Message-ID: <20250204052222.1611510-2-shyamsaini@linux.microsoft.com> (raw)
In-Reply-To: <20250204052222.1611510-1-shyamsaini@linux.microsoft.com>

locate_module_kobject() look up for existing module_kobject
For given module name locate_module_kobject() look up for
corresponding module_kobject if it exists. If it coudln't
find its corresponding module_kobject then it creates one
for the given name.
Rename locate_module_kobject() to lookup_or_create_module_kobject(),
to better describe its operations.

This doesn't change anything functionality wise.

Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Shyam Saini <shyamsaini@linux.microsoft.com>
---
 kernel/params.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index 0074d29c9b80..4b43baaf7c83 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -763,7 +763,7 @@ void destroy_params(const struct kernel_param *params, unsigned num)
 			params[i].ops->free(params[i].arg);
 }
 
-static struct module_kobject * __init locate_module_kobject(const char *name)
+static struct module_kobject * __init lookup_or_create_module_kobject(const char *name)
 {
 	struct module_kobject *mk;
 	struct kobject *kobj;
@@ -805,10 +805,9 @@ static void __init kernel_add_sysfs_param(const char *name,
 	struct module_kobject *mk;
 	int err;
 
-	mk = locate_module_kobject(name);
+	mk = lookup_or_create_module_kobject(name);
 	if (!mk)
 		return;
-
 	/* We need to remove old parameters before adding more. */
 	if (mk->mp)
 		sysfs_remove_group(&mk->kobj, &mk->mp->grp);
@@ -876,7 +875,7 @@ static void __init version_sysfs_builtin(void)
 	int err;
 
 	for (vattr = __start___modver; vattr < __stop___modver; vattr++) {
-		mk = locate_module_kobject(vattr->module_name);
+		mk = lookup_or_create_module_kobject(vattr->module_name);
 		if (mk) {
 			err = sysfs_create_file(&mk->kobj, &vattr->mattr.attr);
 			WARN_ON_ONCE(err);
-- 
2.34.1


  reply	other threads:[~2025-02-04  5:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04  5:22 [v1 0/3] Properly handle module_kboject creation Shyam Saini
2025-02-04  5:22 ` Shyam Saini [this message]
2025-02-04  5:22 ` [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h Shyam Saini
2025-02-04  5:27   ` Christoph Hellwig
2025-02-04  9:28   ` Christophe Leroy
2025-02-05  8:43   ` Rasmus Villemoes
2025-02-07  5:43     ` Shyam Saini
2025-02-04  5:22 ` [v1 3/3] drivers: base: handle module_kboject creation Shyam Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250204052222.1611510-2-shyamsaini@linux.microsoft.com \
    --to=shyamsaini@linux.microsoft.com \
    --cc=code@tyhicks.com \
    --cc=da.gomez@samsung.com \
    --cc=dakr@kernel.org \
    --cc=frkaya@linux.microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=linux@weissschuh.net \
    --cc=mcgrof@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=rafael@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=vijayb@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox