From: Christoph Hellwig <hch@infradead.org>
To: Shyam Saini <shyamsaini@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
code@tyhicks.com, linux@rasmusvillemoes.dk, mcgrof@kernel.org,
frkaya@linux.microsoft.com, vijayb@linux.microsoft.com,
petr.pavlu@suse.com, linux@weissschuh.net,
samitolvanen@google.com, da.gomez@samsung.com,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org
Subject: Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h
Date: Mon, 3 Feb 2025 21:27:50 -0800 [thread overview]
Message-ID: <Z6GlVpuR8MaR4XLN@infradead.org> (raw)
In-Reply-To: <20250204052222.1611510-3-shyamsaini@linux.microsoft.com>
> +static inline struct module_kobject * __init lookup_or_create_module_kobject(const char *name)
Crazily unreadable line.
Either way this is not a function that should be inline in a header.
Both due to sheer size, but also due to what it does and what it pulls
in.
> +{
> + struct module_kobject *mk;
> + struct kobject *kobj;
> + int err;
> +
> + kobj = kset_find_obj(module_kset, name);
> + if (kobj) {
> + mk = to_module_kobject(kobj);
> + } else {
And I know this is just moving the code, but an ealy return here
would significanty clean up the function..
> + mk = kzalloc(sizeof(struct module_kobject), GFP_KERNEL);
> + BUG_ON(!mk);
.. and a BUG_ON on allocation failure is a no-go.
next prev parent reply other threads:[~2025-02-04 5:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 5:22 [v1 0/3] Properly handle module_kboject creation Shyam Saini
2025-02-04 5:22 ` [v1 1/3] kernel: param: rename locate_module_kobject Shyam Saini
2025-02-04 5:22 ` [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h Shyam Saini
2025-02-04 5:27 ` Christoph Hellwig [this message]
2025-02-04 9:28 ` Christophe Leroy
2025-02-05 8:43 ` Rasmus Villemoes
2025-02-07 5:43 ` Shyam Saini
2025-02-04 5:22 ` [v1 3/3] drivers: base: handle module_kboject creation Shyam Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6GlVpuR8MaR4XLN@infradead.org \
--to=hch@infradead.org \
--cc=code@tyhicks.com \
--cc=da.gomez@samsung.com \
--cc=dakr@kernel.org \
--cc=frkaya@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rafael@kernel.org \
--cc=samitolvanen@google.com \
--cc=shyamsaini@linux.microsoft.com \
--cc=vijayb@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox