[PATCH] dt-bindings: iio: light: fix missing type definition

[PATCH] dt-bindings: iio: light: fix missing type definition

[Dharma Balasubiramani]

Add the missing type definition for ps-cancellation-current-picoamp property.

Fixes: 47736b32d1b8 ("dt-bindings: iio: light: Add APDS9160 binding")
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
 Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
index bb1cc4404a55..f9c35c29fe04 100644
--- a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
+++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
@@ -37,6 +37,7 @@ properties:
     maximum: 63
 
   ps-cancellation-current-picoamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
     description:
       Proximity sensor crosstalk cancellation current in picoampere.
       This parameter adjusts the current in steps of 2400 pA up to 276000 pA.

---
base-commit: 40b8e93e17bff4a4e0cc129e04f9fdf5daa5397e
change-id: 20250205-brcm-binding-71b6d990d67e

Best regards,
-- 
Dharma Balasubiramani <dharma.b@microchip.com>

Re: [PATCH] dt-bindings: iio: light: fix missing type definition

[Krzysztof Kozlowski]

On Wed, Feb 05, 2025 at 09:48:45AM +0530, Dharma Balasubiramani wrote:
> Add the missing type definition for ps-cancellation-current-picoamp property.

It is not missing. You are using some older schema probably.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: iio: light: fix missing type definition

[Dharma.B]

On 05/02/25 5:07 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Feb 05, 2025 at 09:48:45AM +0530, Dharma Balasubiramani wrote:
>> Add the missing type definition for ps-cancellation-current-picoamp property.
> 
> It is not missing. You are using some older schema probably.

Sorry, if I miss something here..

There is no $Ref or type for ps-cancellation-current-picoamp property

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml#n39

I checked in other bindings as well.

I get the following warning while make dtbs_check or dt_binding_check

Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: 
ps-cancellation-current-picoamp: missing type definition

Should I need to update anything?

> 
> Best regards,
> Krzysztof
> 


-- 
With Best Regards,
Dharma B.

Re: [PATCH] dt-bindings: iio: light: fix missing type definition

[Krzysztof Kozlowski]

On 06/02/2025 03:41, Dharma.B@microchip.com wrote:
> On 05/02/25 5:07 pm, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On Wed, Feb 05, 2025 at 09:48:45AM +0530, Dharma Balasubiramani wrote:
>>> Add the missing type definition for ps-cancellation-current-picoamp property.
>>
>> It is not missing. You are using some older schema probably.
> 
> Sorry, if I miss something here..
> 
> There is no $Ref or type for ps-cancellation-current-picoamp property

There is a ref in dtschema.

> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml#n39
> 
> I checked in other bindings as well.
> 
> I get the following warning while make dtbs_check or dt_binding_check
> 
> Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: 
> ps-cancellation-current-picoamp: missing type definition
> 
> Should I need to update anything?

As I said - older schema, so yes, you need to update your dtschema or
wait for new release.

Best regards,
Krzysztof