From: Ian Rogers <irogers@google.com>
To: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Weilin Wang" <weilin.wang@intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
"Perry Taylor" <perry.taylor@intel.com>,
"Samantha Alt" <samantha.alt@intel.com>,
"Caleb Biggers" <caleb.biggers@intel.com>,
"Edward Baker" <edward.baker@intel.com>,
"Michael Petlan" <mpetlan@redhat.com>,
"Thomas Falcon" <thomas.falcon@intel.com>
Subject: [PATCH v5 24/24] perf test stat_all_metrics: Ensure missing events fail test
Date: Wed, 5 Feb 2025 09:31:40 -0800 [thread overview]
Message-ID: <20250205173140.238294-25-irogers@google.com> (raw)
In-Reply-To: <20250205173140.238294-1-irogers@google.com>
Issue reported by Thomas Falcon and diagnosed by Kan Liang here:
https://lore.kernel.org/lkml/d44036481022c27d83ce0faf8c7f77042baedb34.camel@intel.com/
Metrics with missing events can be erroneously skipped if they contain
FP, AMX or PMM events.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/stat_all_metrics.sh | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/stat_all_metrics.sh b/tools/perf/tests/shell/stat_all_metrics.sh
index 73e9347e88a9..ee817c66da06 100755
--- a/tools/perf/tests/shell/stat_all_metrics.sh
+++ b/tools/perf/tests/shell/stat_all_metrics.sh
@@ -20,7 +20,13 @@ for m in $(perf list --raw-dump metrics); do
result_err=$?
if [[ $result_err -gt 0 ]]
then
- if [[ "$result" =~ \
+ if [[ "$result" =~ "Cannot resolve IDs for" ]]
+ then
+ echo "Metric contains missing events"
+ echo $result
+ err=1 # Fail
+ continue
+ elif [[ "$result" =~ \
"Access to performance monitoring and observability operations is limited" ]]
then
echo "Permission failure"
--
2.48.1.362.g079036d154-goog
next prev parent reply other threads:[~2025-02-05 17:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 17:31 [PATCH v5 00/24] Intel vendor events and TMA 5.01 metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 01/24] perf vendor events: Update Alderlake events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 02/24] perf vendor events: Update AlderlakeN events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 03/24] perf vendor events: Add Arrowlake events/metrics Ian Rogers
2025-02-05 19:08 ` Liang, Kan
2025-02-05 17:31 ` [PATCH v5 04/24] perf vendor events: Update Broadwell events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 05/24] perf vendor events: Update BroadwellDE events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 06/24] perf vendor events: Update BroadwellX events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 07/24] perf vendor events: Update CascadelakeX events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 08/24] perf vendor events: Add Clearwaterforest events Ian Rogers
2025-02-05 17:31 ` [PATCH v5 09/24] perf vendor events: Update EmeraldRapids events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 10/24] perf vendor events: Update GrandRidge events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 11/24] perf vendor events: Update/add Graniterapids events/metrics Ian Rogers
2025-02-05 19:11 ` Liang, Kan
2025-02-05 20:23 ` Ian Rogers
2025-02-05 21:10 ` Liang, Kan
2025-02-05 21:33 ` Ian Rogers
2025-02-06 14:32 ` Liang, Kan
2025-02-06 16:40 ` Ian Rogers
2025-02-06 17:11 ` Liang, Kan
[not found] ` <CAP-5=fWQj01O3WmGLoAf6O_uEeMHpOUqVWvHi3nW_kGj4VtZWg@mail.gmail.com>
2025-02-06 18:53 ` Liang, Kan
2025-02-06 18:59 ` Liang, Kan
2025-02-06 19:05 ` Ian Rogers
2025-02-06 19:53 ` Liang, Kan
2025-02-07 17:39 ` Ian Rogers
2025-02-05 17:31 ` [PATCH v5 12/24] perf vendor events: Update Haswell events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 13/24] perf vendor events: Update HaswellX events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 14/24] perf vendor events: Update Icelake events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 15/24] perf vendor events: Update IcelakeX events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 16/24] perf vendor events: Update/add Lunarlake events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 17/24] perf vendor events: Update Meteorlake events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 18/24] perf vendor events: Update Rocketlake events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 19/24] perf vendor events: Update Sapphirerapids events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 20/24] perf vendor events: Update Sierraforest events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 21/24] perf vendor events: Update Skylake metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 22/24] perf vendor events: Update SkylakeX events/metrics Ian Rogers
2025-02-05 17:31 ` [PATCH v5 23/24] perf vendor events: Update Tigerlake events/metrics Ian Rogers
2025-02-05 17:31 ` Ian Rogers [this message]
2025-02-05 19:44 ` [PATCH v5 00/24] Intel vendor events and TMA 5.01 metrics Falcon, Thomas
2025-02-05 20:47 ` Ian Rogers
2025-02-06 20:33 ` Falcon, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205173140.238294-25-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=afaerber@suse.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=edward.baker@intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=samantha.alt@intel.com \
--cc=thomas.falcon@intel.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox