public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Quinlan <james.quinlan@broadcom.com>
To: linux-pci@vger.kernel.org,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Cyril Brulebois <kibi@debian.org>,
	Stanimir Varbanov <svarbanov@suse.de>,
	bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com,
	james.quinlan@broadcom.com
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM
	BCM2711/BCM2835 ARM ARCHITECTURE),
	linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
	BCM2711/BCM2835 ARM ARCHITECTURE),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v1 3/6] PCI: brcmstb: Fix potential premature regluator disabling
Date: Wed,  5 Feb 2025 14:12:03 -0500	[thread overview]
Message-ID: <20250205191213.29202-4-james.quinlan@broadcom.com> (raw)
In-Reply-To: <20250205191213.29202-1-james.quinlan@broadcom.com>

Our system for enabling and disabling regulators is designed to work
only on the port driver below the root complex.  The conditions to
discriminate for this case should be the same when we are adding or
removing the bus.  Without this change the regulators may be disabled
prematurely when a bus further down the tree is removed.

Fixes: 9e6be018b263 ("PCI: brcmstb: Enable child bus device regulators from DT")
Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
---
 drivers/pci/controller/pcie-brcmstb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index bf919467cbcd..4f5d751cbdd7 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -1441,7 +1441,7 @@ static void brcm_pcie_remove_bus(struct pci_bus *bus)
 	struct subdev_regulators *sr = pcie->sr;
 	struct device *dev = &bus->dev;
 
-	if (!sr)
+	if (!sr || !bus->parent || !pci_is_root_bus(bus->parent))
 		return;
 
 	if (regulator_bulk_disable(sr->num_supplies, sr->supplies))
-- 
2.43.0


  parent reply	other threads:[~2025-02-05 19:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 19:12 [PATCH v1 0/6] PCI: brcmstb: Misc small tweaks and fixes Jim Quinlan
2025-02-05 19:12 ` [PATCH v1 1/6] PCI: brcmstb: Refactor max speed limit functionality Jim Quinlan
2025-02-06 17:04   ` Bjorn Helgaas
2025-02-06 18:27     ` Jim Quinlan
2025-02-06 20:18       ` Bjorn Helgaas
2025-02-05 19:12 ` [PATCH v1 2/6] PCI: brcmstb: Fix error path upon call of regulator_bulk_get() Jim Quinlan
2025-02-06 17:29   ` Bjorn Helgaas
2025-02-06 18:22     ` Jim Quinlan
2025-02-06 18:34       ` Bjorn Helgaas
2025-02-06 19:39         ` Jim Quinlan
2025-02-05 19:12 ` Jim Quinlan [this message]
2025-02-06 17:32   ` [PATCH v1 3/6] PCI: brcmstb: Fix potential premature regluator disabling Bjorn Helgaas
2025-02-06 17:57     ` Jim Quinlan
2025-02-05 19:12 ` [PATCH v1 4/6] PCI: brcmstb: Use same constant table for config space access Jim Quinlan
2025-02-05 19:12 ` [PATCH v1 5/6] PCI: brcmstb: Make two changes in MDIO register fields Jim Quinlan
2025-02-05 19:12 ` [PATCH v1 6/6] PCI: brcmstb: Cast an int variable to an irq_hw_number_t Jim Quinlan
2025-02-06 22:19   ` Stefan Wahren
2025-02-14 16:17     ` Jim Quinlan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250205191213.29202-4-james.quinlan@broadcom.com \
    --to=james.quinlan@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=jim2101024@gmail.com \
    --cc=kibi@debian.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=nsaenz@kernel.org \
    --cc=robh@kernel.org \
    --cc=svarbanov@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox