* [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization
@ 2025-02-11 6:20 Li Ming
2025-02-11 9:28 ` Jonathan Cameron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Li Ming @ 2025-02-11 6:20 UTC (permalink / raw)
To: dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel, Li Ming
gp_port is already pointed to the grandparent port during its definition,
remove a redundant code to let gp_port point to the grandparent port
again.
Signed-off-by: Li Ming <ming.li@zohomail.com>
---
drivers/cxl/core/cdat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
index 8153f8d83a16..c656c1346aa0 100644
--- a/drivers/cxl/core/cdat.c
+++ b/drivers/cxl/core/cdat.c
@@ -651,7 +651,6 @@ static int cxl_endpoint_gather_bandwidth(struct cxl_region *cxlr,
if (IS_ERR(perf))
return PTR_ERR(perf);
- gp_port = to_cxl_port(parent_port->dev.parent);
*gp_is_root = is_cxl_root(gp_port);
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization
2025-02-11 6:20 [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization Li Ming
@ 2025-02-11 9:28 ` Jonathan Cameron
2025-02-11 16:25 ` Davidlohr Bueso
2025-02-11 16:38 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2025-02-11 9:28 UTC (permalink / raw)
To: Li Ming
Cc: dave, dave.jiang, alison.schofield, vishal.l.verma, ira.weiny,
dan.j.williams, linux-cxl, linux-kernel
On Tue, 11 Feb 2025 14:20:54 +0800
Li Ming <ming.li@zohomail.com> wrote:
> gp_port is already pointed to the grandparent port during its definition,
> remove a redundant code to let gp_port point to the grandparent port
> again.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index 8153f8d83a16..c656c1346aa0 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -651,7 +651,6 @@ static int cxl_endpoint_gather_bandwidth(struct cxl_region *cxlr,
> if (IS_ERR(perf))
> return PTR_ERR(perf);
>
> - gp_port = to_cxl_port(parent_port->dev.parent);
> *gp_is_root = is_cxl_root(gp_port);
>
> /*
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization
2025-02-11 6:20 [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization Li Ming
2025-02-11 9:28 ` Jonathan Cameron
@ 2025-02-11 16:25 ` Davidlohr Bueso
2025-02-11 16:38 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2025-02-11 16:25 UTC (permalink / raw)
To: Li Ming
Cc: jonathan.cameron, dave.jiang, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams, linux-cxl, linux-kernel
On Tue, 11 Feb 2025, Li Ming wrote:
>gp_port is already pointed to the grandparent port during its definition,
>remove a redundant code to let gp_port point to the grandparent port
>again.
>
>Signed-off-by: Li Ming <ming.li@zohomail.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization
2025-02-11 6:20 [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization Li Ming
2025-02-11 9:28 ` Jonathan Cameron
2025-02-11 16:25 ` Davidlohr Bueso
@ 2025-02-11 16:38 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2025-02-11 16:38 UTC (permalink / raw)
To: Li Ming, dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel
On 2/10/25 11:20 PM, Li Ming wrote:
> gp_port is already pointed to the grandparent port during its definition,
> remove a redundant code to let gp_port point to the grandparent port
> again.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Thanks! Applied to cxl/next
> ---
> drivers/cxl/core/cdat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index 8153f8d83a16..c656c1346aa0 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -651,7 +651,6 @@ static int cxl_endpoint_gather_bandwidth(struct cxl_region *cxlr,
> if (IS_ERR(perf))
> return PTR_ERR(perf);
>
> - gp_port = to_cxl_port(parent_port->dev.parent);
> *gp_is_root = is_cxl_root(gp_port);
>
> /*
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-11 16:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-11 6:20 [PATCH v1 1/1] cxl/cdat: Remove redundant gp_port initialization Li Ming
2025-02-11 9:28 ` Jonathan Cameron
2025-02-11 16:25 ` Davidlohr Bueso
2025-02-11 16:38 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox