public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/5] intel_th: Fixes for v6.14
@ 2025-02-11 18:50 Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 1/5] intel_th: msu: Fix kernel-doc warnings Alexander Shishkin
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Alexander Shishkin @ 2025-02-11 18:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, Alexander Shishkin

Hi Greg,

Here are 5 patches that I'd like to get into this cycle; 3 are new PCI
IDs and 2 are kernel-doc warning fixes. Please take a look and consider
applying.

Alexander Shishkin (3):
  intel_th: msu: Fix less trivial kernel-doc warnings
  intel_th: pci: Add Panther Lake-H support
  intel_th: pci: Add Panther Lake-P/U support

Andy Shevchenko (1):
  intel_th: msu: Fix kernel-doc warnings

Pawel Chmielewski (1):
  intel_th: pci: Add Arrow Lake support

 drivers/hwtracing/intel_th/msu.c | 13 +++++++++++--
 drivers/hwtracing/intel_th/pci.c | 15 +++++++++++++++
 2 files changed, 26 insertions(+), 2 deletions(-)

-- 
2.47.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/5] intel_th: msu: Fix kernel-doc warnings
  2025-02-11 18:50 [PATCH 0/5] intel_th: Fixes for v6.14 Alexander Shishkin
@ 2025-02-11 18:50 ` Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 2/5] intel_th: msu: Fix less trivial " Alexander Shishkin
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2025-02-11 18:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, Andy Shevchenko, Alexander Shishkin

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Correct function comments to prevent kernel-doc warnings
found when using "W=1".

msu.c:162: warning: Function parameter or struct member 'mbuf_priv' not described in 'msc'
msu.c:164: warning: Function parameter or struct member 'orig_addr' not described in 'msc'
msu.c:164: warning: Function parameter or struct member 'orig_sz' not described in 'msc'

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/intel_th/msu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index 66123d684ac9..492d8eba37eb 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -108,7 +108,7 @@ struct msc_iter {
  * @reg_base:		register window base address
  * @thdev:		intel_th_device pointer
  * @mbuf:		MSU buffer, if assigned
- * @mbuf_priv		MSU buffer's private data, if @mbuf
+ * @mbuf_priv:		MSU buffer's private data, if @mbuf
  * @win_list:		list of windows in multiblock mode
  * @single_sgt:		single mode buffer
  * @cur_win:		current window
@@ -117,6 +117,8 @@ struct msc_iter {
  * @single_wrap:	single mode wrap occurred
  * @base:		buffer's base pointer
  * @base_addr:		buffer's base address
+ * @orig_addr:		MSC0 buffer's base address
+ * @orig_sz:		MSC0 buffer's size
  * @user_count:		number of users of the buffer
  * @mmap_count:		number of mappings
  * @buf_mutex:		mutex to serialize access to buffer-related bits
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/5] intel_th: msu: Fix less trivial kernel-doc warnings
  2025-02-11 18:50 [PATCH 0/5] intel_th: Fixes for v6.14 Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 1/5] intel_th: msu: Fix kernel-doc warnings Alexander Shishkin
@ 2025-02-11 18:50 ` Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 3/5] intel_th: pci: Add Arrow Lake support Alexander Shishkin
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2025-02-11 18:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, Alexander Shishkin, Andy Shevchenko

Correct function comments to prevent kernel-doc warnings found when using
"W=1" that the drive-by fixers had trouble documenting and skipped over.

msu.c:168: warning: Function parameter or struct member 'msu_base' not described in 'msc'
msu.c:168: warning: Function parameter or struct member 'work' not described in 'msc'
msu.c:168: warning: Function parameter or struct member 'switch_on_unlock' not described in 'msc'
msu.c:168: warning: Function parameter or struct member 'iter_list' not described in 'msc'
msu.c:168: warning: Function parameter or struct member 'stop_on_full' not described in 'msc'
msu.c:168: warning: Function parameter or struct member 'do_irq' not described in 'msc'
msu.c:168: warning: Function parameter or struct member 'multi_is_broken' not described in 'msc'

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/hwtracing/intel_th/msu.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index 492d8eba37eb..bf99d79a4192 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -105,13 +105,16 @@ struct msc_iter {
 
 /**
  * struct msc - MSC device representation
- * @reg_base:		register window base address
+ * @reg_base:		register window base address for the entire MSU
+ * @msu_base:		register window base address for this MSC
  * @thdev:		intel_th_device pointer
  * @mbuf:		MSU buffer, if assigned
  * @mbuf_priv:		MSU buffer's private data, if @mbuf
+ * @work:		a work to stop the trace when the buffer is full
  * @win_list:		list of windows in multiblock mode
  * @single_sgt:		single mode buffer
  * @cur_win:		current window
+ * @switch_on_unlock:	window to switch to when it becomes available
  * @nr_pages:		total number of pages allocated for this buffer
  * @single_sz:		amount of data in single mode
  * @single_wrap:	single mode wrap occurred
@@ -122,8 +125,12 @@ struct msc_iter {
  * @user_count:		number of users of the buffer
  * @mmap_count:		number of mappings
  * @buf_mutex:		mutex to serialize access to buffer-related bits
+ * @iter_list:		list of open file descriptor iterators
+ * @stop_on_full:	stop the trace if the current window is full
  * @enabled:		MSC is enabled
  * @wrap:		wrapping is enabled
+ * @do_irq:		IRQ resource is available, handle interrupts
+ * @multi_is_broken:	multiblock mode enabled (not disabled by PCI drvdata)
  * @mode:		MSC operating mode
  * @burst_len:		write burst length
  * @index:		number of this MSC in the MSU
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/5] intel_th: pci: Add Arrow Lake support
  2025-02-11 18:50 [PATCH 0/5] intel_th: Fixes for v6.14 Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 1/5] intel_th: msu: Fix kernel-doc warnings Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 2/5] intel_th: msu: Fix less trivial " Alexander Shishkin
@ 2025-02-11 18:50 ` Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 4/5] intel_th: pci: Add Panther Lake-H support Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 5/5] intel_th: pci: Add Panther Lake-P/U support Alexander Shishkin
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2025-02-11 18:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Pawel Chmielewski, Alexander Shishkin,
	Andy Shevchenko, stable

From: Pawel Chmielewski <pawel.chmielewski@intel.com>

Add support for the Trace Hub in Arrow Lake.

Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: stable@kernel.org
---
 drivers/hwtracing/intel_th/pci.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwtracing/intel_th/pci.c b/drivers/hwtracing/intel_th/pci.c
index e9d8d28e055f..3e03ee788bb9 100644
--- a/drivers/hwtracing/intel_th/pci.c
+++ b/drivers/hwtracing/intel_th/pci.c
@@ -334,6 +334,11 @@ static const struct pci_device_id intel_th_pci_id_table[] = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xa824),
 		.driver_data = (kernel_ulong_t)&intel_th_2x,
 	},
+	{
+		/* Arrow Lake */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x7724),
+		.driver_data = (kernel_ulong_t)&intel_th_2x,
+	},
 	{
 		/* Alder Lake CPU */
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x466f),
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/5] intel_th: pci: Add Panther Lake-H support
  2025-02-11 18:50 [PATCH 0/5] intel_th: Fixes for v6.14 Alexander Shishkin
                   ` (2 preceding siblings ...)
  2025-02-11 18:50 ` [PATCH 3/5] intel_th: pci: Add Arrow Lake support Alexander Shishkin
@ 2025-02-11 18:50 ` Alexander Shishkin
  2025-02-11 18:50 ` [PATCH 5/5] intel_th: pci: Add Panther Lake-P/U support Alexander Shishkin
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2025-02-11 18:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Alexander Shishkin, Andy Shevchenko, stable

Add support for the Trace Hub in Panther Lake-H.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: stable@kernel.org
---
 drivers/hwtracing/intel_th/pci.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwtracing/intel_th/pci.c b/drivers/hwtracing/intel_th/pci.c
index 3e03ee788bb9..004e68286fd4 100644
--- a/drivers/hwtracing/intel_th/pci.c
+++ b/drivers/hwtracing/intel_th/pci.c
@@ -339,6 +339,11 @@ static const struct pci_device_id intel_th_pci_id_table[] = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x7724),
 		.driver_data = (kernel_ulong_t)&intel_th_2x,
 	},
+	{
+		/* Panther Lake-H */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe324),
+		.driver_data = (kernel_ulong_t)&intel_th_2x,
+	},
 	{
 		/* Alder Lake CPU */
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x466f),
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 5/5] intel_th: pci: Add Panther Lake-P/U support
  2025-02-11 18:50 [PATCH 0/5] intel_th: Fixes for v6.14 Alexander Shishkin
                   ` (3 preceding siblings ...)
  2025-02-11 18:50 ` [PATCH 4/5] intel_th: pci: Add Panther Lake-H support Alexander Shishkin
@ 2025-02-11 18:50 ` Alexander Shishkin
  4 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2025-02-11 18:50 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Alexander Shishkin, Andy Shevchenko, stable

Add support for the Trace Hub in Panther Lake-P/U.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: stable@kernel.org
---
 drivers/hwtracing/intel_th/pci.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwtracing/intel_th/pci.c b/drivers/hwtracing/intel_th/pci.c
index 004e68286fd4..e3def163d5cf 100644
--- a/drivers/hwtracing/intel_th/pci.c
+++ b/drivers/hwtracing/intel_th/pci.c
@@ -344,6 +344,11 @@ static const struct pci_device_id intel_th_pci_id_table[] = {
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe324),
 		.driver_data = (kernel_ulong_t)&intel_th_2x,
 	},
+	{
+		/* Panther Lake-P/U */
+		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe424),
+		.driver_data = (kernel_ulong_t)&intel_th_2x,
+	},
 	{
 		/* Alder Lake CPU */
 		PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x466f),
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-02-11 18:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-11 18:50 [PATCH 0/5] intel_th: Fixes for v6.14 Alexander Shishkin
2025-02-11 18:50 ` [PATCH 1/5] intel_th: msu: Fix kernel-doc warnings Alexander Shishkin
2025-02-11 18:50 ` [PATCH 2/5] intel_th: msu: Fix less trivial " Alexander Shishkin
2025-02-11 18:50 ` [PATCH 3/5] intel_th: pci: Add Arrow Lake support Alexander Shishkin
2025-02-11 18:50 ` [PATCH 4/5] intel_th: pci: Add Panther Lake-H support Alexander Shishkin
2025-02-11 18:50 ` [PATCH 5/5] intel_th: pci: Add Panther Lake-P/U support Alexander Shishkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox