public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] fixup! mm: fix a crash due to vma_end_read() that should have been removed
@ 2025-02-20 20:02 Suren Baghdasaryan
  0 siblings, 0 replies; only message in thread
From: Suren Baghdasaryan @ 2025-02-20 20:02 UTC (permalink / raw)
  To: akpm; +Cc: sfr, hca, surenb, linux-mm, linux-kernel

Handling a vma lock failure due to vma being detached from under us got
changed but vma_end_read() in that path was left untouched while it should
have been removed. Remove it.

Fixes: 758f7664c3d1 ("mm: replace vm_lock and detached flag with a reference count")
Reported-by: Heiko Carstens <hca@linux.ibm.com>
Closes: https://lore.kernel.org/all/20250220185304.8313A7d-hca@linux.ibm.com/
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
 mm/memory.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index cacf6d53bdf3..567b45e5d149 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -6496,7 +6496,6 @@ struct vm_area_struct *lock_vma_under_rcu(struct mm_struct *mm,
 	if (IS_ERR_OR_NULL(vma)) {
 		/* Check if the VMA got isolated after we found it */
 		if (PTR_ERR(vma) == -EAGAIN) {
-			vma_end_read(vma);
 			count_vm_vma_lock_event(VMA_LOCK_MISS);
 			/* The area was replaced with another one */
 			goto retry;

base-commit: f7ed46277aaa8f848f18959ff68469f5186ba87c
-- 
2.48.1.601.g30ceb7b040-goog


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-02-20 20:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-20 20:02 [PATCH 1/1] fixup! mm: fix a crash due to vma_end_read() that should have been removed Suren Baghdasaryan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox