* [PATCH v10 0/3] sched: Restructure task_mm_cid_work for predictability
@ 2025-02-26 7:01 Gabriele Monaco
2025-02-26 7:01 ` [PATCH v10 1/3] sched: Add prev_sum_exec_runtime support for RT, DL and SCX classes Gabriele Monaco
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gabriele Monaco @ 2025-02-26 7:01 UTC (permalink / raw)
To: linux-kernel, Mathieu Desnoyers, Peter Zijlstra, Ingo Molnar,
Paul E. McKenney, Shuah Khan
Cc: Gabriele Monaco
This patchset moves the task_mm_cid_work to a preemptible and migratable
context. This reduces the impact of this work to the scheduling latency
of real time tasks.
The change makes the recurrence of the task a bit more predictable.
The behaviour causing latency was introduced in commit 223baf9d17f2
("sched: Fix performance regression introduced by mm_cid") which
introduced a task work tied to the scheduler tick.
That approach presents two possible issues:
* the task work runs before returning to user and causes, in fact, a
scheduling latency (with order of magnitude significant in PREEMPT_RT)
* periodic tasks with short runtime are less likely to run during the
tick, hence they might not run the task work at all
Patch 1 add support for prev_sum_exec_runtime to the RT, deadline and
sched_ext classes as it is supported by fair, this is required to avoid
calling rseq_preempt on tick if the runtime is below a threshold.
Patch 2 contains the main changes, removing the task_work on the
scheduler tick and using a work_struct scheduled more reliably during
__rseq_handle_notify_resume.
Patch 3 adds a selftest to validate the functionality of the
task_mm_cid_work (i.e. to compact the mm_cids).
Changes since V9:
* Simplify and move checks from task_queue_mm_cid to its call site
Changes since V8 [1]:
* Add support for prev_sum_exec_runtime to RT, deadline and sched_ext
* Avoid rseq_preempt on ticks unless executing for more than 100ms
* Queue the work on the unbound workqueue
Changes since V7:
* Schedule mm_cid compaction and update at every tick too
* mmgrab before scheduling the work
Changes since V6 [2]:
* Switch to a simple work_struct instead of a delayed work
* Schedule the work_struct in __rseq_handle_notify_resume
* Asynchronously disable the work but make sure mm is there while we run
* Remove first patch as merged independently
* Fix commit tag for test
Changes since V5:
* Punctuation
Changes since V4 [3]:
* Fixes on the selftest
* Polished memory allocation and cleanup
* Handle the test failure in main
Changes since V3 [4]:
* Fixes on the selftest
* Minor style issues in comments and indentation
* Use of perror where possible
* Add a barrier to align threads execution
* Improve test failure and error handling
Changes since V2 [5]:
* Change the order of the patches
* Merge patches changing the main delayed_work logic
* Improved self-test to spawn 1 less thread and use the main one instead
Changes since V1 [6]:
* Re-arm the delayed_work at each invocation
* Cancel the work synchronously at mmdrop
* Remove next scan fields and completely rely on the delayed_work
* Shrink mm_cid allocation with nr thread/affinity (Mathieu Desnoyers)
* Add self test
[1] - https://lore.kernel.org/lkml/20250220102639.141314-1-gmonaco@redhat.com
[2] - https://lore.kernel.org/lkml/20250210153253.460471-1-gmonaco@redhat.com
[3] - https://lore.kernel.org/lkml/20250113074231.61638-4-gmonaco@redhat.com
[4] - https://lore.kernel.org/lkml/20241216130909.240042-1-gmonaco@redhat.com
[5] - https://lore.kernel.org/lkml/20241213095407.271357-1-gmonaco@redhat.com
[6] - https://lore.kernel.org/lkml/20241205083110.180134-2-gmonaco@redhat.com
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@redhat.org>
To: Paul E. McKenney <paulmck@kernel.org>
To: Shuah Khan <shuah@kernel.org>
Gabriele Monaco (3):
sched: Add prev_sum_exec_runtime support for RT, DL and SCX classes
sched: Move task_mm_cid_work to mm work_struct
selftests/rseq: Add test for mm_cid compaction
include/linux/mm_types.h | 8 +
include/linux/rseq.h | 2 +
include/linux/sched.h | 7 +-
kernel/rseq.c | 3 +
kernel/sched/core.c | 47 ++--
kernel/sched/deadline.c | 1 +
kernel/sched/ext.c | 1 +
kernel/sched/rt.c | 1 +
kernel/sched/sched.h | 2 -
tools/testing/selftests/rseq/.gitignore | 1 +
tools/testing/selftests/rseq/Makefile | 2 +-
.../selftests/rseq/mm_cid_compaction_test.c | 200 ++++++++++++++++++
12 files changed, 242 insertions(+), 33 deletions(-)
create mode 100644 tools/testing/selftests/rseq/mm_cid_compaction_test.c
base-commit: ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7
--
2.48.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v10 1/3] sched: Add prev_sum_exec_runtime support for RT, DL and SCX classes
2025-02-26 7:01 [PATCH v10 0/3] sched: Restructure task_mm_cid_work for predictability Gabriele Monaco
@ 2025-02-26 7:01 ` Gabriele Monaco
2025-02-26 7:01 ` [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct Gabriele Monaco
2025-02-26 7:02 ` [PATCH v10 3/3] selftests/rseq: Add test for mm_cid compaction Gabriele Monaco
2 siblings, 0 replies; 6+ messages in thread
From: Gabriele Monaco @ 2025-02-26 7:01 UTC (permalink / raw)
To: linux-kernel, Ingo Molnar, Peter Zijlstra
Cc: Gabriele Monaco, Mathieu Desnoyers, Ingo Molnar, Paul E. McKenney,
Shuah Khan
The fair scheduling class relies on prev_sum_exec_runtime to compute the
duration of the task's runtime since it was last scheduled. This value
is currently not required by other scheduling classes but can be useful
to understand long running tasks and take certain actions (e.g. during a
scheduler tick).
Add support for prev_sum_exec_runtime to the RT, deadline and sched_ext
classes by simply assigning the sum_exec_runtime at each set_next_task.
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
kernel/sched/deadline.c | 1 +
kernel/sched/ext.c | 1 +
kernel/sched/rt.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 38e4537790af7..438b3a953d6c7 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2391,6 +2391,7 @@ static void set_next_task_dl(struct rq *rq, struct task_struct *p, bool first)
p->se.exec_start = rq_clock_task(rq);
if (on_dl_rq(&p->dl))
update_stats_wait_end_dl(dl_rq, dl_se);
+ p->se.prev_sum_exec_runtime = p->se.sum_exec_runtime;
/* You can't push away the running task */
dequeue_pushable_dl_task(rq, p);
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 5a81d9a1e31f2..feaed0459eb92 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -2974,6 +2974,7 @@ static void set_next_task_scx(struct rq *rq, struct task_struct *p, bool first)
}
p->se.exec_start = rq_clock_task(rq);
+ p->se.prev_sum_exec_runtime = p->se.sum_exec_runtime;
/* see dequeue_task_scx() on why we skip when !QUEUED */
if (SCX_HAS_OP(running) && (p->scx.flags & SCX_TASK_QUEUED))
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 4b8e33c615b12..1ea272e4dae71 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1684,6 +1684,7 @@ static inline void set_next_task_rt(struct rq *rq, struct task_struct *p, bool f
p->se.exec_start = rq_clock_task(rq);
if (on_rt_rq(&p->rt))
update_stats_wait_end_rt(rt_rq, rt_se);
+ p->se.prev_sum_exec_runtime = p->se.sum_exec_runtime;
/* The running task is never eligible for pushing */
dequeue_pushable_task(rq, p);
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct
2025-02-26 7:01 [PATCH v10 0/3] sched: Restructure task_mm_cid_work for predictability Gabriele Monaco
2025-02-26 7:01 ` [PATCH v10 1/3] sched: Add prev_sum_exec_runtime support for RT, DL and SCX classes Gabriele Monaco
@ 2025-02-26 7:01 ` Gabriele Monaco
2025-02-27 7:47 ` kernel test robot
2025-02-27 7:48 ` kernel test robot
2025-02-26 7:02 ` [PATCH v10 3/3] selftests/rseq: Add test for mm_cid compaction Gabriele Monaco
2 siblings, 2 replies; 6+ messages in thread
From: Gabriele Monaco @ 2025-02-26 7:01 UTC (permalink / raw)
To: linux-kernel, Andrew Morton, Ingo Molnar, Peter Zijlstra,
Mathieu Desnoyers, Paul E. McKenney, linux-mm
Cc: Gabriele Monaco, Ingo Molnar, Shuah Khan
Currently, the task_mm_cid_work function is called in a task work
triggered by a scheduler tick to frequently compact the mm_cids of each
process. This can delay the execution of the corresponding thread for
the entire duration of the function, negatively affecting the response
in case of real time tasks. In practice, we observe task_mm_cid_work
increasing the latency of 30-35us on a 128 cores system, this order of
magnitude is meaningful under PREEMPT_RT.
Run the task_mm_cid_work in a new work_struct connected to the
mm_struct rather than in the task context before returning to
userspace.
This work_struct is initialised with the mm and disabled before freeing
it. The queuing of the work happens while returning to userspace in
__rseq_handle_notify_resume, maintaining the checks to avoid running
more frequently than MM_CID_SCAN_DELAY.
To make sure this happens predictably also on long running tasks, we
trigger a call to __rseq_handle_notify_resume also from the scheduler
tick if the runtime exceeded a 100ms threshold.
The main advantage of this change is that the function can be offloaded
to a different CPU and even preempted by RT tasks.
Moreover, this new behaviour is more predictable with periodic tasks
with short runtime, which may rarely run during a scheduler tick.
Now, the work is always scheduled when the task returns to userspace.
The work is disabled during mmdrop, since the function cannot sleep in
all kernel configurations, we cannot wait for possibly running work
items to terminate. We make sure the mm is valid in case the task is
terminating by reserving it with mmgrab/mmdrop, returning prematurely if
we are really the last user while the work gets to run.
This situation is unlikely since we don't schedule the work for exiting
tasks, but we cannot rule it out.
Fixes: 223baf9d17f2 ("sched: Fix performance regression introduced by mm_cid")
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
include/linux/mm_types.h | 8 +++++++
include/linux/rseq.h | 2 ++
include/linux/sched.h | 7 +++++-
kernel/rseq.c | 3 +++
kernel/sched/core.c | 47 +++++++++++++++-------------------------
kernel/sched/sched.h | 2 --
6 files changed, 37 insertions(+), 32 deletions(-)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 0234f14f2aa6b..e748cf51e0c32 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -889,6 +889,10 @@ struct mm_struct {
* mm nr_cpus_allowed updates.
*/
raw_spinlock_t cpus_allowed_lock;
+ /*
+ * @cid_work: Work item to run the mm_cid scan.
+ */
+ struct work_struct cid_work;
#endif
#ifdef CONFIG_MMU
atomic_long_t pgtables_bytes; /* size of all page tables */
@@ -1185,6 +1189,8 @@ enum mm_cid_state {
MM_CID_LAZY_PUT = (1U << 31),
};
+extern void task_mm_cid_work(struct work_struct *work);
+
static inline bool mm_cid_is_unset(int cid)
{
return cid == MM_CID_UNSET;
@@ -1257,12 +1263,14 @@ static inline int mm_alloc_cid_noprof(struct mm_struct *mm, struct task_struct *
if (!mm->pcpu_cid)
return -ENOMEM;
mm_init_cid(mm, p);
+ INIT_WORK(&mm->cid_work, task_mm_cid_work);
return 0;
}
#define mm_alloc_cid(...) alloc_hooks(mm_alloc_cid_noprof(__VA_ARGS__))
static inline void mm_destroy_cid(struct mm_struct *mm)
{
+ disable_work(&mm->cid_work);
free_percpu(mm->pcpu_cid);
mm->pcpu_cid = NULL;
}
diff --git a/include/linux/rseq.h b/include/linux/rseq.h
index bc8af3eb55987..3e708e2e5e459 100644
--- a/include/linux/rseq.h
+++ b/include/linux/rseq.h
@@ -7,6 +7,8 @@
#include <linux/preempt.h>
#include <linux/sched.h>
+#define RSEQ_UNPREEMPTED_THRESHOLD (100ULL * 1000000) /* 100ms */
+
/*
* Map the event mask on the user-space ABI enum rseq_cs_flags
* for direct mask checks.
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 9632e3318e0d6..2fd65f125153d 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1397,7 +1397,6 @@ struct task_struct {
int last_mm_cid; /* Most recent cid in mm */
int migrate_from_cpu;
int mm_cid_active; /* Whether cid bitmap is active */
- struct callback_head cid_work;
#endif
struct tlbflush_unmap_batch tlb_ubc;
@@ -2254,4 +2253,10 @@ static __always_inline void alloc_tag_restore(struct alloc_tag *tag, struct allo
#define alloc_tag_restore(_tag, _old) do {} while (0)
#endif
+#ifdef CONFIG_SCHED_MM_CID
+extern void task_queue_mm_cid(struct task_struct *curr);
+#else
+static inline void task_queue_mm_cid(struct task_struct *curr) { }
+#endif
+
#endif
diff --git a/kernel/rseq.c b/kernel/rseq.c
index 2cb16091ec0ae..c684622b16f03 100644
--- a/kernel/rseq.c
+++ b/kernel/rseq.c
@@ -402,6 +402,7 @@ static int rseq_ip_fixup(struct pt_regs *regs)
void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
{
struct task_struct *t = current;
+ unsigned long now = jiffies;
int ret, sig;
if (unlikely(t->flags & PF_EXITING))
@@ -419,6 +420,8 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
}
if (unlikely(rseq_update_cpu_node_id(t)))
goto error;
+ if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
+ task_queue_mm_cid(t);
return;
error:
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 9aecd914ac691..97f0d41c70bc3 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5639,7 +5639,7 @@ void sched_tick(void)
struct task_struct *donor;
struct rq_flags rf;
unsigned long hw_pressure;
- u64 resched_latency;
+ u64 resched_latency, rtime;
if (housekeeping_cpu(cpu, HK_TYPE_KERNEL_NOISE))
arch_scale_freq_tick();
@@ -5648,6 +5648,7 @@ void sched_tick(void)
rq_lock(rq, &rf);
donor = rq->donor;
+ rtime = donor->se.sum_exec_runtime - donor->se.prev_sum_exec_runtime;
psi_account_irqtime(rq, donor, NULL);
@@ -5663,7 +5664,8 @@ void sched_tick(void)
resched_latency = cpu_resched_latency(rq);
calc_global_load_tick(rq);
sched_core_tick(rq);
- task_tick_mm_cid(rq, donor);
+ if (rtime > RSEQ_UNPREEMPTED_THRESHOLD)
+ rseq_preempt(donor);
scx_tick(rq);
rq_unlock(rq, &rf);
@@ -10530,22 +10532,16 @@ static void sched_mm_cid_remote_clear_weight(struct mm_struct *mm, int cpu,
sched_mm_cid_remote_clear(mm, pcpu_cid, cpu);
}
-static void task_mm_cid_work(struct callback_head *work)
+void task_mm_cid_work(struct work_struct *work)
{
unsigned long now = jiffies, old_scan, next_scan;
- struct task_struct *t = current;
struct cpumask *cidmask;
- struct mm_struct *mm;
+ struct mm_struct *mm = container_of(work, struct mm_struct, cid_work);
int weight, cpu;
- SCHED_WARN_ON(t != container_of(work, struct task_struct, cid_work));
-
- work->next = work; /* Prevent double-add */
- if (t->flags & PF_EXITING)
- return;
- mm = t->mm;
- if (!mm)
- return;
+ /* We are the last user, process already terminated. */
+ if (atomic_read(&mm->mm_count) == 1)
+ goto out_drop;
old_scan = READ_ONCE(mm->mm_cid_next_scan);
next_scan = now + msecs_to_jiffies(MM_CID_SCAN_DELAY);
if (!old_scan) {
@@ -10558,9 +10554,9 @@ static void task_mm_cid_work(struct callback_head *work)
old_scan = next_scan;
}
if (time_before(now, old_scan))
- return;
+ goto out_drop;
if (!try_cmpxchg(&mm->mm_cid_next_scan, &old_scan, next_scan))
- return;
+ goto out_drop;
cidmask = mm_cidmask(mm);
/* Clear cids that were not recently used. */
for_each_possible_cpu(cpu)
@@ -10572,6 +10568,8 @@ static void task_mm_cid_work(struct callback_head *work)
*/
for_each_possible_cpu(cpu)
sched_mm_cid_remote_clear_weight(mm, cpu, weight);
+out_drop:
+ mmdrop(mm);
}
void init_sched_mm_cid(struct task_struct *t)
@@ -10584,23 +10582,14 @@ void init_sched_mm_cid(struct task_struct *t)
if (mm_users == 1)
mm->mm_cid_next_scan = jiffies + msecs_to_jiffies(MM_CID_SCAN_DELAY);
}
- t->cid_work.next = &t->cid_work; /* Protect against double add */
- init_task_work(&t->cid_work, task_mm_cid_work);
}
-void task_tick_mm_cid(struct rq *rq, struct task_struct *curr)
+/* Call only when curr is a user thread. */
+void task_queue_mm_cid(struct task_struct *curr)
{
- struct callback_head *work = &curr->cid_work;
- unsigned long now = jiffies;
-
- if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) ||
- work->next != work)
- return;
- if (time_before(now, READ_ONCE(curr->mm->mm_cid_next_scan)))
- return;
-
- /* No page allocation under rq lock */
- task_work_add(curr, work, TWA_RESUME);
+ /* Ensure the mm exists when we run. */
+ mmgrab(curr->mm);
+ queue_work(system_unbound_wq, &curr->mm->cid_work);
}
void sched_mm_cid_exit_signals(struct task_struct *t)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index c8512a9fb0229..37a2e2328283e 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -3630,7 +3630,6 @@ extern int use_cid_lock;
extern void sched_mm_cid_migrate_from(struct task_struct *t);
extern void sched_mm_cid_migrate_to(struct rq *dst_rq, struct task_struct *t);
-extern void task_tick_mm_cid(struct rq *rq, struct task_struct *curr);
extern void init_sched_mm_cid(struct task_struct *t);
static inline void __mm_cid_put(struct mm_struct *mm, int cid)
@@ -3899,7 +3898,6 @@ static inline void switch_mm_cid(struct rq *rq,
static inline void switch_mm_cid(struct rq *rq, struct task_struct *prev, struct task_struct *next) { }
static inline void sched_mm_cid_migrate_from(struct task_struct *t) { }
static inline void sched_mm_cid_migrate_to(struct rq *dst_rq, struct task_struct *t) { }
-static inline void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) { }
static inline void init_sched_mm_cid(struct task_struct *t) { }
#endif /* !CONFIG_SCHED_MM_CID */
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v10 3/3] selftests/rseq: Add test for mm_cid compaction
2025-02-26 7:01 [PATCH v10 0/3] sched: Restructure task_mm_cid_work for predictability Gabriele Monaco
2025-02-26 7:01 ` [PATCH v10 1/3] sched: Add prev_sum_exec_runtime support for RT, DL and SCX classes Gabriele Monaco
2025-02-26 7:01 ` [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct Gabriele Monaco
@ 2025-02-26 7:02 ` Gabriele Monaco
2 siblings, 0 replies; 6+ messages in thread
From: Gabriele Monaco @ 2025-02-26 7:02 UTC (permalink / raw)
To: linux-kernel, Mathieu Desnoyers, Peter Zijlstra, Paul E. McKenney,
Shuah Khan, linux-kselftest
Cc: Gabriele Monaco, Ingo Molnar
A task in the kernel (task_mm_cid_work) runs somewhat periodically to
compact the mm_cid for each process. Add a test to validate that it runs
correctly and timely.
The test spawns 1 thread pinned to each CPU, then each thread, including
the main one, runs in short bursts for some time. During this period, the
mm_cids should be spanning all numbers between 0 and nproc.
At the end of this phase, a thread with high enough mm_cid (>= nproc/2)
is selected to be the new leader, all other threads terminate.
After some time, the only running thread should see 0 as mm_cid, if that
doesn't happen, the compaction mechanism didn't work and the test fails.
The test never fails if only 1 core is available, in which case, we
cannot test anything as the only available mm_cid is 0.
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
tools/testing/selftests/rseq/.gitignore | 1 +
tools/testing/selftests/rseq/Makefile | 2 +-
.../selftests/rseq/mm_cid_compaction_test.c | 200 ++++++++++++++++++
3 files changed, 202 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/selftests/rseq/mm_cid_compaction_test.c
diff --git a/tools/testing/selftests/rseq/.gitignore b/tools/testing/selftests/rseq/.gitignore
index 16496de5f6ce4..2c89f97e4f737 100644
--- a/tools/testing/selftests/rseq/.gitignore
+++ b/tools/testing/selftests/rseq/.gitignore
@@ -3,6 +3,7 @@ basic_percpu_ops_test
basic_percpu_ops_mm_cid_test
basic_test
basic_rseq_op_test
+mm_cid_compaction_test
param_test
param_test_benchmark
param_test_compare_twice
diff --git a/tools/testing/selftests/rseq/Makefile b/tools/testing/selftests/rseq/Makefile
index 5a3432fceb586..ce1b38f46a355 100644
--- a/tools/testing/selftests/rseq/Makefile
+++ b/tools/testing/selftests/rseq/Makefile
@@ -16,7 +16,7 @@ OVERRIDE_TARGETS = 1
TEST_GEN_PROGS = basic_test basic_percpu_ops_test basic_percpu_ops_mm_cid_test param_test \
param_test_benchmark param_test_compare_twice param_test_mm_cid \
- param_test_mm_cid_benchmark param_test_mm_cid_compare_twice
+ param_test_mm_cid_benchmark param_test_mm_cid_compare_twice mm_cid_compaction_test
TEST_GEN_PROGS_EXTENDED = librseq.so
diff --git a/tools/testing/selftests/rseq/mm_cid_compaction_test.c b/tools/testing/selftests/rseq/mm_cid_compaction_test.c
new file mode 100644
index 0000000000000..7ddde3b657dd6
--- /dev/null
+++ b/tools/testing/selftests/rseq/mm_cid_compaction_test.c
@@ -0,0 +1,200 @@
+// SPDX-License-Identifier: LGPL-2.1
+#define _GNU_SOURCE
+#include <assert.h>
+#include <pthread.h>
+#include <sched.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <stddef.h>
+
+#include "../kselftest.h"
+#include "rseq.h"
+
+#define VERBOSE 0
+#define printf_verbose(fmt, ...) \
+ do { \
+ if (VERBOSE) \
+ printf(fmt, ##__VA_ARGS__); \
+ } while (0)
+
+/* 0.5 s */
+#define RUNNER_PERIOD 500000
+/* Number of runs before we terminate or get the token */
+#define THREAD_RUNS 5
+
+/*
+ * Number of times we check that the mm_cid were compacted.
+ * Checks are repeated every RUNNER_PERIOD.
+ */
+#define MM_CID_COMPACT_TIMEOUT 10
+
+struct thread_args {
+ int cpu;
+ int num_cpus;
+ pthread_mutex_t *token;
+ pthread_barrier_t *barrier;
+ pthread_t *tinfo;
+ struct thread_args *args_head;
+};
+
+static void __noreturn *thread_runner(void *arg)
+{
+ struct thread_args *args = arg;
+ int i, ret, curr_mm_cid;
+ cpu_set_t cpumask;
+
+ CPU_ZERO(&cpumask);
+ CPU_SET(args->cpu, &cpumask);
+ ret = pthread_setaffinity_np(pthread_self(), sizeof(cpumask), &cpumask);
+ if (ret) {
+ errno = ret;
+ perror("Error: failed to set affinity");
+ abort();
+ }
+ pthread_barrier_wait(args->barrier);
+
+ for (i = 0; i < THREAD_RUNS; i++)
+ usleep(RUNNER_PERIOD);
+ curr_mm_cid = rseq_current_mm_cid();
+ /*
+ * We select one thread with high enough mm_cid to be the new leader.
+ * All other threads (including the main thread) will terminate.
+ * After some time, the mm_cid of the only remaining thread should
+ * converge to 0, if not, the test fails.
+ */
+ if (curr_mm_cid >= args->num_cpus / 2 &&
+ !pthread_mutex_trylock(args->token)) {
+ printf_verbose(
+ "cpu%d has mm_cid=%d and will be the new leader.\n",
+ sched_getcpu(), curr_mm_cid);
+ for (i = 0; i < args->num_cpus; i++) {
+ if (args->tinfo[i] == pthread_self())
+ continue;
+ ret = pthread_join(args->tinfo[i], NULL);
+ if (ret) {
+ errno = ret;
+ perror("Error: failed to join thread");
+ abort();
+ }
+ }
+ pthread_barrier_destroy(args->barrier);
+ free(args->tinfo);
+ free(args->token);
+ free(args->barrier);
+ free(args->args_head);
+
+ for (i = 0; i < MM_CID_COMPACT_TIMEOUT; i++) {
+ curr_mm_cid = rseq_current_mm_cid();
+ printf_verbose("run %d: mm_cid=%d on cpu%d.\n", i,
+ curr_mm_cid, sched_getcpu());
+ if (curr_mm_cid == 0)
+ exit(EXIT_SUCCESS);
+ usleep(RUNNER_PERIOD);
+ }
+ exit(EXIT_FAILURE);
+ }
+ printf_verbose("cpu%d has mm_cid=%d and is going to terminate.\n",
+ sched_getcpu(), curr_mm_cid);
+ pthread_exit(NULL);
+}
+
+int test_mm_cid_compaction(void)
+{
+ cpu_set_t affinity;
+ int i, j, ret = 0, num_threads;
+ pthread_t *tinfo;
+ pthread_mutex_t *token;
+ pthread_barrier_t *barrier;
+ struct thread_args *args;
+
+ sched_getaffinity(0, sizeof(affinity), &affinity);
+ num_threads = CPU_COUNT(&affinity);
+ tinfo = calloc(num_threads, sizeof(*tinfo));
+ if (!tinfo) {
+ perror("Error: failed to allocate tinfo");
+ return -1;
+ }
+ args = calloc(num_threads, sizeof(*args));
+ if (!args) {
+ perror("Error: failed to allocate args");
+ ret = -1;
+ goto out_free_tinfo;
+ }
+ token = malloc(sizeof(*token));
+ if (!token) {
+ perror("Error: failed to allocate token");
+ ret = -1;
+ goto out_free_args;
+ }
+ barrier = malloc(sizeof(*barrier));
+ if (!barrier) {
+ perror("Error: failed to allocate barrier");
+ ret = -1;
+ goto out_free_token;
+ }
+ if (num_threads == 1) {
+ fprintf(stderr, "Cannot test on a single cpu. "
+ "Skipping mm_cid_compaction test.\n");
+ /* only skipping the test, this is not a failure */
+ goto out_free_barrier;
+ }
+ pthread_mutex_init(token, NULL);
+ ret = pthread_barrier_init(barrier, NULL, num_threads);
+ if (ret) {
+ errno = ret;
+ perror("Error: failed to initialise barrier");
+ goto out_free_barrier;
+ }
+ for (i = 0, j = 0; i < CPU_SETSIZE && j < num_threads; i++) {
+ if (!CPU_ISSET(i, &affinity))
+ continue;
+ args[j].num_cpus = num_threads;
+ args[j].tinfo = tinfo;
+ args[j].token = token;
+ args[j].barrier = barrier;
+ args[j].cpu = i;
+ args[j].args_head = args;
+ if (!j) {
+ /* The first thread is the main one */
+ tinfo[0] = pthread_self();
+ ++j;
+ continue;
+ }
+ ret = pthread_create(&tinfo[j], NULL, thread_runner, &args[j]);
+ if (ret) {
+ errno = ret;
+ perror("Error: failed to create thread");
+ abort();
+ }
+ ++j;
+ }
+ printf_verbose("Started %d threads.\n", num_threads);
+
+ /* Also main thread will terminate if it is not selected as leader */
+ thread_runner(&args[0]);
+
+ /* only reached in case of errors */
+out_free_barrier:
+ free(barrier);
+out_free_token:
+ free(token);
+out_free_args:
+ free(args);
+out_free_tinfo:
+ free(tinfo);
+
+ return ret;
+}
+
+int main(int argc, char **argv)
+{
+ if (!rseq_mm_cid_available()) {
+ fprintf(stderr, "Error: rseq_mm_cid unavailable\n");
+ return -1;
+ }
+ if (test_mm_cid_compaction())
+ return -1;
+ return 0;
+}
--
2.48.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct
2025-02-26 7:01 ` [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct Gabriele Monaco
@ 2025-02-27 7:47 ` kernel test robot
2025-02-27 7:48 ` kernel test robot
1 sibling, 0 replies; 6+ messages in thread
From: kernel test robot @ 2025-02-27 7:47 UTC (permalink / raw)
To: Gabriele Monaco, linux-kernel, Andrew Morton, Ingo Molnar,
Peter Zijlstra, Mathieu Desnoyers, Paul E. McKenney
Cc: oe-kbuild-all, Linux Memory Management List, Gabriele Monaco,
Shuah Khan
Hi Gabriele,
kernel test robot noticed the following build errors:
[auto build test ERROR on ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7]
url: https://github.com/intel-lab-lkp/linux/commits/Gabriele-Monaco/sched-Add-prev_sum_exec_runtime-support-for-RT-DL-and-SCX-classes/20250226-150508
base: ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7
patch link: https://lore.kernel.org/r/20250226070202.95062-3-gmonaco%40redhat.com
patch subject: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct
config: arm-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502271525.N9ZL15lR-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502271525.N9ZL15lR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502271525.N9ZL15lR-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/bitfield.h:10,
from arch/arm/include/asm/ptrace.h:13,
from arch/arm/include/asm/processor.h:14,
from include/linux/sched.h:13,
from kernel/rseq.c:11:
kernel/rseq.c: In function '__rseq_handle_notify_resume':
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/asm-generic/rwonce.h:44:43: note: in expansion of macro '__unqual_scalar_typeof'
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast [-Wcompare-distinct-pointer-types]
12 | (void)(&__dummy == &__dummy2); \
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
vim +423 kernel/rseq.c
390
391 /*
392 * This resume handler must always be executed between any of:
393 * - preemption,
394 * - signal delivery,
395 * and return to user-space.
396 *
397 * This is how we can ensure that the entire rseq critical section
398 * will issue the commit instruction only if executed atomically with
399 * respect to other threads scheduled on the same CPU, and with respect
400 * to signal handlers.
401 */
402 void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
403 {
404 struct task_struct *t = current;
405 unsigned long now = jiffies;
406 int ret, sig;
407
408 if (unlikely(t->flags & PF_EXITING))
409 return;
410
411 /*
412 * regs is NULL if and only if the caller is in a syscall path. Skip
413 * fixup and leave rseq_cs as is so that rseq_sycall() will detect and
414 * kill a misbehaving userspace on debug kernels.
415 */
416 if (regs) {
417 ret = rseq_ip_fixup(regs);
418 if (unlikely(ret < 0))
419 goto error;
420 }
421 if (unlikely(rseq_update_cpu_node_id(t)))
422 goto error;
> 423 if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
424 task_queue_mm_cid(t);
425 return;
426
427 error:
428 sig = ksig ? ksig->sig : 0;
429 force_sigsegv(sig);
430 }
431
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct
2025-02-26 7:01 ` [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct Gabriele Monaco
2025-02-27 7:47 ` kernel test robot
@ 2025-02-27 7:48 ` kernel test robot
1 sibling, 0 replies; 6+ messages in thread
From: kernel test robot @ 2025-02-27 7:48 UTC (permalink / raw)
To: Gabriele Monaco, linux-kernel, Andrew Morton, Ingo Molnar,
Peter Zijlstra, Mathieu Desnoyers, Paul E. McKenney
Cc: oe-kbuild-all, Linux Memory Management List, Gabriele Monaco,
Shuah Khan
Hi Gabriele,
kernel test robot noticed the following build errors:
[auto build test ERROR on ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7]
url: https://github.com/intel-lab-lkp/linux/commits/Gabriele-Monaco/sched-Add-prev_sum_exec_runtime-support-for-RT-DL-and-SCX-classes/20250226-150508
base: ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7
patch link: https://lore.kernel.org/r/20250226070202.95062-3-gmonaco%40redhat.com
patch subject: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct
config: arc-randconfig-002-20250227 (https://download.01.org/0day-ci/archive/20250227/202502271546.WRb9VN4H-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502271546.WRb9VN4H-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502271546.WRb9VN4H-lkp@intel.com/
All errors (new ones prefixed by >>):
kernel/sched/core.c: In function 'sched_tick':
>> kernel/sched/core.c:5667:21: error: 'RSEQ_UNPREEMPTED_THRESHOLD' undeclared (first use in this function)
5667 | if (rtime > RSEQ_UNPREEMPTED_THRESHOLD)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/core.c:5667:21: note: each undeclared identifier is reported only once for each function it appears in
vim +/RSEQ_UNPREEMPTED_THRESHOLD +5667 kernel/sched/core.c
5629
5630 /*
5631 * This function gets called by the timer code, with HZ frequency.
5632 * We call it with interrupts disabled.
5633 */
5634 void sched_tick(void)
5635 {
5636 int cpu = smp_processor_id();
5637 struct rq *rq = cpu_rq(cpu);
5638 /* accounting goes to the donor task */
5639 struct task_struct *donor;
5640 struct rq_flags rf;
5641 unsigned long hw_pressure;
5642 u64 resched_latency, rtime;
5643
5644 if (housekeeping_cpu(cpu, HK_TYPE_KERNEL_NOISE))
5645 arch_scale_freq_tick();
5646
5647 sched_clock_tick();
5648
5649 rq_lock(rq, &rf);
5650 donor = rq->donor;
5651 rtime = donor->se.sum_exec_runtime - donor->se.prev_sum_exec_runtime;
5652
5653 psi_account_irqtime(rq, donor, NULL);
5654
5655 update_rq_clock(rq);
5656 hw_pressure = arch_scale_hw_pressure(cpu_of(rq));
5657 update_hw_load_avg(rq_clock_task(rq), rq, hw_pressure);
5658
5659 if (dynamic_preempt_lazy() && tif_test_bit(TIF_NEED_RESCHED_LAZY))
5660 resched_curr(rq);
5661
5662 donor->sched_class->task_tick(rq, donor, 0);
5663 if (sched_feat(LATENCY_WARN))
5664 resched_latency = cpu_resched_latency(rq);
5665 calc_global_load_tick(rq);
5666 sched_core_tick(rq);
> 5667 if (rtime > RSEQ_UNPREEMPTED_THRESHOLD)
5668 rseq_preempt(donor);
5669 scx_tick(rq);
5670
5671 rq_unlock(rq, &rf);
5672
5673 if (sched_feat(LATENCY_WARN) && resched_latency)
5674 resched_latency_warn(cpu, resched_latency);
5675
5676 perf_event_task_tick();
5677
5678 if (donor->flags & PF_WQ_WORKER)
5679 wq_worker_tick(donor);
5680
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-02-27 7:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-26 7:01 [PATCH v10 0/3] sched: Restructure task_mm_cid_work for predictability Gabriele Monaco
2025-02-26 7:01 ` [PATCH v10 1/3] sched: Add prev_sum_exec_runtime support for RT, DL and SCX classes Gabriele Monaco
2025-02-26 7:01 ` [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct Gabriele Monaco
2025-02-27 7:47 ` kernel test robot
2025-02-27 7:48 ` kernel test robot
2025-02-26 7:02 ` [PATCH v10 3/3] selftests/rseq: Add test for mm_cid compaction Gabriele Monaco
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox