[PATCH v1 0/4] X1E Dell XPS 9345 External DisplayPort, HBR3 fixes

[PATCH v1 0/4] X1E Dell XPS 9345 External DisplayPort, HBR3 fixes

[Aleksandrs Vinarskis]

As initial LTTPR support for msm driver [1] has landed, enable external
DisplayPort on Dell XPS 9345. It appears that supported frequencies
need to be listed to allow HBR3 speeds.

While at it, enable HBR3 speeds on other X1E laptops that have external
DisplayPort enabled already.

These patches were extensively tested over the past few months on
Ubuntu's X1E concept tree [2].

[1] https://lore.kernel.org/all/20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org/
[2] https://git.launchpad.net/~ubuntu-concept/ubuntu/+source/linux/+git/oracular/refs/?h=qcom-x1e

Aleksandrs Vinarskis (4):
  arm64: dts: qcom: x1e80100-dell-xps13-9345: Enable external DP support
  arm64: dts: qcom: x1e001de-devkit: Enable HBR3 on external DPs
  arm64: dts: qcom: x1e80100-hp-x14: Enable HBR3 on external DPs
  arm64: dts: qcom: x1e80100-qcp: Enable HBR3 on external DPs

 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts   |  3 +++
 .../boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 18 ++++++++++++++++++
 .../boot/dts/qcom/x1e80100-hp-omnibook-x14.dts |  2 ++
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts      |  3 +++
 4 files changed, 26 insertions(+)

-- 
2.45.2

[PATCH v1 1/4] arm64: dts: qcom: x1e80100-dell-xps13-9345: Enable external DP support

[Aleksandrs Vinarskis]

Particular laptops comes with two USB Type-C ports, both supporting DP
alt mode. Enable output on both of them. Explicitly list supported
frequencies including HBR3/8.1Gbps for all external DisplayPort(s).

Due to support missing in the USB/DisplayPort combo PHY driver,
the external DisplayPort is limited to 2 lanes.

Derived from:
arm64: dts: qcom: x1e80100-t14s: Add external DP support

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
 .../boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
index 86e87f03b0ec..124051334be0 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
@@ -770,6 +770,24 @@ &mdss {
 	status = "okay";
 };
 
+&mdss_dp0 {
+	status = "okay";
+};
+
+&mdss_dp0_out {
+	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp1 {
+	status = "okay";
+};
+
+&mdss_dp1_out {
+	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
 &mdss_dp3 {
 	/delete-property/ #sound-dai-cells;
 
-- 
2.45.2

Re: [PATCH v1 1/4] arm64: dts: qcom: x1e80100-dell-xps13-9345: Enable external DP support

[Konrad Dybcio]

On 27.02.2025 12:12 AM, Aleksandrs Vinarskis wrote:
> Particular laptops comes with two USB Type-C ports, both supporting DP
> alt mode. Enable output on both of them. Explicitly list supported
> frequencies including HBR3/8.1Gbps for all external DisplayPort(s).
> 
> Due to support missing in the USB/DisplayPort combo PHY driver,
> the external DisplayPort is limited to 2 lanes.
> 
> Derived from:
> arm64: dts: qcom: x1e80100-t14s: Add external DP support
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH v1 2/4] arm64: dts: qcom: x1e001de-devkit: Enable HBR3 on external DPs

[Aleksandrs Vinarskis]

When no link frequencies are set, msm/dp driver defaults to HBR2 speed.
Explicitly list supported frequencies including HBR3/8.1Gbps for all
external DisplayPort(s).

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index 5e3970b26e2f..602bd793e09c 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -942,6 +942,7 @@ &mdss_dp0 {
 
 &mdss_dp0_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &mdss_dp1 {
@@ -950,6 +951,7 @@ &mdss_dp1 {
 
 &mdss_dp1_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &mdss_dp2 {
@@ -958,6 +960,7 @@ &mdss_dp2 {
 
 &mdss_dp2_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &pcie4 {
-- 
2.45.2

Re: [PATCH v1 2/4] arm64: dts: qcom: x1e001de-devkit: Enable HBR3 on external DPs

[Konrad Dybcio]

On 27.02.2025 12:12 AM, Aleksandrs Vinarskis wrote:
> When no link frequencies are set, msm/dp driver defaults to HBR2 speed.
> Explicitly list supported frequencies including HBR3/8.1Gbps for all
> external DisplayPort(s).
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH v1 3/4] arm64: dts: qcom: x1e80100-hp-x14: Enable HBR3 on external DPs

[Aleksandrs Vinarskis]

When no link frequencies are set, msm/dp driver defaults to HBR2 speed.
Explicitly list supported frequencies including HBR3/8.1Gbps for all
external DisplayPort(s).

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
 arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
index cd860a246c45..569748c48200 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts
@@ -1139,6 +1139,7 @@ &mdss_dp0 {
 
 &mdss_dp0_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &mdss_dp1 {
@@ -1147,6 +1148,7 @@ &mdss_dp1 {
 
 &mdss_dp1_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &mdss_dp3 {
-- 
2.45.2

Re: [PATCH v1 3/4] arm64: dts: qcom: x1e80100-hp-x14: Enable HBR3 on external DPs

[Konrad Dybcio]

On 27.02.2025 12:12 AM, Aleksandrs Vinarskis wrote:
> When no link frequencies are set, msm/dp driver defaults to HBR2 speed.
> Explicitly list supported frequencies including HBR3/8.1Gbps for all
> external DisplayPort(s).
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH v1 4/4] arm64: dts: qcom: x1e80100-qcp: Enable HBR3 on external DPs

[Aleksandrs Vinarskis]

When no link frequencies are set, msm/dp driver defaults to HBR2 speed.
Explicitly list supported frequencies including HBR3/8.1Gbps for all
external DisplayPort(s).

Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
---
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index ec594628304a..600d0c8a08ef 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -751,6 +751,7 @@ &mdss_dp0 {
 
 &mdss_dp0_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &mdss_dp1 {
@@ -759,6 +760,7 @@ &mdss_dp1 {
 
 &mdss_dp1_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &mdss_dp2 {
@@ -767,6 +769,7 @@ &mdss_dp2 {
 
 &mdss_dp2_out {
 	data-lanes = <0 1>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
 };
 
 &mdss_dp3 {
-- 
2.45.2

Re: [PATCH v1 4/4] arm64: dts: qcom: x1e80100-qcp: Enable HBR3 on external DPs

[Konrad Dybcio]

On 27.02.2025 12:12 AM, Aleksandrs Vinarskis wrote:
> When no link frequencies are set, msm/dp driver defaults to HBR2 speed.
> Explicitly list supported frequencies including HBR3/8.1Gbps for all
> external DisplayPort(s).
> 
> Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v1 0/4] X1E Dell XPS 9345 External DisplayPort, HBR3 fixes

[Bjorn Andersson]

On Thu, 27 Feb 2025 00:12:08 +0100, Aleksandrs Vinarskis wrote:
> As initial LTTPR support for msm driver [1] has landed, enable external
> DisplayPort on Dell XPS 9345. It appears that supported frequencies
> need to be listed to allow HBR3 speeds.
> 
> While at it, enable HBR3 speeds on other X1E laptops that have external
> DisplayPort enabled already.
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: qcom: x1e80100-dell-xps13-9345: Enable external DP support
      commit: 01a3d5e3cdc833292bdc80a4320235551083982f
[2/4] arm64: dts: qcom: x1e001de-devkit: Enable HBR3 on external DPs
      commit: 027dcb3de88dfd1b82f5f712361d216f209110b0
[3/4] arm64: dts: qcom: x1e80100-hp-x14: Enable HBR3 on external DPs
      commit: 9a49698252b78471a61873b4fe27dfd2e2fe2bad
[4/4] arm64: dts: qcom: x1e80100-qcp: Enable HBR3 on external DPs
      commit: c72c7105c82de59fb711f8379843f80b4abef7e3

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>