* [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data
@ 2025-02-28 8:29 Johan Hovold
2025-02-28 8:35 ` neil.armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Johan Hovold @ 2025-02-28 8:29 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J . Wysocki ,
Daniel Lezcano
Cc: Zhang Rui, Lukasz Luba, linux-arm-msm, linux-pm, linux-kernel,
Johan Hovold
The platform device driver data has not been used since commit
7a4ca51b7040 ("thermal/drivers/qcom-spmi: Use devm_iio_channel_get") so
drop the unnecessary assignment.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
I noticed this when doing some rework for pm8008 last year that I have
yet to finish.
This can go in meanwhile.
Johan
drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
index c2d59cbfaea9..a81e7d6e865f 100644
--- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
+++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
@@ -360,7 +360,6 @@ static int qpnp_tm_probe(struct platform_device *pdev)
if (!chip)
return -ENOMEM;
- dev_set_drvdata(&pdev->dev, chip);
chip->dev = &pdev->dev;
mutex_init(&chip->lock);
--
2.45.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data
2025-02-28 8:29 [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data Johan Hovold
@ 2025-02-28 8:35 ` neil.armstrong
2025-02-28 10:17 ` Dmitry Baryshkov
2025-03-12 16:08 ` Daniel Lezcano
2 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2025-02-28 8:35 UTC (permalink / raw)
To: Johan Hovold, Amit Kucheria, Thara Gopinath, Rafael J . Wysocki,
Daniel Lezcano
Cc: Zhang Rui, Lukasz Luba, linux-arm-msm, linux-pm, linux-kernel
On 28/02/2025 09:29, Johan Hovold wrote:
> The platform device driver data has not been used since commit
> 7a4ca51b7040 ("thermal/drivers/qcom-spmi: Use devm_iio_channel_get") so
> drop the unnecessary assignment.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> I noticed this when doing some rework for pm8008 last year that I have
> yet to finish.
>
> This can go in meanwhile.
>
> Johan
>
>
> drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> index c2d59cbfaea9..a81e7d6e865f 100644
> --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> @@ -360,7 +360,6 @@ static int qpnp_tm_probe(struct platform_device *pdev)
> if (!chip)
> return -ENOMEM;
>
> - dev_set_drvdata(&pdev->dev, chip);
> chip->dev = &pdev->dev;
>
> mutex_init(&chip->lock);
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data
2025-02-28 8:29 [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data Johan Hovold
2025-02-28 8:35 ` neil.armstrong
@ 2025-02-28 10:17 ` Dmitry Baryshkov
2025-03-12 16:08 ` Daniel Lezcano
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-28 10:17 UTC (permalink / raw)
To: Johan Hovold
Cc: Amit Kucheria, Thara Gopinath, Rafael J . Wysocki ,
Daniel Lezcano, Zhang Rui, Lukasz Luba, linux-arm-msm, linux-pm,
linux-kernel
On Fri, Feb 28, 2025 at 09:29:36AM +0100, Johan Hovold wrote:
> The platform device driver data has not been used since commit
> 7a4ca51b7040 ("thermal/drivers/qcom-spmi: Use devm_iio_channel_get") so
> drop the unnecessary assignment.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> I noticed this when doing some rework for pm8008 last year that I have
> yet to finish.
>
> This can go in meanwhile.
>
> Johan
>
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data
2025-02-28 8:29 [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data Johan Hovold
2025-02-28 8:35 ` neil.armstrong
2025-02-28 10:17 ` Dmitry Baryshkov
@ 2025-03-12 16:08 ` Daniel Lezcano
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2025-03-12 16:08 UTC (permalink / raw)
To: Johan Hovold, Amit Kucheria, Thara Gopinath, Rafael J . Wysocki
Cc: Zhang Rui, Lukasz Luba, linux-arm-msm, linux-pm, linux-kernel
On 28/02/2025 09:29, Johan Hovold wrote:
> The platform device driver data has not been used since commit
> 7a4ca51b7040 ("thermal/drivers/qcom-spmi: Use devm_iio_channel_get") so
> drop the unnecessary assignment.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> I noticed this when doing some rework for pm8008 last year that I have
> yet to finish.
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-12 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-28 8:29 [PATCH] thermal/drivers/qcom-spmi-temp-alarm: drop unused driver data Johan Hovold
2025-02-28 8:35 ` neil.armstrong
2025-02-28 10:17 ` Dmitry Baryshkov
2025-03-12 16:08 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox