[PATCH 0/2] selftests/pidfd: Fix missing headers

[PATCH 0/2] selftests/pidfd: Fix missing headers

[Siddharth Menon]

Fix compilation errors caused by missing headers in the pidfd selftest.

The errors include:
pidfd_fdinfo_test.c:230:13: error: implicit declaration of function ‘mount’
pidfd_setns_test.c:172:54: error: implicit declaration of function ‘ioctl’

Siddharth Menon (2):
  selftests/pidfd: Fix missing header
  selftests/pidfd: Fix missing header

 tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
 tools/testing/selftests/pidfd/pidfd_setns_test.c  | 1 +
 2 files changed, 2 insertions(+)

-- 
2.48.1

[PATCH 1/2] selftests/pidfd: Fix missing header

[Siddharth Menon]

Fix compilation errors caused by the missing sys/mount.h header
---
 tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
index f062a986e382..f718aac75068 100644
--- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c
@@ -13,6 +13,7 @@
 #include <syscall.h>
 #include <sys/wait.h>
 #include <sys/mman.h>
+#include <sys/mount.h>
 
 #include "pidfd.h"
 #include "../kselftest.h"
-- 
2.48.1

[PATCH 2/2] selftests/pidfd: Fix missing header

[Siddharth Menon]

Fix compilation errors caused by the missing sys/ioctl.h header
---
 tools/testing/selftests/pidfd/pidfd_setns_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/pidfd/pidfd_setns_test.c b/tools/testing/selftests/pidfd/pidfd_setns_test.c
index 222f8131283b..4c8a0253a64f 100644
--- a/tools/testing/selftests/pidfd/pidfd_setns_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_setns_test.c
@@ -17,6 +17,7 @@
 #include <sys/socket.h>
 #include <sys/stat.h>
 #include <linux/ioctl.h>
+#include <sys/ioctl.h>
 
 #include "pidfd.h"
 #include "../kselftest_harness.h"
-- 
2.48.1

Re: [PATCH 0/2] selftests/pidfd: Fix missing headers

[Peter Seiderer]

Hello Siddharth,

On Mon,  3 Mar 2025 02:22:44 +0530, Siddharth Menon <simeddon@gmail.com> wrote:

> Fix compilation errors caused by missing headers in the pidfd selftest.
> 
> The errors include:
> pidfd_fdinfo_test.c:230:13: error: implicit declaration of function ‘mount’
> pidfd_setns_test.c:172:54: error: implicit declaration of function ‘ioctl’
> 
> Siddharth Menon (2):
>   selftests/pidfd: Fix missing header
>   selftests/pidfd: Fix missing header
> 
>  tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 +
>  tools/testing/selftests/pidfd/pidfd_setns_test.c  | 1 +
>  2 files changed, 2 insertions(+)
> 

Predated patches already available, see

        https://lore.kernel.org/linux-kselftest/20250115105211.390370-1-ps.report@gmx.net/
        https://lore.kernel.org/linux-kselftest/20250115105211.390370-2-ps.report@gmx.net/
	https://lore.kernel.org/linux-kselftest/20250115105211.390370-3-ps.report@gmx.net/

Regards,
Peter