From: Brian Gerst <brgerst@gmail.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, Ard Biesheuvel <ardb@kernel.org>,
Uros Bizjak <ubizjak@gmail.com>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Brian Gerst <brgerst@gmail.com>
Subject: [PATCH v3 02/11] x86/percpu: Move pcpu_hot to percpu hot section
Date: Mon, 3 Mar 2025 11:52:37 -0500 [thread overview]
Message-ID: <20250303165246.2175811-3-brgerst@gmail.com> (raw)
In-Reply-To: <20250303165246.2175811-1-brgerst@gmail.com>
No functional change.
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/include/asm/current.h | 28 +++++++++++-----------------
arch/x86/kernel/cpu/common.c | 2 +-
arch/x86/kernel/vmlinux.lds.S | 3 +++
3 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/arch/x86/include/asm/current.h b/arch/x86/include/asm/current.h
index bf5953883ec3..60bc66edca83 100644
--- a/arch/x86/include/asm/current.h
+++ b/arch/x86/include/asm/current.h
@@ -13,32 +13,26 @@
struct task_struct;
struct pcpu_hot {
- union {
- struct {
- struct task_struct *current_task;
- int preempt_count;
- int cpu_number;
+ struct task_struct *current_task;
+ int preempt_count;
+ int cpu_number;
#ifdef CONFIG_MITIGATION_CALL_DEPTH_TRACKING
- u64 call_depth;
+ u64 call_depth;
#endif
- unsigned long top_of_stack;
- void *hardirq_stack_ptr;
- u16 softirq_pending;
+ unsigned long top_of_stack;
+ void *hardirq_stack_ptr;
+ u16 softirq_pending;
#ifdef CONFIG_X86_64
- bool hardirq_stack_inuse;
+ bool hardirq_stack_inuse;
#else
- void *softirq_stack_ptr;
+ void *softirq_stack_ptr;
#endif
- };
- u8 pad[64];
- };
};
-static_assert(sizeof(struct pcpu_hot) == 64);
-DECLARE_PER_CPU_ALIGNED(struct pcpu_hot, pcpu_hot);
+DECLARE_PER_CPU_CACHE_HOT(struct pcpu_hot, pcpu_hot);
/* const-qualified alias to pcpu_hot, aliased by linker. */
-DECLARE_PER_CPU_ALIGNED(const struct pcpu_hot __percpu_seg_override,
+DECLARE_PER_CPU_CACHE_HOT(const struct pcpu_hot __percpu_seg_override,
const_pcpu_hot);
static __always_inline struct task_struct *get_current(void)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 7d33c45ad241..c33eaca1e9f9 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -2049,7 +2049,7 @@ static __init int setup_setcpuid(char *arg)
}
__setup("setcpuid=", setup_setcpuid);
-DEFINE_PER_CPU_ALIGNED(struct pcpu_hot, pcpu_hot) = {
+DEFINE_PER_CPU_CACHE_HOT(struct pcpu_hot, pcpu_hot) = {
.current_task = &init_task,
.preempt_count = INIT_PREEMPT_COUNT,
.top_of_stack = TOP_OF_INIT_STACK,
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 1769a7126224..7586a9be8c59 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -187,6 +187,8 @@ SECTIONS
PAGE_ALIGNED_DATA(PAGE_SIZE)
+ CACHE_HOT_DATA(L1_CACHE_BYTES)
+
CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
DATA_DATA
@@ -328,6 +330,7 @@ SECTIONS
}
PERCPU_SECTION(INTERNODE_CACHE_BYTES)
+ ASSERT(__per_cpu_hot_end - __per_cpu_hot_start <= 64, "percpu cache hot section too large")
RUNTIME_CONST_VARIABLES
RUNTIME_CONST(ptr, USER_PTR_MAX)
--
2.48.1
next prev parent reply other threads:[~2025-03-03 16:53 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 16:52 [PATCH v3 00/11] Add a percpu subsection for cache hot data Brian Gerst
2025-03-03 16:52 ` [PATCH v3 01/11] percpu: Introduce percpu hot section Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:34 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` Brian Gerst [this message]
2025-03-04 8:27 ` [tip: x86/core] x86/percpu: Move pcpu_hot to " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:34 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 03/11] x86/preempt: Move preempt count " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:34 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 04/11] x86/smp: Move cpu number " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:34 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 05/11] x86/retbleed: Move call depth " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:34 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 06/11] x86/softirq: Move softirq_pending " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:34 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 07/11] x86/irq: Move irq stacks " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:34 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 08/11] x86/percpu: Move top_of_stack " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:33 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 09/11] x86/percpu: Move current_task " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:33 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 10/11] x86/stackprotector: Move __stack_chk_guard " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:33 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 16:52 ` [PATCH v3 11/11] x86/smp: Move this_cpu_off " Brian Gerst
2025-03-04 8:27 ` [tip: x86/core] " tip-bot2 for Brian Gerst
2025-03-04 10:36 ` tip-bot2 for Brian Gerst
2025-03-04 19:33 ` tip-bot2 for Brian Gerst
2025-03-04 19:43 ` tip-bot2 for Brian Gerst
2025-03-03 19:53 ` [PATCH v3 00/11] Add a percpu subsection for cache hot data Uros Bizjak
2025-03-03 20:38 ` Ingo Molnar
2025-03-03 20:55 ` Brian Gerst
2025-03-04 8:47 ` Ingo Molnar
2025-03-04 9:26 ` Brian Gerst
2025-03-04 9:47 ` Ingo Molnar
2025-03-04 9:52 ` Uros Bizjak
2025-03-04 9:55 ` Ingo Molnar
2025-03-04 15:00 ` Brian Gerst
2025-03-04 16:01 ` Uros Bizjak
2025-03-04 16:42 ` Brian Gerst
2025-03-04 16:48 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303165246.2175811-3-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox