[PATCH 0/2] drm/msm/dpu: two fixes for kerneldocs

[PATCH 0/2] drm/msm/dpu: two fixes for kerneldocs

[Dmitry Baryshkov]

Signed-off-by: Dmitry Baryshkov <lumag@kernel.org>
---
Dmitry Baryshkov (2):
      drm/msm/dpu: correct dpu_crtc_check_mode_changed docs
      drm/msm/dpu: correct struct dpu_encoder_virt docs

 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c    | 3 ++-
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
---
base-commit: 6d3175a72cc07e90f81fb35841048a8a9b5134cb
change-id: 20250306-dpu-fix-docs-3700642b33ea

Best regards,
-- 
Dmitry Baryshkov <lumag@kernel.org>

[PATCH 1/2] drm/msm/dpu: correct dpu_crtc_check_mode_changed docs

[Dmitry Baryshkov]

Correct commit 20972609d12c ("drm/msm/dpu: Require modeset if clone mode
status changes") and describe old_crtc_state and new_crtc_state params
instead of the single previously used parameter crtc_state.

Fixes: 20972609d12c ("drm/msm/dpu: Require modeset if clone mode status changes")
Signed-off-by: Dmitry Baryshkov <lumag@kernel.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index b0a062d6fa3bf942ffd687a91bccac3aa4f06f02..536d15818ba24f8b11f24e3bd9726d31c57ef531 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -1395,7 +1395,8 @@ static int dpu_crtc_assign_resources(struct drm_crtc *crtc,
 
 /**
  * dpu_crtc_check_mode_changed: check if full modeset is required
- * @crtc_state:	Corresponding CRTC state to be checked
+ * @old_crtc_state:	Previous CRTC state
+ * @new_crtc_state:	Corresponding CRTC state to be checked
  *
  * Check if the changes in the object properties demand full mode set.
  */

-- 
2.39.5

Re: [PATCH 1/2] drm/msm/dpu: correct dpu_crtc_check_mode_changed docs

[Rob Clark]

On Thu, Mar 6, 2025 at 12:22 AM Dmitry Baryshkov <lumag@kernel.org> wrote:
>
> Correct commit 20972609d12c ("drm/msm/dpu: Require modeset if clone mode
> status changes") and describe old_crtc_state and new_crtc_state params
> instead of the single previously used parameter crtc_state.
>
> Fixes: 20972609d12c ("drm/msm/dpu: Require modeset if clone mode status changes")
> Signed-off-by: Dmitry Baryshkov <lumag@kernel.org>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index b0a062d6fa3bf942ffd687a91bccac3aa4f06f02..536d15818ba24f8b11f24e3bd9726d31c57ef531 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -1395,7 +1395,8 @@ static int dpu_crtc_assign_resources(struct drm_crtc *crtc,
>
>  /**
>   * dpu_crtc_check_mode_changed: check if full modeset is required
> - * @crtc_state:        Corresponding CRTC state to be checked
> + * @old_crtc_state:    Previous CRTC state
> + * @new_crtc_state:    Corresponding CRTC state to be checked
>   *
>   * Check if the changes in the object properties demand full mode set.
>   */
>
> --
> 2.39.5
>

[PATCH 2/2] drm/msm/dpu: correct struct dpu_encoder_virt docs

[Dmitry Baryshkov]

Fix a typo in struct dpu_encoder_virt kerneldoc, which made it ignore
description of the cwb_mask field.

Fixes: dd331404ac7c ("drm/msm/dpu: Configure CWB in writeback encoder")
Signed-off-by: Dmitry Baryshkov <lumag@kernel.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 0eed93a4d056beda6b54c0d20f027a53c84f67db..0637be07eb293041a350161b39a6276eb44bfb42 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -140,7 +140,7 @@ enum dpu_enc_rc_states {
  *			num_phys_encs.
  * @hw_dsc:		Handle to the DSC blocks used for the display.
  * @dsc_mask:		Bitmask of used DSC blocks.
- * @cwb_mask		Bitmask of used CWB muxes
+ * @cwb_mask:		Bitmask of used CWB muxes
  * @intfs_swapped:	Whether or not the phys_enc interfaces have been swapped
  *			for partial update right-only cases, such as pingpong
  *			split where virtual pingpong does not generate IRQs

-- 
2.39.5

Re: [PATCH 2/2] drm/msm/dpu: correct struct dpu_encoder_virt docs

[Rob Clark]

On Thu, Mar 6, 2025 at 12:22 AM Dmitry Baryshkov <lumag@kernel.org> wrote:
>
> Fix a typo in struct dpu_encoder_virt kerneldoc, which made it ignore
> description of the cwb_mask field.
>
> Fixes: dd331404ac7c ("drm/msm/dpu: Configure CWB in writeback encoder")
> Signed-off-by: Dmitry Baryshkov <lumag@kernel.org>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 0eed93a4d056beda6b54c0d20f027a53c84f67db..0637be07eb293041a350161b39a6276eb44bfb42 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -140,7 +140,7 @@ enum dpu_enc_rc_states {
>   *                     num_phys_encs.
>   * @hw_dsc:            Handle to the DSC blocks used for the display.
>   * @dsc_mask:          Bitmask of used DSC blocks.
> - * @cwb_mask           Bitmask of used CWB muxes
> + * @cwb_mask:          Bitmask of used CWB muxes
>   * @intfs_swapped:     Whether or not the phys_enc interfaces have been swapped
>   *                     for partial update right-only cases, such as pingpong
>   *                     split where virtual pingpong does not generate IRQs
>
> --
> 2.39.5
>

Re: [PATCH 0/2] drm/msm/dpu: two fixes for kerneldocs

[Dmitry Baryshkov]

From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


On Thu, 06 Mar 2025 10:22:28 +0200, Dmitry Baryshkov wrote:
> 


Applied, thanks!

[1/2] drm/msm/dpu: correct dpu_crtc_check_mode_changed docs
      https://gitlab.freedesktop.org/lumag/msm/-/commit/096775c3dcf3
[2/2] drm/msm/dpu: correct struct dpu_encoder_virt docs
      https://gitlab.freedesktop.org/lumag/msm/-/commit/2ee664833000

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>