From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Louis Taylor <louis@kragniz.eu>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] tools/nolibc: mark more test functions as static
Date: Thu, 6 Mar 2025 18:06:32 +0100 [thread overview]
Message-ID: <20250306170631.GB23569@1wt.eu> (raw)
In-Reply-To: <61636d83-8154-4e7b-850b-1c4ed9a2c2f2@t-8ch.de>
On Thu, Mar 06, 2025 at 06:00:17PM +0100, Thomas Weißschuh wrote:
> On 2025-03-04 07:58:19+0000, Louis Taylor wrote:
> > It was mentioned that a new test_ function should be static, so go back
> > over existing functions and mark those static as well.
>
> Actually Willy wants these non-static for debugging purposes.
> I can't seem to get that into my head -.-
> Let's drop this one.
I don't remember but it was probably to be able to break into them with
gdb and/or to check the disassembled code when in doubt about anything.
Willy
next prev parent reply other threads:[~2025-03-06 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 7:58 [PATCH v2 1/5] tools/nolibc: add support for openat(2) Louis Taylor
2025-03-04 7:58 ` [PATCH v2 2/5] tools/nolibc: always use openat(2) instead of open(2) Louis Taylor
2025-03-06 16:56 ` Thomas Weißschuh
2025-03-04 7:58 ` [PATCH v2 3/5] tools/nolibc: process open() vararg as mode_t Louis Taylor
2025-03-06 16:56 ` Thomas Weißschuh
2025-03-04 7:58 ` [PATCH v2 4/5] tools/nolibc: drop outdated example from overview comment Louis Taylor
2025-03-06 16:58 ` Thomas Weißschuh
2025-03-04 7:58 ` [PATCH v2 5/5] tools/nolibc: mark more test functions as static Louis Taylor
2025-03-06 17:00 ` Thomas Weißschuh
2025-03-06 17:06 ` Willy Tarreau [this message]
2025-03-04 8:11 ` [PATCH v2 1/5] tools/nolibc: add support for openat(2) Willy Tarreau
2025-03-06 17:22 ` Thomas Weißschuh
2025-03-06 17:42 ` Willy Tarreau
2025-03-06 17:10 ` Thomas Weißschuh
2025-03-06 18:30 ` Louis Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306170631.GB23569@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=louis@kragniz.eu \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox