public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Louis Taylor <louis@kragniz.eu>, Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 1/5] tools/nolibc: add support for openat(2)
Date: Thu, 6 Mar 2025 18:42:07 +0100	[thread overview]
Message-ID: <20250306174207.GD23569@1wt.eu> (raw)
In-Reply-To: <598c8370-507b-4d6f-bf7e-ce17a3b5dca0@t-8ch.de>

Hi Thomas,

On Thu, Mar 06, 2025 at 06:22:45PM +0100, Thomas Weißschuh wrote:
> Hi Willy,
> 
> On 2025-03-04 09:11:16+0100, Willy Tarreau wrote:
> > On Tue, Mar 04, 2025 at 07:58:15AM +0000, Louis Taylor wrote:
> > > openat is useful to avoid needing to construct relative paths, so expose
> > > a wrapper for using it directly.
> > 
> > Reviewed the whole series, no comments from me. Let's wait for Thomas
> > to double-check but for me it's OK:
> > 
> > Acked-by: Willy Tarreau <w@1wt.eu>
> 
> Fairly happy with it, only some tiny nitpicks.

Thanks for double-checking, you caught way more things than me!

> > Thomas, since you already have plenty of changes in queue, do you mind
> > if I let you pick this series ?
> 
> Sure.
> 
> Also we need to send a PR to Shuah soon.
> I have some patches I want to get into it.
> In case you missed it:
> https://lore.kernel.org/lkml/20250305-nolibc-asm-headers-v1-1-f2053def2ee7@linutronix.de/

Yes I noticed them, these days I'm totally overwhelmed and tend to only
be able to have a look at them during my week-ends :-(

> Also the removal of the constructor order validation.

Yes, not sure I'll have time for it yet :-( I can try, though!

> Will you send a patch or should I?

As last time it will greatly help me if you take care of it. I
feel like I'm leaving you with all the work these days :-/

Cheers,
Willy

  reply	other threads:[~2025-03-06 17:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04  7:58 [PATCH v2 1/5] tools/nolibc: add support for openat(2) Louis Taylor
2025-03-04  7:58 ` [PATCH v2 2/5] tools/nolibc: always use openat(2) instead of open(2) Louis Taylor
2025-03-06 16:56   ` Thomas Weißschuh
2025-03-04  7:58 ` [PATCH v2 3/5] tools/nolibc: process open() vararg as mode_t Louis Taylor
2025-03-06 16:56   ` Thomas Weißschuh
2025-03-04  7:58 ` [PATCH v2 4/5] tools/nolibc: drop outdated example from overview comment Louis Taylor
2025-03-06 16:58   ` Thomas Weißschuh
2025-03-04  7:58 ` [PATCH v2 5/5] tools/nolibc: mark more test functions as static Louis Taylor
2025-03-06 17:00   ` Thomas Weißschuh
2025-03-06 17:06     ` Willy Tarreau
2025-03-04  8:11 ` [PATCH v2 1/5] tools/nolibc: add support for openat(2) Willy Tarreau
2025-03-06 17:22   ` Thomas Weißschuh
2025-03-06 17:42     ` Willy Tarreau [this message]
2025-03-06 17:10 ` Thomas Weißschuh
2025-03-06 18:30   ` Louis Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250306174207.GD23569@1wt.eu \
    --to=w@1wt.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=louis@kragniz.eu \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox