The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [for-next][PATCH 0/3] tracing: Updates for v6.15
@ 2025-03-07  0:45 Steven Rostedt
  2025-03-07  0:45 ` [for-next][PATCH 1/3] tracing/user_events: Dont use %pK through printk Steven Rostedt
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Steven Rostedt @ 2025-03-07  0:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/for-next

Head SHA1: d4ae5070733b114b9431a49c9640437f5e8b2ec5


Christophe JAILLET (1):
      tracing/user_events: Slightly simplify user_seq_show()

Steven Rostedt (1):
      tracing: Update MAINTAINERS file to include tracepoint.c

Thomas Weißschuh (1):
      tracing/user_events: Don't use %pK through printk

----
 MAINTAINERS                      | 1 +
 kernel/trace/trace_events_user.c | 7 ++-----
 2 files changed, 3 insertions(+), 5 deletions(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [for-next][PATCH 1/3] tracing/user_events: Dont use %pK through printk
  2025-03-07  0:45 [for-next][PATCH 0/3] tracing: Updates for v6.15 Steven Rostedt
@ 2025-03-07  0:45 ` Steven Rostedt
  2025-03-07  0:45 ` [for-next][PATCH 2/3] tracing/user_events: Slightly simplify user_seq_show() Steven Rostedt
  2025-03-07  0:45 ` [for-next][PATCH 3/3] tracing: Update MAINTAINERS file to include tracepoint.c Steven Rostedt
  2 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2025-03-07  0:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
	Thomas Weißschuh

From: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>

Restricted pointers ("%pK") are not meant to be used through printk().
It can unintentionally expose security sensitive, raw pointer values.

Use regular pointer formatting instead.

Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20250217-restricted-pointers-trace-v1-1-bbe9ea279848@linutronix.de
Link: https://lore.kernel.org/lkml/20250113171731-dc10e3c1-da64-4af0-b767-7c7070468023@linutronix.de/
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 kernel/trace/trace_events_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 97325fbd6283..3effc6fce20e 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -455,7 +455,7 @@ static void user_event_enabler_fault_fixup(struct work_struct *work)
 	if (ret && ret != -ENOENT) {
 		struct user_event *user = enabler->event;
 
-		pr_warn("user_events: Fault for mm: 0x%pK @ 0x%llx event: %s\n",
+		pr_warn("user_events: Fault for mm: 0x%p @ 0x%llx event: %s\n",
 			mm->mm, (unsigned long long)uaddr, EVENT_NAME(user));
 	}
 
-- 
2.47.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [for-next][PATCH 2/3] tracing/user_events: Slightly simplify user_seq_show()
  2025-03-07  0:45 [for-next][PATCH 0/3] tracing: Updates for v6.15 Steven Rostedt
  2025-03-07  0:45 ` [for-next][PATCH 1/3] tracing/user_events: Dont use %pK through printk Steven Rostedt
@ 2025-03-07  0:45 ` Steven Rostedt
  2025-03-07  0:45 ` [for-next][PATCH 3/3] tracing: Update MAINTAINERS file to include tracepoint.c Steven Rostedt
  2 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2025-03-07  0:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton,
	Christophe JAILLET

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

2 seq_puts() calls can be merged.

It saves a few lines of code and a few cycles, should it matter.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/845caa94b74cea8d72c158bf1994fe250beee28c.1739979791.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 kernel/trace/trace_events_user.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 3effc6fce20e..af42aaa3d172 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -2793,11 +2793,8 @@ static int user_seq_show(struct seq_file *m, void *p)
 
 		seq_printf(m, "%s", EVENT_TP_NAME(user));
 
-		if (status != 0)
-			seq_puts(m, " #");
-
 		if (status != 0) {
-			seq_puts(m, " Used by");
+			seq_puts(m, " # Used by");
 			if (status & EVENT_STATUS_FTRACE)
 				seq_puts(m, " ftrace");
 			if (status & EVENT_STATUS_PERF)
-- 
2.47.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [for-next][PATCH 3/3] tracing: Update MAINTAINERS file to include tracepoint.c
  2025-03-07  0:45 [for-next][PATCH 0/3] tracing: Updates for v6.15 Steven Rostedt
  2025-03-07  0:45 ` [for-next][PATCH 1/3] tracing/user_events: Dont use %pK through printk Steven Rostedt
  2025-03-07  0:45 ` [for-next][PATCH 2/3] tracing/user_events: Slightly simplify user_seq_show() Steven Rostedt
@ 2025-03-07  0:45 ` Steven Rostedt
  2 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2025-03-07  0:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Masami Hiramatsu, Mark Rutland, Mathieu Desnoyers, Andrew Morton

From: Steven Rostedt <rostedt@goodmis.org>

Updates to the tracepoint.c file should not only be Cc'd to LKML, but also
to linux-trace-kernel@vger.kernel.org. But because it is not listed in the
MAINTAINERS file, it does not get added.

Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Link: https://lore.kernel.org/20250304103724.174ecb36@gandalf.local.home
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4ff26fa94895..c203aa4225b0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -24063,6 +24063,7 @@ F:	fs/tracefs/
 F:	include/linux/trace*.h
 F:	include/trace/
 F:	kernel/trace/
+F:	kernel/tracepoint.c
 F:	scripts/tracing/
 F:	tools/testing/selftests/ftrace/
 
-- 
2.47.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-07  0:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-07  0:45 [for-next][PATCH 0/3] tracing: Updates for v6.15 Steven Rostedt
2025-03-07  0:45 ` [for-next][PATCH 1/3] tracing/user_events: Dont use %pK through printk Steven Rostedt
2025-03-07  0:45 ` [for-next][PATCH 2/3] tracing/user_events: Slightly simplify user_seq_show() Steven Rostedt
2025-03-07  0:45 ` [for-next][PATCH 3/3] tracing: Update MAINTAINERS file to include tracepoint.c Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox