* [PATCH] media: pci: mgb4: include linux/errno.h
@ 2025-03-07 10:24 Arnd Bergmann
2025-03-07 18:27 ` Martin Tůma
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-03-07 10:24 UTC (permalink / raw)
To: Martin Tuma, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Ricardo Ribalda, Bryan O'Donoghue, linux-media,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The errno.h header is not always included indirectly, leading
to rare randconfig build warnings.
drivers/media/pci/mgb4/mgb4_regs.c:20:11: error: use of undeclared identifier 'EINVAL'
20 | return -EINVAL;
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/pci/mgb4/mgb4_regs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/mgb4/mgb4_regs.c b/drivers/media/pci/mgb4/mgb4_regs.c
index 31befd722d72..b45537dbfafa 100644
--- a/drivers/media/pci/mgb4/mgb4_regs.c
+++ b/drivers/media/pci/mgb4/mgb4_regs.c
@@ -5,6 +5,7 @@
*/
#include <linux/ioport.h>
+#include <linux/errno.h>
#include "mgb4_regs.h"
int mgb4_regs_map(struct resource *res, struct mgb4_regs *regs)
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: pci: mgb4: include linux/errno.h
2025-03-07 10:24 [PATCH] media: pci: mgb4: include linux/errno.h Arnd Bergmann
@ 2025-03-07 18:27 ` Martin Tůma
0 siblings, 0 replies; 2+ messages in thread
From: Martin Tůma @ 2025-03-07 18:27 UTC (permalink / raw)
To: Arnd Bergmann, Martin Tuma, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Ricardo Ribalda, Bryan O'Donoghue, linux-media,
linux-kernel
On 07. 03. 25 11:24 dop., Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The errno.h header is not always included indirectly, leading
> to rare randconfig build warnings.
>
> drivers/media/pci/mgb4/mgb4_regs.c:20:11: error: use of undeclared identifier 'EINVAL'
> 20 | return -EINVAL;
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/pci/mgb4/mgb4_regs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/pci/mgb4/mgb4_regs.c b/drivers/media/pci/mgb4/mgb4_regs.c
> index 31befd722d72..b45537dbfafa 100644
> --- a/drivers/media/pci/mgb4/mgb4_regs.c
> +++ b/drivers/media/pci/mgb4/mgb4_regs.c
> @@ -5,6 +5,7 @@
> */
>
> #include <linux/ioport.h>
> +#include <linux/errno.h>
> #include "mgb4_regs.h"
>
> int mgb4_regs_map(struct resource *res, struct mgb4_regs *regs)
Acked-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-07 18:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-07 10:24 [PATCH] media: pci: mgb4: include linux/errno.h Arnd Bergmann
2025-03-07 18:27 ` Martin Tůma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox