[PATCH 0/2] arm64: dts: qcom: x1e80100-crd: add support for volume-up key

[PATCH 0/2] arm64: dts: qcom: x1e80100-crd: add support for volume-up key

[Johan Hovold]

Add support for the volume-up key on the debug extension board, which
can also be used as a wakeup source from deep idle states (CX shutdown).

Johan


Johan Hovold (2):
  arm64: dts: qcom: x1e80100-crd: add support for volume-up key
  arm64: dts: qcom: x1e80100-crd: add gpio-keys label for lid switch

 arch/arm64/boot/dts/qcom/x1-crd.dtsi | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

-- 
2.45.3

[PATCH 1/2] arm64: dts: qcom: x1e80100-crd: add support for volume-up key

[Johan Hovold]

Add support for the keypad volume-up key on the debug extension board.

This is useful to have when testing PMIC interrupt handling, and the key
can also be used to wake up from deep suspend states (CX shutdown).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/x1-crd.dtsi | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
index 296b41409ad1..0b62fdc85478 100644
--- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
@@ -52,9 +52,16 @@ chosen {
 	gpio-keys {
 		compatible = "gpio-keys";
 
-		pinctrl-0 = <&hall_int_n_default>;
+		pinctrl-0 = <&hall_int_n_default>, <&kypd_vol_up_n>;
 		pinctrl-names = "default";
 
+		key-vol-up {
+			label = "volume_up";
+			gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEUP>;
+			wakeup-source;
+		};
+
 		switch-lid {
 			gpios = <&tlmm 92 GPIO_ACTIVE_LOW>;
 			linux,input-type = <EV_SW>;
@@ -876,6 +883,16 @@ &pcie6a_phy {
 	status = "okay";
 };
 
+&pm8550_gpios {
+	kypd_vol_up_n: kypd-vol-up-n-state {
+		pins = "gpio6";
+		function = "normal";
+		power-source = <1>; /* 1.8 V */
+		bias-pull-up;
+		input-enable;
+	};
+};
+
 &pm8550ve_8_gpios {
 	misc_3p3_reg_en: misc-3p3-reg-en-state {
 		pins = "gpio6";
-- 
2.45.3

[PATCH 2/2] arm64: dts: qcom: x1e80100-crd: add gpio-keys label for lid switch

[Johan Hovold]

Add a gpio-keys label for the lid-switch for consistency and to separate
it from the volume-up key (e.g. in /proc/interrupts).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/x1-crd.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
index 0b62fdc85478..fc4ea6be5fd1 100644
--- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
@@ -63,6 +63,7 @@ key-vol-up {
 		};
 
 		switch-lid {
+			label = "lid";
 			gpios = <&tlmm 92 GPIO_ACTIVE_LOW>;
 			linux,input-type = <EV_SW>;
 			linux,code = <SW_LID>;
-- 
2.45.3

Re: [PATCH 2/2] arm64: dts: qcom: x1e80100-crd: add gpio-keys label for lid switch

[Konrad Dybcio]

On 7.03.2025 6:12 PM, Johan Hovold wrote:
> Add a gpio-keys label for the lid-switch for consistency and to separate
> it from the volume-up key (e.g. in /proc/interrupts).
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 0/2] arm64: dts: qcom: x1e80100-crd: add support for volume-up key

[Bjorn Andersson]

On Fri, 07 Mar 2025 18:12:20 +0100, Johan Hovold wrote:
> Add support for the volume-up key on the debug extension board, which
> can also be used as a wakeup source from deep idle states (CX shutdown).
> 
> Johan
> 
> 
> Johan Hovold (2):
>   arm64: dts: qcom: x1e80100-crd: add support for volume-up key
>   arm64: dts: qcom: x1e80100-crd: add gpio-keys label for lid switch
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: x1e80100-crd: add support for volume-up key
      commit: 9eca3fd5c336afc3b90804ec008f54ce59320aee
[2/2] arm64: dts: qcom: x1e80100-crd: add gpio-keys label for lid switch
      commit: ee95bcc58890e63f52fdb9ab096c3d7b9cb889cc

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>