From: Simon Horman <horms@kernel.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: muhammad.husaini.zulkifli@intel.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, edumazet@google.com,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] igc: enable HW VLAN insertion/stripping by default
Date: Tue, 11 Mar 2025 14:52:36 +0100 [thread overview]
Message-ID: <20250311135236.GO4159220@kernel.org> (raw)
In-Reply-To: <20250307110339.13788-1-rsalvaterra@gmail.com>
On Fri, Mar 07, 2025 at 11:02:39AM +0000, Rui Salvaterra wrote:
> This is enabled by default in other Intel drivers I've checked (e1000, e1000e,
> iavf, igb and ice). Fixes an out-of-the-box performance issue when running
> OpenWrt on typical mini-PCs with igc-supported Ethernet controllers and 802.1Q
> VLAN configurations, as ethtool isn't part of the default packages and sane
> defaults are expected.
>
> In my specific case, with an Intel N100-based machine with four I226-V Ethernet
> controllers, my upload performance increased from under 30 Mb/s to the expected
> ~1 Gb/s.
>
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
> ---
>
> This patch cost me two afternoons of network debugging, last weekend. Is there
> any plausible reason why VLAN acceleration wasn't enabled by default for this
> driver, specifically?
Having looked over this I am also curious to know the answer to that question.
This does seem to be the default for other Intel drivers (at least).
next prev parent reply other threads:[~2025-03-11 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 11:02 [PATCH] igc: enable HW VLAN insertion/stripping by default Rui Salvaterra
2025-03-11 13:52 ` Simon Horman [this message]
2025-03-11 13:59 ` Rui Salvaterra
2025-03-12 21:43 ` Tony Nguyen
2025-03-13 9:23 ` Rui Salvaterra
2025-03-13 15:49 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311135236.GO4159220@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=rsalvaterra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox