The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Rui Salvaterra <rsalvaterra@gmail.com>, Simon Horman <horms@kernel.org>
Cc: <muhammad.husaini.zulkifli@intel.com>,
	<przemyslaw.kitszel@intel.com>, <edumazet@google.com>,
	<kuba@kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] igc: enable HW VLAN insertion/stripping by default
Date: Wed, 12 Mar 2025 14:43:33 -0700	[thread overview]
Message-ID: <fe021b67-94f6-43e4-9130-7b9a58919b40@intel.com> (raw)
In-Reply-To: <CALjTZvaknxOK4SmyC3_rN5eaCPqd7uvx52ODmDuAp=OeG0wxAA@mail.gmail.com>



On 3/11/2025 6:59 AM, Rui Salvaterra wrote:
> Hi, Simon,
> 
> On Tue, 11 Mar 2025 at 13:52, Simon Horman <horms@kernel.org> wrote:
>>
>> Having looked over this I am also curious to know the answer to that question.
>> This does seem to be the default for other Intel drivers (at least).

Unfortunately, I'm unable check with the original author or those 
involved at the time. From asking around it sounds like there may have 
been some initial issues when implementing this; my theory is this was 
off by default so that it would minimize the affects if additional 
issues were discovered.

I see that you missed Intel Wired LAN (intel-wired-lan@lists.osuosl.org) 
on the patch. Could you resend with the list included? Also, if you 
could make it 'PATCH iwl-next' to target the Intel -next tree as that 
seems the appropriate tree.

Thanks,
Tony

> Well, r8169 also enables it, and RealTek controllers are used everywhere. :)
> 
> Kind regards,
> Rui Salvaterra


  reply	other threads:[~2025-03-12 21:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 11:02 [PATCH] igc: enable HW VLAN insertion/stripping by default Rui Salvaterra
2025-03-11 13:52 ` Simon Horman
2025-03-11 13:59   ` Rui Salvaterra
2025-03-12 21:43     ` Tony Nguyen [this message]
2025-03-13  9:23       ` Rui Salvaterra
2025-03-13 15:49         ` Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe021b67-94f6-43e4-9130-7b9a58919b40@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muhammad.husaini.zulkifli@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=rsalvaterra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox