[PATCH] spi: sophgo: fix incorrect type for ret in sg2044_spifmc_write()

[PATCH] spi: sophgo: fix incorrect type for ret in sg2044_spifmc_write()

[Qasim Ijaz]

The sg2044_spifmc_write() function uses 'ret' of unsigned type 
size_t to capture return values from sg2044_spifmc_wait_xfer_size() 
and sg2044_spifmc_wait_int(). Since these functions may return 
negative error codes, using an unsigned type prevents proper 
error detection, as size_t cannot represent negative values. 

Change 'ret' to type int so that negative values are handled correctly.

Fixes: de16c322eefb ("spi: sophgo: add SG2044 SPI NOR controller driver")
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
 drivers/spi/spi-sg2044-nor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-sg2044-nor.c b/drivers/spi/spi-sg2044-nor.c
index 454153a63b42..baa4cf677663 100644
--- a/drivers/spi/spi-sg2044-nor.c
+++ b/drivers/spi/spi-sg2044-nor.c
@@ -216,7 +216,7 @@ static ssize_t sg2044_spifmc_write(struct sg2044_spifmc *spifmc,
 	size_t xfer_size;
 	const u8 *dout = op->data.buf.out;
 	int i, offset;
-	size_t ret;
+	int ret;
 	u32 reg;
 
 	reg = sg2044_spifmc_init_reg(spifmc);
-- 
2.39.5

Re: [PATCH] spi: sophgo: fix incorrect type for ret in sg2044_spifmc_write()

[Mark Brown]

On Thu, 13 Mar 2025 21:45:45 +0000, Qasim Ijaz wrote:
> The sg2044_spifmc_write() function uses 'ret' of unsigned type
> size_t to capture return values from sg2044_spifmc_wait_xfer_size()
> and sg2044_spifmc_wait_int(). Since these functions may return
> negative error codes, using an unsigned type prevents proper
> error detection, as size_t cannot represent negative values.
> 
> Change 'ret' to type int so that negative values are handled correctly.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: sophgo: fix incorrect type for ret in sg2044_spifmc_write()
      commit: 3c9403f150b70d76198e414d53c95e1698e3f99f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark