From: Purva Yeshi <purvayeshi550@gmail.com>
To: Dave Kleikamp <shaggy@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>
Cc: jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Purva Yeshi <purvayeshi550@gmail.com>,
syzbot+219127d0a3bce650e1b6@syzkaller.appspotmail.com
Subject: [PATCH] fs: jfs: Avoid sleeping function call in softirq
Date: Sat, 22 Mar 2025 19:51:34 +0530 [thread overview]
Message-ID: <20250322142134.35325-1-purvayeshi550@gmail.com> (raw)
Bug detected by Syzbot:
BUG: sleeping function called from invalid context in jfs_fsync
Fix jfs_fsync() to avoid sleeping in softirq/atomic, preventing crash.
Skip execution in softirq/atomic and return -EWOULDBLOCK to prevent issues.
Correct generic_file_fsync() call to pass the required arguments properly.
Reported-by: syzbot+219127d0a3bce650e1b6@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=219127d0a3bce650e1b6
Tested-by: syzbot+219127d0a3bce650e1b6@syzkaller.appspotmail.com
Fixes: 5955102c9984 ("wrappers for ->i_mutex access")
Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
---
fs/jfs/file.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/fs/jfs/file.c b/fs/jfs/file.c
index 93a3e7a45b0f..fc93376eb1e6 100644
--- a/fs/jfs/file.c
+++ b/fs/jfs/file.c
@@ -19,25 +19,17 @@
int jfs_fsync(struct file *file, loff_t start, loff_t end, int datasync)
{
struct inode *inode = file->f_mapping->host;
- int rc = 0;
- rc = file_write_and_wait_range(file, start, end);
- if (rc)
- return rc;
-
- inode_lock(inode);
- if (!(inode->i_state & I_DIRTY_ALL) ||
- (datasync && !(inode->i_state & I_DIRTY_DATASYNC))) {
- /* Make sure committed changes hit the disk */
- jfs_flush_journal(JFS_SBI(inode->i_sb)->log, 1);
- inode_unlock(inode);
- return rc;
+ if (in_softirq() || in_atomic()) {
+ pr_warn("jfs_fsync() called in softirq/atomic context, skipping execution.\n");
+ return -EWOULDBLOCK;
}
- rc |= jfs_commit_inode(inode, 1);
+ inode_lock(inode);
+ generic_file_fsync(file, start, end, datasync);
inode_unlock(inode);
- return rc ? -EIO : 0;
+ return 0;
}
static int jfs_open(struct inode *inode, struct file *file)
--
2.34.1
next reply other threads:[~2025-03-22 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 14:21 Purva Yeshi [this message]
2025-03-22 14:35 ` [PATCH] fs: jfs: Avoid sleeping function call in softirq Al Viro
2025-03-25 17:00 ` Purva Yeshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250322142134.35325-1-purvayeshi550@gmail.com \
--to=purvayeshi550@gmail.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=syzbot+219127d0a3bce650e1b6@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox